New issue
Advanced search Search tips

Issue 843729 link

Starred by 2 users
Status: WontFix
Owner:
charliea@chromium.org
Closed: Aug 6
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 859514
Blocking:
issue 843511



Sign in to add a comment

BattOrConnectionImplTest leaks

Project Member Reported by thakis@chromium.org, May 16 2018 
I'm adding battor_agent_unittests to more bots. It fails on asan:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_asan_rel_ng/13140

BattOrConnectionImplTest.FlushConnectionFlushesAlreadyReadBuffer
BattOrConnectionImplTest.FlushIncompleteBeforeTimeout
BattOrConnectionImplTest.FlushConnectionFlushesBytesReceivedInQuietPeriod


[       OK ] BattOrConnectionImplTest.FlushConnectionFlushesAlreadyReadBuffer (2 ms)
[----------] 1 test from BattOrConnectionImplTest (2 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2 ms total)
[  PASSED  ] 1 test.
=================================================================
==25479==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 288 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x11d8156 in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25:41
    #2 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #3 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #4 0xa413fd in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #5 0xa413fd in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:233
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 100003 byte(s) in 1 object(s) allocated from:
    #0 0x9c9ef2 in operator new[](unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:96:3
    #1 0x15ff775 in net::IOBuffer::IOBuffer(unsigned long) net/base/io_buffer.cc:40:11
    #2 0xa8d422 in MakeRefCounted<net::IOBuffer, unsigned long &> base/memory/scoped_refptr.h:91:16
    #3 0xa8d422 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:226
    #4 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #5 0xa4180c in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #6 0xa4180c in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:240
    #7 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #8 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #9 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #10 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #11 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #13 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #14 0x119746b in Run base/callback.h:96:12
    #15 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #16 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #17 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #18 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x1038b2b in make_unique<base::SequenceCheckerImpl::Core> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x1038b2b in base::SequenceCheckerImpl::CalledOnValidSequence() const base/sequence_checker_impl.cc:42
    #3 0xfc56d5 in base::internal::WeakReference::Flag::Invalidate() base/memory/weak_ptr.cc:20:3
    #4 0xfc5c41 in Invalidate base/memory/weak_ptr.cc:63:12
    #5 0xfc5c41 in base::internal::WeakReferenceOwner::~WeakReferenceOwner() base/memory/weak_ptr.cc:50
    #6 0xa87b31 in ~SupportsWeakPtr base/memory/weak_ptr.h:345:30
    #7 0xa87b31 in battor::BattOrConnectionImpl::~BattOrConnectionImpl() tools/battor_agent/battor_connection_impl.cc:89
    #8 0xa63abd in battor::TestableBattOrConnection::~TestableBattOrConnection() tools/battor_agent/battor_connection_impl_unittest.cc:31:7
    #9 0xa601cd in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
    #10 0xa601cd in reset buildtools/third_party/libc++/trunk/include/memory:2634
    #11 0xa601cd in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
    #12 0xa601cd in ~BattOrConnectionImplTest tools/battor_agent/battor_connection_impl_unittest.cc:49
    #13 0xa601cd in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::~BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test() tools/battor_agent/battor_connection_impl_unittest.cc:204
    #14 0xf5d11e in DeleteSelf_ third_party/googletest/src/googletest/include/gtest/gtest.h:479:24
    #15 0xf5d11e in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2475
    #16 0xf5d11e in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2672
    #17 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #18 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #19 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #20 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #21 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #22 0x119746b in Run base/callback.h:96:12
    #23 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #24 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #25 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #26 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xfc5e16 in base::internal::WeakReferenceOwner::GetRef() const base/memory/weak_ptr.cc:56:13
    #2 0xa8d59f in AsWeakPtr base/memory/weak_ptr.h:341:45
    #3 0xa8d59f in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:231
    #4 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #5 0xa4180c in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #6 0xa4180c in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:240
    #7 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #8 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #9 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #10 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #11 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #13 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #14 0x119746b in Run base/callback.h:96:12
    #15 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #16 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #17 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #18 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x1038998 in make_unique<base::SequenceCheckerImpl::Core> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x1038998 in base::SequenceCheckerImpl::SequenceCheckerImpl() base/sequence_checker_impl.cc:36
    #3 0x11eb6d0 in SequenceChecker base/sequence_checker.h:79:7
    #4 0x11eb6d0 in device::SerialIoHandler::SerialIoHandler(scoped_refptr<base::SingleThreadTaskRunner>) device/serial/serial_io_handler.cc:25
    #5 0x11d818b in TestSerialIoHandler device/serial/test_serial_io_handler.cc:18:7
    #6 0x11d818b in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25
    #7 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #8 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #9 0xa413fd in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #10 0xa413fd in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:233
    #11 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #13 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #14 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #15 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #16 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #17 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #18 0x119746b in Run base/callback.h:96:12
    #19 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #20 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #21 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #22 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d5c4 in BindOnce<void (battor::BattOrConnectionImpl::*)(int, device::mojom::SerialReceiveError), base::WeakPtr<battor::BattOrConnectionImpl> > base/bind.h:213:23
    #2 0xa8d5c4 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:230
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa4180c in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa4180c in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:240
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d725 in make_unique<device::ReceiveBuffer, scoped_refptr<net::IOBuffer> &, unsigned int, base::OnceCallback<void (int, device::mojom::SerialReceiveError)> > buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0xa8d725 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:228
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa4180c in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa4180c in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:240
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d413 in MakeRefCounted<net::IOBuffer, unsigned long &> base/memory/scoped_refptr.h:91:12
    #2 0xa8d413 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:226
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa4180c in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa4180c in battor::BattOrConnectionImplTest_FlushConnectionFlushesAlreadyReadBuffer_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:240
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fb2312e9f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
SUMMARY: AddressSanitizer: 100627 byte(s) leaked in 8 allocation(s).



[ RUN      ] BattOrConnectionImplTest.FlushIncompleteBeforeTimeout
[       OK ] BattOrConnectionImplTest.FlushIncompleteBeforeTimeout (1 ms)
[----------] 1 test from BattOrConnectionImplTest (1 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1 ms total)
[  PASSED  ] 1 test.
=================================================================
==25483==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 288 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x11d8156 in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25:41
    #2 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #3 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #4 0xa48a52 in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #5 0xa48a52 in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:315
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 50000 byte(s) in 1 object(s) allocated from:
    #0 0x9c9ef2 in operator new[](unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:96:3
    #1 0x15ff775 in net::IOBuffer::IOBuffer(unsigned long) net/base/io_buffer.cc:40:11
    #2 0xa907f2 in MakeRefCounted<net::IOBuffer, const unsigned long &> base/memory/scoped_refptr.h:91:16
    #3 0xa907f2 in battor::BattOrConnectionImpl::BeginReadBytesForFlush() tools/battor_agent/battor_connection_impl.cc:329
    #4 0xa48c8f in FlushConnection tools/battor_agent/battor_connection_impl_unittest.cc:89:18
    #5 0xa48c8f in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:319
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x1038998 in make_unique<base::SequenceCheckerImpl::Core> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x1038998 in base::SequenceCheckerImpl::SequenceCheckerImpl() base/sequence_checker_impl.cc:36
    #3 0x11eb6d0 in SequenceChecker base/sequence_checker.h:79:7
    #4 0x11eb6d0 in device::SerialIoHandler::SerialIoHandler(scoped_refptr<base::SingleThreadTaskRunner>) device/serial/serial_io_handler.cc:25
    #5 0x11d818b in TestSerialIoHandler device/serial/test_serial_io_handler.cc:18:7
    #6 0x11d818b in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25
    #7 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #8 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #9 0xa48a52 in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #10 0xa48a52 in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:315
    #11 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #13 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #14 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #15 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #16 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #17 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #18 0x119746b in Run base/callback.h:96:12
    #19 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #20 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #21 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #22 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa9095b in BindOnce<void (battor::BattOrConnectionImpl::*)(int, device::mojom::SerialReceiveError), base::internal::UnretainedWrapper<battor::BattOrConnectionImpl> > base/bind.h:213:23
    #2 0xa9095b in battor::BattOrConnectionImpl::BeginReadBytesForFlush() tools/battor_agent/battor_connection_impl.cc:333
    #3 0xa48c8f in FlushConnection tools/battor_agent/battor_connection_impl_unittest.cc:89:18
    #4 0xa48c8f in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:319
    #5 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #6 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #7 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #8 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #9 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #10 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #11 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #12 0x119746b in Run base/callback.h:96:12
    #13 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #14 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #15 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #16 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa909f8 in make_unique<device::ReceiveBuffer, scoped_refptr<net::IOBuffer> &, unsigned int, base::OnceCallback<void (int, device::mojom::SerialReceiveError)> > buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0xa909f8 in battor::BattOrConnectionImpl::BeginReadBytesForFlush() tools/battor_agent/battor_connection_impl.cc:331
    #3 0xa48c8f in FlushConnection tools/battor_agent/battor_connection_impl_unittest.cc:89:18
    #4 0xa48c8f in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:319
    #5 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #6 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #7 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #8 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #9 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #10 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #11 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #12 0x119746b in Run base/callback.h:96:12
    #13 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #14 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #15 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #16 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa907e2 in MakeRefCounted<net::IOBuffer, const unsigned long &> base/memory/scoped_refptr.h:91:12
    #2 0xa907e2 in battor::BattOrConnectionImpl::BeginReadBytesForFlush() tools/battor_agent/battor_connection_impl.cc:329
    #3 0xa48c8f in FlushConnection tools/battor_agent/battor_connection_impl_unittest.cc:89:18
    #4 0xa48c8f in battor::BattOrConnectionImplTest_FlushIncompleteBeforeTimeout_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:319
    #5 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #6 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #7 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #8 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #9 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #10 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #11 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #12 0x119746b in Run base/callback.h:96:12
    #13 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #14 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #15 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #16 0x7fd0cf576f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
SUMMARY: AddressSanitizer: 50472 byte(s) leaked in 6 allocation(s).



[ RUN      ] BattOrConnectionImplTest.FlushConnectionFlushesBytesReceivedInQuietPeriod
[       OK ] BattOrConnectionImplTest.FlushConnectionFlushesBytesReceivedInQuietPeriod (2 ms)
[----------] 1 test from BattOrConnectionImplTest (2 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2 ms total)
[  PASSED  ] 1 test.
=================================================================
==25481==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 288 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x11d8156 in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25:41
    #2 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #3 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #4 0xa44ced in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #5 0xa44ced in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:268
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x1038998 in make_unique<base::SequenceCheckerImpl::Core> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x1038998 in base::SequenceCheckerImpl::SequenceCheckerImpl() base/sequence_checker_impl.cc:36
    #3 0x11eb6d0 in SequenceChecker base/sequence_checker.h:79:7
    #4 0x11eb6d0 in device::SerialIoHandler::SerialIoHandler(scoped_refptr<base::SingleThreadTaskRunner>) device/serial/serial_io_handler.cc:25
    #5 0x11d818b in TestSerialIoHandler device/serial/test_serial_io_handler.cc:18:7
    #6 0x11d818b in device::TestSerialIoHandler::Create() device/serial/test_serial_io_handler.cc:25
    #7 0xa63add in battor::TestableBattOrConnection::CreateIoHandler() tools/battor_agent/battor_connection_impl_unittest.cc:39:12
    #8 0xa88408 in battor::BattOrConnectionImpl::Open() tools/battor_agent/battor_connection_impl.cc:102:17
    #9 0xa44ced in OpenConnection tools/battor_agent/battor_connection_impl_unittest.cc:83:18
    #10 0xa44ced in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:268
    #11 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #13 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #14 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #15 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #16 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #17 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #18 0x119746b in Run base/callback.h:96:12
    #19 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #20 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #21 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #22 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0x1038b2b in make_unique<base::SequenceCheckerImpl::Core> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x1038b2b in base::SequenceCheckerImpl::CalledOnValidSequence() const base/sequence_checker_impl.cc:42
    #3 0xfc56d5 in base::internal::WeakReference::Flag::Invalidate() base/memory/weak_ptr.cc:20:3
    #4 0xfc5c41 in Invalidate base/memory/weak_ptr.cc:63:12
    #5 0xfc5c41 in base::internal::WeakReferenceOwner::~WeakReferenceOwner() base/memory/weak_ptr.cc:50
    #6 0xa87b31 in ~SupportsWeakPtr base/memory/weak_ptr.h:345:30
    #7 0xa87b31 in battor::BattOrConnectionImpl::~BattOrConnectionImpl() tools/battor_agent/battor_connection_impl.cc:89
    #8 0xa63abd in battor::TestableBattOrConnection::~TestableBattOrConnection() tools/battor_agent/battor_connection_impl_unittest.cc:31:7
    #9 0xa6054d in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
    #10 0xa6054d in reset buildtools/third_party/libc++/trunk/include/memory:2634
    #11 0xa6054d in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
    #12 0xa6054d in ~BattOrConnectionImplTest tools/battor_agent/battor_connection_impl_unittest.cc:49
    #13 0xa6054d in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::~BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test() tools/battor_agent/battor_connection_impl_unittest.cc:266
    #14 0xf5d11e in DeleteSelf_ third_party/googletest/src/googletest/include/gtest/gtest.h:479:24
    #15 0xf5d11e in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2475
    #16 0xf5d11e in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2672
    #17 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #18 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #19 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #20 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #21 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #22 0x119746b in Run base/callback.h:96:12
    #23 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #24 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #25 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #26 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xfc5e16 in base::internal::WeakReferenceOwner::GetRef() const base/memory/weak_ptr.cc:56:13
    #2 0xa8d59f in AsWeakPtr base/memory/weak_ptr.h:341:45
    #3 0xa8d59f in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:231
    #4 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #5 0xa45a73 in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #6 0xa45a73 in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:282
    #7 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #8 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #9 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #10 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #11 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #13 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #14 0x119746b in Run base/callback.h:96:12
    #15 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #16 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #17 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #18 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d5c4 in BindOnce<void (battor::BattOrConnectionImpl::*)(int, device::mojom::SerialReceiveError), base::WeakPtr<battor::BattOrConnectionImpl> > base/bind.h:213:23
    #2 0xa8d5c4 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:230
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa45a73 in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa45a73 in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:282
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d725 in make_unique<device::ReceiveBuffer, scoped_refptr<net::IOBuffer> &, unsigned int, base::OnceCallback<void (int, device::mojom::SerialReceiveError)> > buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0xa8d725 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:228
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa45a73 in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa45a73 in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:282
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x9c9d62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
    #1 0xa8d413 in MakeRefCounted<net::IOBuffer, unsigned long &> base/memory/scoped_refptr.h:91:12
    #2 0xa8d413 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:226
    #3 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #4 0xa45a73 in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #5 0xa45a73 in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:282
    #6 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #7 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #8 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #9 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #10 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #12 0x118ec57 in base::TestSuite::Run() base/test/test_suite.cc:275
    #13 0x119746b in Run base/callback.h:96:12
    #14 0x119746b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #15 0x1196efc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #16 0x1188878 in main base/test/run_all_unittests.cc:12:10
    #17 0x7f62c7598f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 13 byte(s) in 1 object(s) allocated from:
    #0 0x9c9ef2 in operator new[](unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:96:3
    #1 0x15ff775 in net::IOBuffer::IOBuffer(unsigned long) net/base/io_buffer.cc:40:11
    #2 0xa8d422 in MakeRefCounted<net::IOBuffer, unsigned long &> base/memory/scoped_refptr.h:91:16
    #3 0xa8d422 in battor::BattOrConnectionImpl::BeginReadBytesForMessage(unsigned long) tools/battor_agent/battor_connection_impl.cc:226
    #4 0xa8bd92 in battor::BattOrConnectionImpl::ReadMessage(battor::BattOrMessageType) tools/battor_agent/battor_connection_impl.cc:210:3
    #5 0xa45a73 in ReadMessage tools/battor_agent/battor_connection_impl_unittest.cc:99:18
    #6 0xa45a73 in battor::BattOrConnectionImplTest_FlushConnectionFlushesBytesReceivedInQuietPeriod_Test::TestBody() tools/battor_agent/battor_connection_impl_unittest.cc:282
    #7 0xf5b852 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #8 0xf5cfc4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #9 0xf5e3c6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #10 0xf840d6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #11 0xf83322 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #12 0x118ec57 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46

*snip*
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a

commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a
Author: Nico Weber <thakis@chromium.org>
Date: Sat May 19 02:58:46 2018

Reduce number of different test suite configurations.

- Remove all the "non_clang" and "_fyi" configs -- the clang
  waterfall and the FYI waterfall should default to running the
  same tests as the real waterfalls unless explicitly opted out.
  Deviations here were very likely not intentional.
  - This requires running chrome_cleaner_unittests on the regular
    win bots, which seems like a good change anyhow.
- Just include angle_unittests in chromium_gtests instead of
  spuriously adding it here and there (but on all platforms).
  We've had issues with this test unintentionally running on too
  few bots.
- Rename aura_gtests to non_android_and_mac_gtests
- Include gl_tests in the normal chromium_linux_gtests and
  chromium_android_gtests suites instead of having separate
  _and_gl configs
- Add gcm_unit_tests to chromium_gtests since it effectively
  ran everywhere already, this allows deleting
  non_android_and_cast_chromium_gtests. Use similar tactics to
  remove non_android_and_cast_and_chromeos_chromium_gtests.
- Address most "TODO: merge back to X" TODOs

The main effect is that this adds many tests to the chromium.clang
waterfall, making it more consistent with the main waterfall.
It also adds a couple of binaries to other waterfalls.

Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 
TBR=disabled test owners

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830
Reviewed-on: https://chromium-review.googlesource.com/1061795
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560147}
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.win.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/README.chromium
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/ui/compositor/layer_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b15b26491f649cffaccae05a4370f8367ddbcf

commit e3b15b26491f649cffaccae05a4370f8367ddbcf
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Sat May 19 20:57:11 2018

Revert "Reduce number of different test suite configurations."

This reverts commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a.

Reason for revert: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/11941

Original change's description:
> Reduce number of different test suite configurations.
> 
> - Remove all the "non_clang" and "_fyi" configs -- the clang
>   waterfall and the FYI waterfall should default to running the
>   same tests as the real waterfalls unless explicitly opted out.
>   Deviations here were very likely not intentional.
>   - This requires running chrome_cleaner_unittests on the regular
>     win bots, which seems like a good change anyhow.
> - Just include angle_unittests in chromium_gtests instead of
>   spuriously adding it here and there (but on all platforms).
>   We've had issues with this test unintentionally running on too
>   few bots.
> - Rename aura_gtests to non_android_and_mac_gtests
> - Include gl_tests in the normal chromium_linux_gtests and
>   chromium_android_gtests suites instead of having separate
>   _and_gl configs
> - Add gcm_unit_tests to chromium_gtests since it effectively
>   ran everywhere already, this allows deleting
>   non_android_and_cast_chromium_gtests. Use similar tactics to
>   remove non_android_and_cast_and_chromeos_chromium_gtests.
> - Address most "TODO: merge back to X" TODOs
> 
> The main effect is that this adds many tests to the chromium.clang
> waterfall, making it more consistent with the main waterfall.
> It also adds a couple of binaries to other waterfalls.
> 
> Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 
> TBR=disabled test owners
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830
> Reviewed-on: https://chromium-review.googlesource.com/1061795
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560147}

TBR=thakis@chromium.org,dpranke@chromium.org,kbr@chromium.org

Change-Id: I645e08d0ae374f181836e5d3749f39e17e54d9f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843511,  843726 ,  843729 ,  843731 ,  843732 ,  843734 , 831999,  844582 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1067052
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560158}
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/README.chromium
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/ui/compositor/layer_unittest.cc

Comment 3 by thakis@chromium.org, Jun 5 2018 

charliea: ping?

Comment 4 by thakis@chromium.org, Jun 5 2018

Blocking: 843511
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5577617d5df17b4c51d34ad7051c583d01514c63

commit 5577617d5df17b4c51d34ad7051c583d01514c63
Author: Nico Weber <thakis@chromium.org>
Date: Tue Jun 05 20:43:35 2018

Move battor_agent_unittests to non_android_and_cast_and_chromeos_chromium_gtests.

Also run non_android_and_cast_and_chromeos_chromium_gtests on the mac clang
bots, it was missing unintentinoally.

Effectively adds battor_agent_unittests to the memory waterfall and to the
clang tot bots, and adds snapshot_unittests to the mac clang tot bots.

This is part of an effort to reduce the number of test configurations.
Originally reviewed as part of https://chromium-review.googlesource.com/1061795,
which I'm now landing in smaller pieces.

TBR=kbr

Bug: 843511, 843729 
Change-Id: I83fe8723e3634c516a378fb76d8b02ac6a2fab4f
Reviewed-on: https://chromium-review.googlesource.com/1087574
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564653}
[modify] https://crrev.com/5577617d5df17b4c51d34ad7051c583d01514c63/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/5577617d5df17b4c51d34ad7051c583d01514c63/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/5577617d5df17b4c51d34ad7051c583d01514c63/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/5577617d5df17b4c51d34ad7051c583d01514c63/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/5577617d5df17b4c51d34ad7051c583d01514c63/tools/battor_agent/battor_connection_impl_unittest.cc

Comment 6 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 7 by charliea@chromium.org, Aug 6

Status: WontFix (was: Assigned)
Going to close this as WontFix, given that we're deleting this code now anyhow.

Comment 8 by thakis@chromium.org, Aug 6 

Is there a bug tracking said deletion?

Comment 9 by charliea@chromium.org, Aug 6

Blockedon: 859514
 bug 859514  tracks the deletion. I'm not quite sure if this should be duped into that bug or not, given that they're tracking somewhat different things.

I added that bug as a blocking bug for this one.
►

Sign in to add a comment