New issue
Advanced search Search tips

Issue 843728 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update ./swarming.py script to include CIPD packages and paths.

Project Member Reported by justincohen@chromium.org, May 16 2018

Issue description

See crbug.com/838659 for context.

Currently going to swarming tasks gives hints on running tasks locally, e.g. 
https://touch-swarming.appspot.com/task?id=3d73392de3976c10&refresh=10&show_raw=1
&&
python swarming.py reproduce -S touch-swarming.appspot.com 3d73392de3976c10

But `swarming reproduce` will fail because of the way Xcode and CIPD are integrated into the test runner.  

I'd also be fine with adding instructions for how to properly reproduce locally, e.g. adding a hint to put ``--  --mac-toolchain-cmd true --xcode-path /path/to/Xcode.app` after the reproduce command
 

Comment 1 by mar...@chromium.org, May 16 2018

Components: -Infra>Platform>Swarming Test>iOS
Where would this live? I think hints like this should be printed as part of the task output itself *or* as part of the failure path when it fails while reproducing, as Swarming has no clue about this.
I'm following sergeyberezin@'s advice here.  sergeyberezin@ what do you think?
IMHO this request should be rewording to include CIPD and PATH specs supplied as generic task parameters into `swarming.py reproduce`.

swarming.py already supports triggering tasks with these parameters, and they show up as explicit task properties on the swarming page. Yet `swarming.py reproduce` doesn't seem to include these parameters in the local run, hence failing the tasks sometimes in rather obscure ways. So I'd consider it a bug of `swarming.py reproduce` (or at least, a feature lag compared to the rest of swarming).

Of course, special arguments like --mac-toolchain-cmd and such are test-specific and should be left out of scope for this bug. [Perhaps, this was the confusing bit in the original description].

maruel@: WDYT, given this clarification?

Cc: justincohen@chromium.org
Owner: sergeybe...@chromium.org
Status: Assigned (was: Untriaged)
Components: -Test>iOS Infra>Platform>Swarming
Owner: ----
Status: Untriaged (was: Assigned)
D'oh! Back to swarming component, to avoid double-triage.

Comment 6 by mar...@chromium.org, May 21 2018

Labels: -Type-Task -OS-iOS Type-Bug
Status: Available (was: Untriaged)
So to clarify, this code doesn't work?
https://cs.chromium.org/chromium/infra/luci/client/swarming.py?l=1709

i.e. the cipd packages are not mapped in before reproduce.
I didn't realize we actually have this codepath, but yes, for some reason CIPD packages don't seem to get installed.

Comment 8 by mar...@chromium.org, May 24 2018

I see now, they are installed but not added to PATH.

Comment 9 by tapted@chromium.org, May 29 2018

Labels: Sheriff-Chromium
[URGENT] Has something landed for this? There seems to be some related breakage in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/33601


  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/pickle.py", line 977, in load_string
    self.append(rep.decode("string-escape"))
LookupError: unknown encoding: string-escape
step returned non-zero exit code: 1


Possibly the version of python on that bot is too old to run this CIPD stuff?
re #c9: Filed  Issue 847316 . tl;dr - possible flake? Although it also happened on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/13923
This error is generally because the host is hosed. This is unrelated to this issue. Rebooting resolves the problem.
Labels: -Sheriff-Chromium Infra
This is an Infra issue, not Tree Sheriff.

Sign in to add a comment