Using `document.scrollingElement` as the scroll source for a `ScrollTimeline` logs an error in the console and the effect doesn’t work. Error: The ScrollTimeline scrollSource is not composited. Demo: https://aw-bug-hunt.glitch.me/root-scroller.html Code: https://glitch.com/edit/#!/aw-bug-hunt?path=root-scroller.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5796e5b72e2fc944272f859ef58192c3f7c06362 commit 5796e5b72e2fc944272f859ef58192c3f7c06362 Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Jun 05 14:15:45 2018 Use the correct Node for ScrollTimeline for document.scrollingElement document.scrollingElement is a bit special; from the javascript side of the world it looks like either the <html> or <body> (in quirks mode), but internally the actual scroll information is kept on the root #document node. This CL fixes our logic to properly resolve the scrollSource in this case. Bug: 843727 Change-Id: I5c19ae0a757f24391097794906fd932e7a9a6529 Reviewed-on: https://chromium-review.googlesource.com/1083149 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564481} [add] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/WebKit/LayoutTests/fast/animation/scroll-animations/scrolltimeline-root-scroller-quirks-mode.html [add] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/WebKit/LayoutTests/fast/animation/scroll-animations/scrolltimeline-root-scroller.html [add] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-root-scroller-expected.html [add] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-root-scroller.html [modify] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/blink/renderer/core/animation/scroll_timeline.cc [modify] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/blink/renderer/core/animation/scroll_timeline.h [modify] https://crrev.com/5796e5b72e2fc944272f859ef58192c3f7c06362/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
Comment 1 by viswa.karala@chromium.org
, May 17 2018