New issue
Advanced search Search tips

Issue 843725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

performance_test_suite on Windows-10-15063 failing on chromium.win/Win10 Tests x64 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 16 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of lukasza@chromium.org

performance_test_suite on Windows-10-15063 failing on chromium.win/Win10 Tests x64 (dbg)

Builders failed on: 
- Win10 Tests x64 (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29


 
The failure started happening around the same time on:
- https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/596
- https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/2395

This (I think) narrows down the blamelist down to: https://chromium.googlesource.com/chromium/src/+log/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383..1842b8ccebf3d914b7aed7702b50223c072e5fcc

In both cases the stdout includes the following error:
    Traceback (most recent call last):
      File "C:\b\s\w\ir\testing\scripts\run_telemetry_benchmark_as_googletest.py", line 130, in run_benchmark
        with open(tempfile_name) as f:
    IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\its1g4r6\\tmprtdch6telemetry\\results-chart.json'
Cc: eyaich@chromium.org
This seem to be caused by r559076 by eyaich@.
r559076 won't revert cleanly...
Cc: -eyaich@chromium.org
Labels: -Pri-2 OS-Mac OS-Windows Pri-1 Type-Bug
Owner: eyaich@chromium.org
Status: Assigned (was: Available)
eyaich@ - could you PTAL?

Red waterfall bots I think justify pri1.
Manual revert is under review @ https://crrev.com/c/1062711

Comment 6 by eyaich@google.com, May 16 2018

A fix was landed about 2 hours ago in two different CLs: 

https://chromium-review.googlesource.com/c/chromium/src/+/1062286 

and

https://chromium-review.googlesource.com/c/catapult/+/1062215

Checking to see if they have rolled
Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c7817080b55cfcaea3531ed9a0d1a9f0d64a2e9

commit 9c7817080b55cfcaea3531ed9a0d1a9f0d64a2e9
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed May 16 23:20:20 2018

Revert "Add dummy benchmarks to chromium waterfalls"

This reverts commit 1f4fc1f7d335fa403e6192c759d50e9aa755c24b.

Reason for revert: Speculating that this is the root cause of  https://crbug.com/843725 

Original change's description:
> Add dummy benchmarks to chromium waterfalls
>
> Bug:  840427 
> Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2
> Reviewed-on: https://chromium-review.googlesource.com/1055776
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Emily Hanley <eyaich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559076}

TBR=nednguyen@google.com,eyaich@chromium.org,jbudorick@chromium.org

Bug:  843725 
Change-Id: I10fa2c1c631e3d43b31f610f4af40756840e9ba2
Reviewed-on: https://chromium-review.googlesource.com/1062711
Reviewed-by: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559327}
[modify] https://crrev.com/9c7817080b55cfcaea3531ed9a0d1a9f0d64a2e9/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/9c7817080b55cfcaea3531ed9a0d1a9f0d64a2e9/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9c7817080b55cfcaea3531ed9a0d1a9f0d64a2e9/testing/buildbot/test_suites.pyl
[delete] https://crrev.com/393cfcaff4c98af880deff6fbd69cd78b203f5dd/tools/perf/core/smoke_test_benchmark_shard_map.json

Comment 8 by finnur@chromium.org, May 17 2018

Labels: -Sheriff-Chromium
Looks like we have a revert. Can this be closed now?
Status: Fixed (was: Assigned)
Yeha - both Win10 and Mac are somewhat green (and don't include failures in the performance_test_suite step).

Sign in to add a comment