Migrate Services Data Use to Traffic Annotations |
|||||||||||||||
Issue descriptionDataUse.MessageSize.AllServices.* UMA records the chrome service ID against the data use. Instead of changing every source code location which creates URLFetcher to call AttachToFetcher, the codepath can be migrated to use traffic annotations. Following is the design doc: https://docs.google.com/document/d/11UkfCnNsGQpRpEK006H-LV4wCVIEgnllBKlR2Q3voHc/edit#
,
May 16 2018
,
May 16 2018
,
May 18 2018
,
May 18 2018
,
May 18 2018
,
May 18 2018
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0242d8885e006ee2daa4663802114af0002eab1 commit a0242d8885e006ee2daa4663802114af0002eab1 Author: rajendrant <rajendrant@chromium.org> Date: Sat Jun 30 03:31:08 2018 Migrate Services Data Use to Traffic Annotations Network traffic annotations provides an unique hash for each component that creates the URLRequest. This CL records data use against the hashes, so that no client change is needed when new services are added. New service names could be independently added in enums.xml. Different conditions upstream/downstream, app state in background/foreground are added as suffixes to the histogram. Notably, network connection type (cellular/non-cellular) is not added as suffix. This CL also deprecates the histograms DataUse.AllServices.BackgroundKB and DataUse.MessageSize.AllServices.* histograms. Bug: 843715 Change-Id: Iecffb840afa1880bd383972c30e82925b519c18b Reviewed-on: https://chromium-review.googlesource.com/1114061 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#571754} [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/content/content_url_request_classifier.cc [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/content/content_url_request_classifier.h [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/core/data_use_measurement.cc [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/core/data_use_measurement.h [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/core/data_use_measurement_unittest.cc [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/core/data_use_network_delegate_unittest.cc [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/components/data_use_measurement/core/url_request_classifier.h [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/net/traffic_annotation/network_traffic_annotation.h [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/tools/metrics/histograms/enums.xml [modify] https://crrev.com/a0242d8885e006ee2daa4663802114af0002eab1/tools/metrics/histograms/histograms.xml
,
Jul 1
,
Jul 4
Requesting a merge of change at #c8 to M68. This adds histograms that could give insight into chrome services data use. UMA Data from canary looks good as well. https://uma.googleplex.com/p/chrome/histograms?endDate=20180701&dayCount=1&histograms=DataUse.AllServicesKB.Downstream.Background&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
,
Jul 4
,
Jul 4
,
Jul 4
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
This does not impact any functionality in Chrome right?
,
Jul 9
cmasso@ Yes. No impact in functionality. Just records different set of metrics. Thanks
,
Jul 10
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d08ba1fbe445076b367ef0a63c9c58eab41e04d2 commit d08ba1fbe445076b367ef0a63c9c58eab41e04d2 Author: rajendrant <rajendrant@chromium.org> Date: Thu Jul 12 06:28:30 2018 Migrate Services Data Use to Traffic Annotations Network traffic annotations provides an unique hash for each component that creates the URLRequest. This CL records data use against the hashes, so that no client change is needed when new services are added. New service names could be independently added in enums.xml. Different conditions upstream/downstream, app state in background/foreground are added as suffixes to the histogram. Notably, network connection type (cellular/non-cellular) is not added as suffix. This CL also deprecates the histograms DataUse.AllServices.BackgroundKB and DataUse.MessageSize.AllServices.* histograms. TBR=rajendrant@chromium.org (cherry picked from commit a0242d8885e006ee2daa4663802114af0002eab1) Bug: 843715 Change-Id: Iecffb840afa1880bd383972c30e82925b519c18b Reviewed-on: https://chromium-review.googlesource.com/1114061 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#571754} Reviewed-on: https://chromium-review.googlesource.com/1134727 Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#653} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/content/content_url_request_classifier.cc [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/content/content_url_request_classifier.h [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/core/data_use_measurement.cc [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/core/data_use_measurement.h [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/core/data_use_measurement_unittest.cc [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/core/data_use_network_delegate_unittest.cc [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/components/data_use_measurement/core/url_request_classifier.h [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/net/traffic_annotation/network_traffic_annotation.h [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d08ba1fbe445076b367ef0a63c9c58eab41e04d2/tools/metrics/histograms/histograms.xml
,
Jul 12
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by rajendrant@chromium.org
, May 16 2018