New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843714 link

Starred by 6 users
Status: Fixed
Owner:
jchin...@chromium.org
Closed: Nov 14
Cc:
jchin...@chromium.org
tandrii@chromium.org
█ jinjingl@chromium.org
no...@chromium.org
mikenichols@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 853450
Blocking:
issue 832733
issue 850113



Sign in to add a comment

Real-time info in buildbucket v2 API

Project Member Reported by no...@chromium.org, May 16 2018 
Feature request: buildbucket v2 APIs for build retrieval (GetBuild, SearchBuilds) must provide steps and output properties in the real time, as build runs, as opposed to only after build is complete.

Comment 1 by no...@chromium.org, May 16 2018

Labels: buildbucket-v2

Comment 2 by no...@chromium.org, May 20 2018

Cc: no...@chromium.org tandrii@chromium.org
 Issue 794270  has been merged into this issue.

Comment 3 by no...@chromium.org, May 25 2018

Description: Show this description

Comment 4 by no...@chromium.org, May 25 2018

Summary: Real-time info in buildbucket v2 API (was: Real-time steps in buildbucket v2 API)

Comment 5 by no...@chromium.org, Jun 16 2018

Blockedon: 853450

Comment 6 by no...@chromium.org, Sep 12

Owner: jchin...@chromium.org
Status: Started (was: Assigned)

Comment 7 by mikenichols@chromium.org, Sep 12

Cc: mikenichols@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6ed219fb4ac4790e51032b25fa3be51aa8859f61

commit 6ed219fb4ac4790e51032b25fa3be51aa8859f61
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Mon Sep 24 19:06:11 2018

[buildbucket] Add time- and status-based step validation.

Also, add parameterized to the available Python libraries.

BUG= 843714 

Change-Id: Ib09c1fd2cedec429d727c44a83dc8978ad87f378
Reviewed-on: https://chromium-review.googlesource.com/1235134
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17830}
[add] https://crrev.com/6ed219fb4ac4790e51032b25fa3be51aa8859f61/appengine/cr-buildbucket/v2/test/steps.pb.txt
[modify] https://crrev.com/6ed219fb4ac4790e51032b25fa3be51aa8859f61/appengine/cr-buildbucket/v2/validation.py
[modify] https://crrev.com/6ed219fb4ac4790e51032b25fa3be51aa8859f61/appengine/cr-buildbucket/v2/test/validation_test.py
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2d828f4be79ea38b43667b61e0bbaa7670a0bf0b

commit 2d828f4be79ea38b43667b61e0bbaa7670a0bf0b
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Sep 26 19:36:55 2018

[cr-buildbucket] Store updated build messages.

BUG= 843714 

Change-Id: I33bd491d87c6cf319ee786ab0e759eefede9083a
Reviewed-on: https://chromium-review.googlesource.com/1205556
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17895}
[modify] https://crrev.com/2d828f4be79ea38b43667b61e0bbaa7670a0bf0b/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/2d828f4be79ea38b43667b61e0bbaa7670a0bf0b/appengine/cr-buildbucket/user.py
[modify] https://crrev.com/2d828f4be79ea38b43667b61e0bbaa7670a0bf0b/appengine/cr-buildbucket/v2/test/api_test.py
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b1d996a3b71b27de2e194e724ba633a727776156

commit b1d996a3b71b27de2e194e724ba633a727776156
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Sep 26 21:27:31 2018

[cr-buildbucket] Add steps size check to UpdateBuild validation.

Bug:  843714 
Change-Id: Icaafad7561b0b9ab053450aef103366518d927e4
Reviewed-on: https://chromium-review.googlesource.com/1245733
Auto-Submit: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17897}
[modify] https://crrev.com/b1d996a3b71b27de2e194e724ba633a727776156/appengine/cr-buildbucket/v2/test/validation_test.py
[modify] https://crrev.com/b1d996a3b71b27de2e194e724ba633a727776156/appengine/cr-buildbucket/v2/validation.py

Comment 12 by no...@chromium.org, Sep 26

Blocking: 850113
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0eabf187b8c4c50e484cae41794cca83eb8be626

commit 0eabf187b8c4c50e484cae41794cca83eb8be626
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Oct 02 22:30:36 2018

[cr-buildbucket] Tag swarming tasks with build key.

BUG= 843714 

Change-Id: I3efaad2238ff21145005d4027ab533890cee34e6
Reviewed-on: https://chromium-review.googlesource.com/c/1256065
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18011}
[modify] https://crrev.com/0eabf187b8c4c50e484cae41794cca83eb8be626/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/0eabf187b8c4c50e484cae41794cca83eb8be626/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/0eabf187b8c4c50e484cae41794cca83eb8be626/appengine/cr-buildbucket/swarming/test/swarming_test.py
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/88ac7133b9b13bd7793db1226bc47ba7a409ab6b

commit 88ac7133b9b13bd7793db1226bc47ba7a409ab6b
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Oct 02 23:16:30 2018

Revert "[cr-buildbucket] Tag swarming tasks with build key."

This reverts commit 0eabf187b8c4c50e484cae41794cca83eb8be626.

Reason for revert: started seeing creation errors on dev

Original change's description:
> [cr-buildbucket] Tag swarming tasks with build key.
> 
> BUG= 843714 
> 
> Change-Id: I3efaad2238ff21145005d4027ab533890cee34e6
> Reviewed-on: https://chromium-review.googlesource.com/c/1256065
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18011}

TBR=nodir@chromium.org,jchinlee@chromium.org

Change-Id: Ib6dc7282d5e1d219b37d10dd78b3d51bbe21e574
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  843714 
Reviewed-on: https://chromium-review.googlesource.com/c/1258462
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18015}
[modify] https://crrev.com/88ac7133b9b13bd7793db1226bc47ba7a409ab6b/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/88ac7133b9b13bd7793db1226bc47ba7a409ab6b/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/88ac7133b9b13bd7793db1226bc47ba7a409ab6b/appengine/cr-buildbucket/swarming/test/swarming_test.py
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7f3e4528df324e3d7404d4a48f2aeac184c9166b

commit 7f3e4528df324e3d7404d4a48f2aeac184c9166b
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Oct 03 17:33:20 2018

Reland "[cr-buildbucket] Tag swarming tasks with build key."

This is a reland of 0eabf187b8c4c50e484cae41794cca83eb8be626

Original change's description:
> [cr-buildbucket] Tag swarming tasks with build key.
> 
> BUG= 843714 
> 
> Change-Id: I3efaad2238ff21145005d4027ab533890cee34e6
> Reviewed-on: https://chromium-review.googlesource.com/c/1256065
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18011}

Bug:  843714 
Change-Id: I21017e5b4a5c40b800110237ea546651f9fefb46
Reviewed-on: https://chromium-review.googlesource.com/c/1258463
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18025}
[modify] https://crrev.com/7f3e4528df324e3d7404d4a48f2aeac184c9166b/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/7f3e4528df324e3d7404d4a48f2aeac184c9166b/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/7f3e4528df324e3d7404d4a48f2aeac184c9166b/appengine/cr-buildbucket/swarming/test/swarming_test.py
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a9d49d7d5203107b93a9cba623554c8cb43ba082

commit a9d49d7d5203107b93a9cba623554c8cb43ba082
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 06 17:14:34 2018

[kitchen] Add flags for UpdateBuild calls

Add kitchen cook flags to enable buildbucket.v2.Builds.UpdateBuild RPCs:
-buildbucket-hostname
-call-update-build

Add validation.

The new flags are not used yet.

Bug:  843714 
Change-Id: Ifa14be4ce1f641b0f0842fc1e1c2971377d496c7
Reviewed-on: https://chromium-review.googlesource.com/c/1318719
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18810}
[modify] https://crrev.com/a9d49d7d5203107b93a9cba623554c8cb43ba082/go/src/infra/tools/kitchen/cookflags/flags.go
[modify] https://crrev.com/a9d49d7d5203107b93a9cba623554c8cb43ba082/go/src/infra/tools/kitchen/cookflags/flags_test.go
[modify] https://crrev.com/a9d49d7d5203107b93a9cba623554c8cb43ba082/go/src/infra/tools/kitchen/cookflags/validate.go
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/e75bbfdf1a5ced21258ab86b5cd1ed662095fc70

commit e75bbfdf1a5ced21258ab86b5cd1ed662095fc70
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Nov 07 19:09:27 2018

[annotation] Add ExtractProperties

Add a function that extracts properties from annotation step to a
google.protobuf.Struct.
It will be used by kitchen to stream updated output properties.

Bug:  843714 
Change-Id: I7c9cbeb13f949a77d6072c26bedf3bb93c78bc30
Reviewed-on: https://chromium-review.googlesource.com/c/1320929
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/e75bbfdf1a5ced21258ab86b5cd1ed662095fc70/common/proto/milo/util.go
[add] https://crrev.com/e75bbfdf1a5ced21258ab86b5cd1ed662095fc70/common/proto/milo/util_test.go
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b9e9585fe0c53af9876575f4a803b814fb0eae90

commit b9e9585fe0c53af9876575f4a803b814fb0eae90
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Nov 08 23:23:02 2018

[buildbucket] Refactor UpdateBuildTests

Remove test code that does not increase coverage of the target code.
Mock functions that the target code calls directly, as opposed to indirectly.
Assert that BuildSteps was actually persisted.
Move common mocking code into setUp.

Bug:  843714 
Change-Id: I5cb69d1469775e079de7f7a2905e47a21e36c47f
Reviewed-on: https://chromium-review.googlesource.com/c/1321630
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18882}
[modify] https://crrev.com/b9e9585fe0c53af9876575f4a803b814fb0eae90/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/b9e9585fe0c53af9876575f4a803b814fb0eae90/appengine/cr-buildbucket/v2/test/api_test.py
[modify] https://crrev.com/b9e9585fe0c53af9876575f4a803b814fb0eae90/appengine/cr-buildbucket/v2/tokens.py
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5c257c7aa8a98bd4ea0405d4976492c317a57fcb

commit 5c257c7aa8a98bd4ea0405d4976492c317a57fcb
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 00:12:59 2018

[kitchen] Add runBuildUpdater

runBuildUpdater accepts a channel of buildbucketpb.UpdateBuildRequest
and propagates them to buildbucket.
Makes only one request at time. Logs errors of intermediate requests
and fails on the error in the last request, if any.

Bug:  843714 
Change-Id: Ie802997d4084c07d0cb311f022c33c367f9e0cda
Reviewed-on: https://chromium-review.googlesource.com/c/1319194
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18886}
[add] https://crrev.com/5c257c7aa8a98bd4ea0405d4976492c317a57fcb/go/src/infra/tools/kitchen/update_build_test.go
[add] https://crrev.com/5c257c7aa8a98bd4ea0405d4976492c317a57fcb/go/src/infra/tools/kitchen/update_build.go
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3ec2ed16a383eb832c0003f8cf8589a83e964fcf

commit 3ec2ed16a383eb832c0003f8cf8589a83e964fcf
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 00:25:01 2018

[buildbucket] Allow updating properties

Extend UpdateBuildRequest.update_mask to support updating
build.output.properties.

Bug:  843714 
Change-Id: I94c4d478ea3cc9d5942a0c8d6251145188651300
Reviewed-on: https://chromium-review.googlesource.com/c/1321414
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/3ec2ed16a383eb832c0003f8cf8589a83e964fcf/buildbucket/proto/pb.discovery.go
[modify] https://crrev.com/3ec2ed16a383eb832c0003f8cf8589a83e964fcf/buildbucket/proto/rpc.pb.go
[modify] https://crrev.com/3ec2ed16a383eb832c0003f8cf8589a83e964fcf/buildbucket/proto/rpc.proto
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3bc054e458b8ab24f2040ececac06a7f807272c2

commit 3bc054e458b8ab24f2040ececac06a7f807272c2
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 00:30:28 2018

[kitchen] Add parseUpdateBuildRequest

parseUpdateBuildRequest takes an annotation proto and turns it into an
UpdateBuild RPC request.

It will be used to stream steps and properties to buildbucket as build runs.

R=iannucci@chromium.org, jchinlee@chromium.org

Bug:  843714 
Change-Id: Id89287f372d3a4829aad6b2bdddad6c53c99473e
Reviewed-on: https://chromium-review.googlesource.com/c/1323752
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18887}
[modify] https://crrev.com/3bc054e458b8ab24f2040ececac06a7f807272c2/go/src/infra/tools/kitchen/update_build_test.go
[modify] https://crrev.com/3bc054e458b8ab24f2040ececac06a7f807272c2/go/src/infra/tools/kitchen/update_build.go
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e643976ff8cc00fc57e72a69ef373d5b490ee4a7

commit e643976ff8cc00fc57e72a69ef373d5b490ee4a7
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 00:59:01 2018
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/041d3dc49d9ce57d304b6710485008335062951a

commit 041d3dc49d9ce57d304b6710485008335062951a
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 16:55:58 2018

[annotee] Implement callback

Implement a callback that is called in the same code path which sends the
serialized annotation proto to butler as a datagram.

Keep it seralized in the callback in case the callback does not need to
deserialize it either.

Bug:  843714 
Change-Id: Ib62e43b3e81763c4c36d8834e101668bae5b66e8
Reviewed-on: https://chromium-review.googlesource.com/c/1328743
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/041d3dc49d9ce57d304b6710485008335062951a/logdog/client/annotee/processor.go
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/42115ed61beee8013a42e7b16ae7d1d4fe0a019b

commit 42115ed61beee8013a42e7b16ae7d1d4fe0a019b
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 18:28:11 2018

[buildbucket] Make build_token a string

A token generated by components.auth lib is a string, not bytes.
Use corresponding type in the proto to avoid encoding issues.

Bug:  843714 
Change-Id: I9042f91e46e78007f8f933517fbb7929923d4061
Reviewed-on: https://chromium-review.googlesource.com/c/1329523
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/42115ed61beee8013a42e7b16ae7d1d4fe0a019b/buildbucket/proto/launcher.pb.go
[modify] https://crrev.com/42115ed61beee8013a42e7b16ae7d1d4fe0a019b/buildbucket/proto/launcher.proto
[modify] https://crrev.com/42115ed61beee8013a42e7b16ae7d1d4fe0a019b/buildbucket/proto/pb.discovery.go
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/18610ef7ac103fb0df56cc809a6cecd765265382

commit 18610ef7ac103fb0df56cc809a6cecd765265382
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 18:30:21 2018

[buildbucket] add BuildTokenHeader const

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: I30307054869b7632f7fcca968f637068f39e8a1c
Reviewed-on: https://chromium-review.googlesource.com/c/1329363
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/18610ef7ac103fb0df56cc809a6cecd765265382/buildbucket/proto.go
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f3dfe934592235ddc03b90e209c1498fb27d36d7

commit f3dfe934592235ddc03b90e209c1498fb27d36d7
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 18:42:07 2018

[lucictx] Fix clearing lucictx

Fix SetSwarming and SetLocalAuth to support clearing a section.
Useful to test code with no swarming secret bytes.

Bug:  843714 
Change-Id: I0dcc122a33c2b631b51aea11bab44112751ff700
Reviewed-on: https://chromium-review.googlesource.com/c/1329521
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/f3dfe934592235ddc03b90e209c1498fb27d36d7/lucictx/local_auth.go
[modify] https://crrev.com/f3dfe934592235ddc03b90e209c1498fb27d36d7/lucictx/local_auth_test.go
[modify] https://crrev.com/f3dfe934592235ddc03b90e209c1498fb27d36d7/lucictx/swarming.go
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3c009d84b546204b0a3e74f60d5e29093d211709

commit 3c009d84b546204b0a3e74f60d5e29093d211709
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 20:14:54 2018

[buildbucket] Accept parsed stream address

Change buildbucket.ConvertBuildSteps to accept a typed *types.StreamAddr
instead of an unparsed string URL.
Clients in practice already have a parsed stream address.

Bug:  843714 
Change-Id: I415e0c69ff06e47fe965fb9a311d4eb8d55329ac
Reviewed-on: https://chromium-review.googlesource.com/c/1328742
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/3c009d84b546204b0a3e74f60d5e29093d211709/buildbucket/annotations.go
[modify] https://crrev.com/3c009d84b546204b0a3e74f60d5e29093d211709/buildbucket/annotations_test.go
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/27d1350ed573ba30371090df86395c586f255803

commit 27d1350ed573ba30371090df86395c586f255803
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 20:36:37 2018

[prpc] Add support for outgoing metadata

Include outgoing metadata of the current context into request HTTP headers.
From doc.go:

- Any other headers MUST be added to metadata.MD in the context that is
  passed to the service method implementation.
  - If a header name has "-Bin" suffix, the server must treat it as
    base64-encoded and trim the suffix.

R=vadimsh@chromium.org

Bug:  843714 
Change-Id: Ib55b736accb199a9b54ffacafea0aa00c9985140
Reviewed-on: https://chromium-review.googlesource.com/c/1329989
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/27d1350ed573ba30371090df86395c586f255803/grpc/prpc/client.go
[modify] https://crrev.com/27d1350ed573ba30371090df86395c586f255803/grpc/prpc/client_test.go
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a996d59964e07bb869dee4b549df8cf794c2ab77

commit a996d59964e07bb869dee4b549df8cf794c2ab77
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 21:11:02 2018

[kitchen] Read build secrets

Read buildbucket.v2.BuildSecrets message from swarming secret bytes.

Bug:  843714 
Change-Id: I210bf65adff6e99bf693c632c932230daf34fb8f
Reviewed-on: https://chromium-review.googlesource.com/c/1328710
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18902}
[modify] https://crrev.com/a996d59964e07bb869dee4b549df8cf794c2ab77/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/a996d59964e07bb869dee4b549df8cf794c2ab77/go/src/infra/tools/kitchen/update_build_test.go
[modify] https://crrev.com/a996d59964e07bb869dee4b549df8cf794c2ab77/go/src/infra/tools/kitchen/update_build.go
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cfa2dc7ca361f05a5186afe8c963410b91e6c53f

commit cfa2dc7ca361f05a5186afe8c963410b91e6c53f
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Nov 09 22:59:38 2018

[buildbucket] omit secret bytes in get_task_def

get_task_def should not return BuildSecrets, since we do not actually
create a task.

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: Idc0fd41659a8c26bc9a25023cbb257825749bc53
Reviewed-on: https://chromium-review.googlesource.com/c/1330092
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18910}
[modify] https://crrev.com/cfa2dc7ca361f05a5186afe8c963410b91e6c53f/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/cfa2dc7ca361f05a5186afe8c963410b91e6c53f/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
Project Member

Comment 33 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5d440ee9180aac01a39191af88e8e2f04efa74f7

commit 5d440ee9180aac01a39191af88e8e2f04efa74f7
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Fri Nov 09 23:33:31 2018

[logdog] Provide callback to Logdog stream.

The callback is intended to be called on completion of a LogEntry.

BUG= 843714 

Change-Id: I8662d2a54fa4f6a6b18836fb0415c92fdfaddf84
Reviewed-on: https://chromium-review.googlesource.com/c/1318198
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/5d440ee9180aac01a39191af88e8e2f04efa74f7/logdog/client/butler/bundler/bundler.go
[modify] https://crrev.com/5d440ee9180aac01a39191af88e8e2f04efa74f7/logdog/client/butler/bundler/stream.go
[modify] https://crrev.com/5d440ee9180aac01a39191af88e8e2f04efa74f7/logdog/client/butler/butler.go
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8cf1491e7717d3023be773506e8b43abba2fa67f

commit 8cf1491e7717d3023be773506e8b43abba2fa67f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 10 01:26:18 2018

[led] Force CallUpdateBuild=false.

R=nodir@chromium.org

Bug:  843714 
Change-Id: I97a91a7de5efffab8f004726fd3dcc6e47333d29
Reviewed-on: https://chromium-review.googlesource.com/c/1329959
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18917}
[modify] https://crrev.com/8cf1491e7717d3023be773506e8b43abba2fa67f/go/src/infra/tools/led/job.go
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52

commit b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Nov 10 08:51:22 2018

[kitchen] Stream steps and properties

Add AnnotationUpdated callback that converts the updated annotation proto
into an UpdateBuild RPC and streams updated steps and output properties
to buildbucket.

Add -buildbucket-build-id, since UpdateBuild RPC requires it.

Change runBuildUpdater to exit when context is canceled, not when
requests channel is closed. We must exit when cancel is cancelled
(since we cannot make RPCs with a cancelled context), and it is an
unnecessary complexity to have two exit points.

Bug:  843714 
Change-Id: I0640ab91e5244af181da1b60eb078a90a11ccdf9
Reviewed-on: https://chromium-review.googlesource.com/c/1329952
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18925}
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/update_build.go
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/cookflags/flags.go
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/cookflags/flags_test.go
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/cook_logdog.go
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/cookflags/validate.go
[modify] https://crrev.com/b7d5e97e8f5b8edaaf04b0b3943bf7306b788d52/go/src/infra/tools/kitchen/update_build_test.go
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 10 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ced18cb6d408e53d8d91e19f12e6281f8b1c2f65

commit ced18cb6d408e53d8d91e19f12e6281f8b1c2f65
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Nov 10 09:46:36 2018
Project Member

Comment 37 by bugdroid1@chromium.org, Nov 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/84ea61f5ae35ab1d514c8a1b421559cd600e4b03

commit 84ea61f5ae35ab1d514c8a1b421559cd600e4b03
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Nov 10 17:02:36 2018

[kitchen] Fix update_mask

update mask field paths must start with "build."
because the field containing new values is "build".

TBR=jchinlee@chromium.org

Bug:  843714 
Change-Id: I490d1e6c3a50fa69effd54dd348d072bd76de386
Reviewed-on: https://chromium-review.googlesource.com/c/1330874
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18928}
[modify] https://crrev.com/84ea61f5ae35ab1d514c8a1b421559cd600e4b03/go/src/infra/tools/kitchen/update_build.go
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/cc9a0787e7350e7329effc7c4dd94187cd8ffeeb

commit cc9a0787e7350e7329effc7c4dd94187cd8ffeeb
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Nov 12 23:50:06 2018

[buildbucket] Handle SCHEDULED step

Unlike annotation proto, build proto distinguishes non-started and started
builds. Fix the parser to take into account this difference.

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: Ib62bcc967adbc4dbaca066937803a6ae1f012e37
Reviewed-on: https://chromium-review.googlesource.com/c/1332707
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/cc9a0787e7350e7329effc7c4dd94187cd8ffeeb/buildbucket/annotations.go
[modify] https://crrev.com/cc9a0787e7350e7329effc7c4dd94187cd8ffeeb/buildbucket/testdata/annotations/expected_steps.pb.txt
Project Member

Comment 39 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b47dd589aae9f538adeaecc096a8dd1948d08012

commit b47dd589aae9f538adeaecc096a8dd1948d08012
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Nov 12 23:54:27 2018

[buildbucket] Explicitly convert buildnumber

Explicitly convert buildnumber property to int, in case it is encoded as a
float.

Also move datastore->proto conversion out of a transaction.

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: I7ad95f28ea807a0130bb3baa3669e6d68e357fff
Reviewed-on: https://chromium-review.googlesource.com/c/1332787
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18937}
[modify] https://crrev.com/b47dd589aae9f538adeaecc096a8dd1948d08012/appengine/cr-buildbucket/v2/builds.py
[modify] https://crrev.com/b47dd589aae9f538adeaecc096a8dd1948d08012/appengine/cr-buildbucket/v2/api.py
Project Member

Comment 40 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/fe0fa9573cfd109a8acd808bd17ad88c768df4a3

commit fe0fa9573cfd109a8acd808bd17ad88c768df4a3
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 01:46:45 2018
Project Member

Comment 41 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/863f96278445888ea4fb251e29281148ea0dc7ec

commit 863f96278445888ea4fb251e29281148ea0dc7ec
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 01:57:30 2018

[buildbucket] Log user email

When a user is not permitted to call UpdateBuild, log its identity.

Also update update-build group name to match RPC name (singular).

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: I6e64f305d80a3ccbe2db3d23d1bfb075517abc0c
Reviewed-on: https://chromium-review.googlesource.com/c/1332788
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18943}
[modify] https://crrev.com/863f96278445888ea4fb251e29281148ea0dc7ec/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/863f96278445888ea4fb251e29281148ea0dc7ec/appengine/cr-buildbucket/user.py
[modify] https://crrev.com/863f96278445888ea4fb251e29281148ea0dc7ec/appengine/cr-buildbucket/v2/test/api_test.py
Project Member

Comment 42 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1cd96bcc9962c28dfc7188c43f4d546dfc24dd73

commit 1cd96bcc9962c28dfc7188c43f4d546dfc24dd73
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 06:58:20 2018

[buildbucket] UpdateBuild: load build directly

Do not use services.get_async which does an access check (inside a txn).
Load a build directly.
This simplifies tests too

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: Ieb15efc2910d48c0941762381dd37e2c57f1584e
Reviewed-on: https://chromium-review.googlesource.com/c/1332800
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18952}
[modify] https://crrev.com/1cd96bcc9962c28dfc7188c43f4d546dfc24dd73/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/1cd96bcc9962c28dfc7188c43f4d546dfc24dd73/appengine/cr-buildbucket/v2/test/api_test.py
Project Member

Comment 43 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/4aa990d9d65a6e0941ffc2f29539449464c2eb59

commit 4aa990d9d65a6e0941ffc2f29539449464c2eb59
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 06:59:39 2018

[buildbucket] Handle SCHEDULED after children

StartTime of a step may be based on children.
Interpret it after interpreting children.

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: Ieb0d2ea229b9ac784d90e4725ca2dddaeccba1ba
Reviewed-on: https://chromium-review.googlesource.com/c/1332724
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/4aa990d9d65a6e0941ffc2f29539449464c2eb59/buildbucket/annotations.go
[modify] https://crrev.com/4aa990d9d65a6e0941ffc2f29539449464c2eb59/buildbucket/testdata/annotations/annotations.pb.txt
[modify] https://crrev.com/4aa990d9d65a6e0941ffc2f29539449464c2eb59/buildbucket/testdata/annotations/expected_steps.pb.txt
Project Member

Comment 44 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dfc747e548f582a3d8d7ecf5693ec4de604bc091

commit dfc747e548f582a3d8d7ecf5693ec4de604bc091
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 07:15:06 2018

Roll infra/go/src/go.chromium.org/luci/ cc9a0787e..4aa990d9d (1 commit)

https://chromium.googlesource.com/infra/luci/luci-go/+log/cc9a0787e735..4aa990d9d65a

$ git log cc9a0787e..4aa990d9d --date=short --no-merges --format='%ad %ae %s'
2018-11-13 nodir [buildbucket] Handle SCHEDULED after children

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

TBR=jchinlee@chromium.org

Bug:  843714 
Change-Id: I0ae629337d7f0d1bc0d403e6c98c7c6be77a6580
Reviewed-on: https://chromium-review.googlesource.com/c/1332803
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18953}
[modify] https://crrev.com/dfc747e548f582a3d8d7ecf5693ec4de604bc091/DEPS
Project Member

Comment 45 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/d6fa4f401565d543a4292a1802d4cea480035a96

commit d6fa4f401565d543a4292a1802d4cea480035a96
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 18:58:12 2018
Project Member

Comment 46 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f15bc0383fe199e386c0de2be66608742e379a90

commit f15bc0383fe199e386c0de2be66608742e379a90
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 19:42:31 2018

[buildbucket] UpdateBuild: log build id

Bug:  843714 
Change-Id: I868cee09af4672bcb24b438e4a554a933a68a755
Reviewed-on: https://chromium-review.googlesource.com/c/1333690
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18967}
[modify] https://crrev.com/f15bc0383fe199e386c0de2be66608742e379a90/appengine/cr-buildbucket/v2/api.py
Project Member

Comment 47 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/84086310b338a384829965588a71525c77af531b

commit 84086310b338a384829965588a71525c77af531b
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 19:59:05 2018

[buildbucket] Handle duplicate log names

Protect generated Build message from duplicate log names in a step.
Log a warning about it.

R=jchinlee@chromium.org

Bug:  843714 
Change-Id: If29349a0a5603856d9333f697540251461497373
Reviewed-on: https://chromium-review.googlesource.com/c/1334207
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/84086310b338a384829965588a71525c77af531b/buildbucket/annotations.go
[modify] https://crrev.com/84086310b338a384829965588a71525c77af531b/buildbucket/testdata/annotations/annotations.pb.txt
[modify] https://crrev.com/84086310b338a384829965588a71525c77af531b/buildbucket/testdata/annotations/expected_steps.pb.txt
Project Member

Comment 48 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3120959d560593edd77c78f23eb17fd9db63442c

commit 3120959d560593edd77c78f23eb17fd9db63442c
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 20:16:36 2018

[buildbucket] Handle absence of step end time

If a step does not have end time, it cannot have a terminal status.

R=jchinlee@chromium.org, vadimsh@chromium.org

Bug:  843714 
Change-Id: Id306bd9f6d066ba29b390548feebf449be38aa29
Reviewed-on: https://chromium-review.googlesource.com/c/1334208
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/3120959d560593edd77c78f23eb17fd9db63442c/buildbucket/annotations.go
Project Member

Comment 49 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9eb46fd9ef4a9b066bb0406a67e458deddc001a1

commit 9eb46fd9ef4a9b066bb0406a67e458deddc001a1
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 20:27:36 2018

Roll infra/go/src/go.chromium.org/luci/ 4aa990d9d..f0219311b (3 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/4aa990d9d65a..f0219311b6ae

$ git log 4aa990d9d..f0219311b --date=short --no-merges --format='%ad %ae %s'
2018-11-13 vadimsh [cipd] Calculate instance ID while building the package.
2018-11-13 nodir [buildbucket] Handle absence of step end time
2018-11-13 nodir [buildbucket] Handle duplicate log names

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

TBR=vadimsh@chromium.org

Bug:  843714 
Change-Id: I6a29b7669297b8a1069cddd815b694378ffc5b7c
Reviewed-on: https://chromium-review.googlesource.com/c/1333691
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18968}
[modify] https://crrev.com/9eb46fd9ef4a9b066bb0406a67e458deddc001a1/DEPS
Project Member

Comment 50 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/392c1547cd3d35e7fd3a5e1012873ccdb987dbae

commit 392c1547cd3d35e7fd3a5e1012873ccdb987dbae
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 21:42:52 2018
Project Member

Comment 51 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/8321bf31570366eeb876155d4b3a953edc1b25ff

commit 8321bf31570366eeb876155d4b3a953edc1b25ff
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Nov 14 17:56:28 2018

[buildbucket] Refactor step status function

The current impl still produces steps with a terminal state and no end time.
Refactor the code so that it is impossible.

Also do not set end time of a parent if it didn't have end time before,
i.e. it didn't finish yet.

Bug:  843714 
Change-Id: Ie33e31744a16db8ca3679011e5591d332a6d9763
Reviewed-on: https://chromium-review.googlesource.com/c/1334439
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/8321bf31570366eeb876155d4b3a953edc1b25ff/buildbucket/annotations.go
[modify] https://crrev.com/8321bf31570366eeb876155d4b3a953edc1b25ff/buildbucket/testdata/annotations/annotations.pb.txt
[modify] https://crrev.com/8321bf31570366eeb876155d4b3a953edc1b25ff/buildbucket/testdata/annotations/expected_steps.pb.txt
Project Member

Comment 52 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/daa29c6a7ee21779583cd7e1b1641592cf184e7d

commit daa29c6a7ee21779583cd7e1b1641592cf184e7d
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Nov 14 18:09:05 2018

Roll infra/go/src/go.chromium.org/luci/ f0219311b..8321bf315 (2 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/f0219311b6ae..8321bf315703

$ git log f0219311b..8321bf315 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 nodir [buildbucket] Refactor step status function
2018-11-14 pprabhu gitiles: Fix license file

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

TBR=vadimsh@chromium.org

Bug:  843714 
Change-Id: Ibe2eaa4a07a2e4ba9c717d391693a0e819bd2159
Reviewed-on: https://chromium-review.googlesource.com/c/1335802
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18988}
[modify] https://crrev.com/daa29c6a7ee21779583cd7e1b1641592cf184e7d/DEPS
Project Member

Comment 53 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/387fcf514717167319ade915ec65f140a6544b80

commit 387fcf514717167319ade915ec65f140a6544b80
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Nov 14 18:32:35 2018
Project Member

Comment 54 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/1fc149ed7cdb2549b1387665915ec044aea4e328

commit 1fc149ed7cdb2549b1387665915ec044aea4e328
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Nov 14 19:05:47 2018

Comment 55 by nodir@google.com, Nov 14

Status: Fixed (was: Started)
Project Member

Comment 56 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/61b411d529685555bab8af33b88a0ec6feabc310

commit 61b411d529685555bab8af33b88a0ec6feabc310
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Nov 20 20:19:38 2018

[logdog] Hook in callback functionality in Bundler streams.

BUG= 843714 

Change-Id: I9d1dbc303bd4607fe9560a777819e3b9b65caab2
Reviewed-on: https://chromium-review.googlesource.com/c/1344529
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/61b411d529685555bab8af33b88a0ec6feabc310/logdog/client/butler/bundler/bundler.go
[modify] https://crrev.com/61b411d529685555bab8af33b88a0ec6feabc310/logdog/client/butler/bundler/stream.go
[modify] https://crrev.com/61b411d529685555bab8af33b88a0ec6feabc310/logdog/client/butler/bundler/stream_test.go
Project Member

Comment 57 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc

commit ddda91f6d8ceaa68c9b3e8790d2503ff199520bc
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Nov 27 01:13:13 2018

[logdog] Add functionality to Butler to reassemble partial LogEntries.

BUG= 843714 

Change-Id: Ifb5bcc6183d444f500f794b70013087d9e27dcab
Reviewed-on: https://chromium-review.googlesource.com/c/1344530
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/api/logpb/log.proto
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/common.go
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/datagram.go
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/datagram_test.go
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/doc.go
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/text.go
[add] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/buffered_callback/text_test.go
[modify] https://crrev.com/ddda91f6d8ceaa68c9b3e8790d2503ff199520bc/logdog/client/butler/bundler/stream.go
Project Member

Comment 58 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/479e91972550399acb820c0f07fea12b16b51939

commit 479e91972550399acb820c0f07fea12b16b51939
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Nov 27 02:44:36 2018

[logdog] Wrap StreamRegistrationCallback to wrap callbacks to call only on full LogEntries.

BUG= 843714 

Change-Id: Ibdb31d2c2e68cb9b5a7cee39c90698688647ffe0
Reviewed-on: https://chromium-review.googlesource.com/c/1345049
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/479e91972550399acb820c0f07fea12b16b51939/logdog/client/butler/bundler/bundler.go
[modify] https://crrev.com/479e91972550399acb820c0f07fea12b16b51939/logdog/client/butler/butler.go
►

Sign in to add a comment