Issue metadata
Sign in to add a comment
|
Chrome OS Camera app, system crash when "Save" a photo |
||||||||||||||||||||||
Issue descriptionChrome OS: 10678.0.0, 68.0.3429.0 (dev) Android: 7.1.1 Camera vers: 5.0.1 Device: Vayne EVT, Caroline, Samus, Santa Steps: 1. Launch Chrome OS camera app 2. Capture still photo 3. Then click on "Go to gallary" to open folder 4. Select any captured pictures 5. Select "Save to Disk" to Downloads folder 6. Click "Open" to save the file Actual result: ChromeOS crashed How frequently does this problem reproduce? (100%) Note: also reproducible on Caroline, Samus, Santa Feedback ID: Vayne- 85444987854, Caroline- 85444982485, Samus- 85445039156
,
May 17 2018
Noel, can you take a look?
,
May 17 2018
,
May 21 2018
Ping noel - did you get a chance to look at this? Weifang, is this a regression? It sounds like it is. Increasing priority to P1.
,
May 21 2018
This is a regression. Not sure if the recent Camera app changes could be impacting this though.
,
May 21 2018
"if the recent Camera app changes" ... there were changes?
,
May 21 2018
The team in Taipei has been updating the Camera app to support video and longer term are working to align the Android Camera to Chrome OS Camera capabilities.
,
May 22 2018
The recording support was released on 4/22. Android camera and CrOS camera consolidation has not been merged yet. Therefore, I would guess it's probably not related to this bug.
,
May 22 2018
Well something changed for the CrOS camera app. Where/what it is exactly, and maybe what code repository is it in?
,
May 22 2018
FYR, the save-file code was changed 2016-08-26: https://chromium.googlesource.com/apps/camera/+blame/master/src/js/views/gallery_base.js Line128~170 (2016-08-26) https://chromium.googlesource.com/apps/camera/+blame/master/src/js/models/gallery.js Line349~356 (2016-08-26)
,
May 22 2018
ok, and the camera app is this one (I assume) https://chrome.google.com/webstore/detail/camera/hfhhnacclhffhdffklopdkcgdhifgngh
,
May 22 2018
Yes. Thanks.
,
May 23 2018
Ok thanks, that's the extension (#11) I installed to test the bug repro steps on Chrome OS: 10678.0.0, 68.0.3429.0 (dev) Reproduced the issue on a chell device at: commit 6d4429f1b45aaf71744065e1e1760d72c4b68efb Author: chrome-release-bot Date: Sat May 12 03:08:13 2018 +0000 Updating trunk VERSION from 3428.0 to 3429.0 crrev.com/558101 FAIL The previous version was good: commit 50d726e7d71a2ad162c55b63c9a959b0e8e149a9 Author: chrome-release-bot Date: Fri May 11 03:36:51 2018 +0000 Updating trunk VERSION from 3427.0 to 3428.0 crrev.com/557779 GOOD Bisecting on the chell device (file attached) found the issue: commit 1c397d3ddc70d0a4ffacb9bec37d447d8dd8ec9f 166 Date: Fri May 11 18:06:58 2018 +0000 [Extensions] Remove GetAssociatedWebContents() calls from file manager API crrev.com/557936 FAIL Re-assigning.
,
May 23 2018
This was already reverted in revision eaffdd8c5fb9f81bc7956de38389aad8048bcfc8 on May 14 - have you tested on 68.0.3431.0 or later? If it's still happening there, it's unrelated. (Otherwise, we can go ahead and close this out.)
,
May 23 2018
Right, more as FYI (I recall seeing the revert fly by). Lemme test 68.0.3431.0.
,
May 23 2018
Ok, tested 68.0.3431.0, and no problem.
,
May 23 2018
Phewf :) Thanks for confirming, noel!
,
May 23 2018
No problem :) For completeness, tested ToT 68.0.3439.0 crrev.com/561087, and no problem there either. All good here. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by weifangsun@chromium.org
, May 16 2018