New issue
Advanced search Search tips

Issue 843705 link

Starred by 2 users
Status: Fixed
Owner:
xiaochu@chromium.org
Closed: May 2018
Cc:
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

better interpretation of Load API callback

Project Member Reported by xiaochu@chromium.org, May 16 2018 
background: https://chromium-review.googlesource.com/c/chromium/src/+/1026195


1) I'll add comment to clarify this - how to interpret callback.
2), so far there are 4 callers for Load API. The latest one chrome/browser/chromeos/crostini/crostini_manager.cc tends to check error code which is a good sign - once we provide an error code, developers naturally check it. The the only one left is media_perception_api_manager.cc which I'm going to address it together with 1).

Comment 1 by xiaochu@chromium.org, May 16 2018

Cc: thestig@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b993a889029fa6e3038a584043bf8b2c0b7562

commit f0b993a889029fa6e3038a584043bf8b2c0b7562
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Sat May 19 01:49:41 2018

component_updater: better intepratation of Load callback

1. Add comments to encourage caller to check error code.

2. Modify media_perception_api_delegate_chromeos to check error code.

BUG= chromium:843705 
TEST=media_perception_private_apitest

Change-Id: I48f5a901f0e327b5ede7e63f24f38f9e212cc304
Reviewed-on: https://chromium-review.googlesource.com/1065135
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560141}
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/chrome/browser/component_updater/cros_component_installer_chromeos.h
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/extensions/browser/api/media_perception_private/media_perception_api_delegate.h
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/extensions/browser/api/media_perception_private/media_perception_api_manager.cc
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/extensions/browser/api/media_perception_private/media_perception_api_manager.h
[modify] https://crrev.com/f0b993a889029fa6e3038a584043bf8b2c0b7562/extensions/browser/api/media_perception_private/media_perception_private_apitest.cc

Comment 3 by xiaochu@chromium.org, May 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment