New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843703 link

Starred by 3 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: May 2018
Cc:
█ spqc...@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] Tab Strip Context Menus: Don't show the Short-Cut descriptions

Project Member Reported by meh...@chromium.org, May 16 2018 
Chrome Version: Canary 68.0.3432.0
OS: macOS 10.13.x

What steps will reproduce the problem?
(1) Right click on a tab, so that the new context menu appears

What is the expected result?
Not to see the Short-Cut descriptions like in Cocoa.

What happens instead?
Short-Cut descriptions are shown.

Screenshots are attached.

(If this is intentional, please feel free to close this report.)

Thanks.
Mehmet
MacViews.png
34.6 KB View Download
Cocoa.png
34.3 KB View Download

Comment 1 by meh...@chromium.org, May 16 2018 

Additional info: The Short-Cuts have an inactive state colour in the row of the active items. Only if you hover over them, they are matching the colour of the active items.
Short_cut_color_active_item.mov
777 KB View Download

Comment 2 by ellyjo...@chromium.org, May 17 2018

Labels: M-68 MacViews-Browser Target-68
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43dce2b6afdd186d7f6a06a0561271958cf94a21

commit 43dce2b6afdd186d7f6a06a0561271958cf94a21
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue May 22 17:34:55 2018

macviews: hide accelerators in context menus

This change:
1) Moves the logic for showing accelerator text into MenuConfig
2) Adds a MenuConfig variable for whether to show accelerator text in
   context menus

Bug:  843703 
Change-Id: Iedcef2ba4cdfc2a5390ddc0c9889af339625938d
Reviewed-on: https://chromium-review.googlesource.com/1069035
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560681}
[modify] https://crrev.com/43dce2b6afdd186d7f6a06a0561271958cf94a21/ui/views/controls/menu/menu_config.cc
[modify] https://crrev.com/43dce2b6afdd186d7f6a06a0561271958cf94a21/ui/views/controls/menu/menu_config.h
[modify] https://crrev.com/43dce2b6afdd186d7f6a06a0561271958cf94a21/ui/views/controls/menu/menu_config_mac.mm
[modify] https://crrev.com/43dce2b6afdd186d7f6a06a0561271958cf94a21/ui/views/controls/menu/menu_item_view.cc

Comment 4 by vamshi.kommuri@chromium.org, May 23 2018

Labels: Needs-Feedback
Tried checking the issue on reported chrome version 68.0.3432.0 and on 68.0.3438.0 using Mac 10.13.1.

Our observations:
-----------------
In 68.0.3432.0 we were able to see shortcut descriptions(...similar to that of MacViews.png in Comment#0).

In 68.0.3438.0 we didn't didn't observe any such shortcut descriptions, Attaching the screen cast of the same.

@Elly Fong-Jones: As we are not very clear about the expected behaviour i.e., in comment#0 it speaks about the presence of Short-Cut descriptions and in comment#1 about the Short-Cuts having an inactive state colour. Could you please let us know the exact expected behaviour and help us in verifying the fix.

Thanks!
843703 CL.png
455 KB View Download

Comment 5 by ellyjo...@chromium.org, May 23 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment