Issue metadata
Sign in to add a comment
|
For new user, dismissing a wifi-notification causes crash |
||||||||||||||||||||||
Issue descriptionChrome Version: <From about:version: Google Chrome 67.0.3396.49> Chrome OS Version: <From about:version: Platform 10575.40.0> Chrome OS Platform: <Nautilus/Elm> Network info: <WiFi> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) On the login screen, connect to WiFi network with open security. (2) Add an enterprise user, which auto connects to a more secure network. (3) When the network switches, wifi notification is generated. (4) Click on icon and clear all the notifications. Expected Result: Clearing notification should not cause any crash. Actual Result: Chrome crashes on clearing the notification How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always. What is the impact to the user, and is there a workaround? If so, what is it? Do not dismiss the notification, but chrome takes a long time to load user sees a black screen for the same time. Please provide any additional information below. Attach a screen shot or log if possible. Uploaded Crash Report ID 681cb9a1d9e752e5 (Local Crash ID: Chrome) https://listnr.corp.google.com/report/85450336003 Screenshot attached. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 16 2018
Can this be reproduced on 68? I'll try to reproduce this locally. Not sure if this is a Networking bug or a Notifications bug.
,
May 16 2018
based on go/crash/681cb9a1d9e752e5 it looks like it could be bug 842705 Do we know which notification this is?
,
May 16 2018
@ Can this be reproduced on 68? >>Will check and update @Do we know which notification this is? >> Wifi network changed. This is during the login process.
,
May 16 2018
What I meant was which bit of code as there are a few under chrome/browser/ui/ash/network/. What is the text on the notification?
,
May 16 2018
ah, I think it's this one: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/auto_connect_notifier.cc?rcl=4b6987d03b6fb71b0edd05b996da72c3913f5052&l=135 no doubt this is hitting this DCHECK: https://cs.chromium.org/chromium/src/chrome/browser/notifications/notification_display_service_impl.cc?rcl=6d759e1d32ad341cd8e0d5e8666dae470b7c4aa4&l=205 fix up here: https://chromium-review.googlesource.com/#/c/chromium/src/+/1062653
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e03299eab652bf51b73541f8bd52178c913f6439 commit e03299eab652bf51b73541f8bd52178c913f6439 Author: Evan Stade <estade@chromium.org> Date: Wed May 16 22:17:35 2018 Chrome OS: Fix crash with auto connect notifier. Also add checks to StubNotificationDisplayService test util class to catch this in the future (checks match NotificationDisplayServiceImpl production code). Bug: 843692 Change-Id: Iebb64687dadf6eb50bffea80e946e8dd3336bac9 Reviewed-on: https://chromium-review.googlesource.com/1062653 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#559307} [modify] https://crrev.com/e03299eab652bf51b73541f8bd52178c913f6439/chrome/browser/notifications/stub_notification_display_service.cc [modify] https://crrev.com/e03299eab652bf51b73541f8bd52178c913f6439/chrome/browser/ui/ash/auto_connect_notifier.cc
,
May 16 2018
Kyle, could you take care of merging this since I'm OOO for the next few work days? Thanks a bunch.
,
May 16 2018
Sure thing, Evan! kbleicher@: Requesting merge to fix this crash (regression in M-67).
,
May 16 2018
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 17 2018
Hi, can you provide some details on the testing completed and on a variety of boards? Thanks.
,
May 17 2018
aashutoshk@ is testing out this fix on multiple boards and will report back this afternoon. Thanks!
,
May 18 2018
Working as expected. I checked on Coral and Nautilus device (R68-10688.0.0). Clearing notification did not cause any crash.
,
May 18 2018
,
May 18 2018
Merge request approved, M67.
,
May 18 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dc7112adb3c52dfe747cef1deb8b511f816d0b commit 02dc7112adb3c52dfe747cef1deb8b511f816d0b Author: Kyle Horimoto <khorimoto@google.com> Date: Fri May 18 19:03:19 2018 Chrome OS: Fix crash with auto connect notifier. Also add checks to StubNotificationDisplayService test util class to catch this in the future (checks match NotificationDisplayServiceImpl production code). TBR=estade@chromium.org (cherry picked from commit e03299eab652bf51b73541f8bd52178c913f6439) Bug: 843692 Change-Id: Iebb64687dadf6eb50bffea80e946e8dd3336bac9 Reviewed-on: https://chromium-review.googlesource.com/1062653 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#559307} Reviewed-on: https://chromium-review.googlesource.com/1066499 Cr-Commit-Position: refs/branch-heads/3396@{#646} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/02dc7112adb3c52dfe747cef1deb8b511f816d0b/chrome/browser/notifications/stub_notification_display_service.cc [modify] https://crrev.com/02dc7112adb3c52dfe747cef1deb8b511f816d0b/chrome/browser/ui/ash/auto_connect_notifier.cc
,
May 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aashuto...@chromium.org
, May 16 2018