New issue
Advanced search Search tips

Issue 843691 link

Starred by 2 users
Status: Fixed
Owner:
petermayo@chromium.org
Closed: Jul 11
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

fast/css/opacity-float.html fails on Win10 - wrong locale used for printing decimals

Project Member Reported by lukasza@chromium.org, May 16 2018 
Since around https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35036, fast/css/opacity-float.html fails on Win10 saying:

This test verifies that reading a floating-point opacity from CSS attributes gets back a properly-formatted float. Improperly handling locales that cause decimals to be written as commas might break it.
FAIL: 0,9

Comment 1 by lukasza@chromium.org, May 16 2018

Owner: brucedaw...@chromium.org
Status: Assigned (was: Untriaged)
brucedawson@, could you PTAL?  Your CL (r559033) is the only one that stands out in the blamelist of https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35036

Comment 2 by lukasza@chromium.org, May 16 2018 

In the meantime, I can put together a CL that disables this test on Win10

Comment 3 by lukasza@chromium.org, May 16 2018

Summary: fast/css/opacity-float.html fails on Win10 - wrong locale used for printing decimals (was: fast/css/opacity-float.html fails on Win10)
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a83895b20aa26d94a97cd9ea06b2d2804d1156

commit 62a83895b20aa26d94a97cd9ea06b2d2804d1156
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed May 16 20:11:57 2018

Add failure expectation for fast/css/opacity-float.html on Win10

Bug:  843691 
Change-Id: Ic066c88c0c452b1c257f857af694a51ed89cd044
Tbr: brucedawson@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1062197
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559252}
[modify] https://crrev.com/62a83895b20aa26d94a97cd9ea06b2d2804d1156/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by lukasza@chromium.org, May 16 2018

Labels: -Type-Bug -Pri-3 OS-Windows Pri-2 Type-Bug-Regression
Since this seems like a recent regression, I guess Pri2 is more appropriate.

Comment 6 by brucedaw...@chromium.org, May 17 2018

Owner: lukasza@chromium.org
It may well be that my CL is the problem, although presumably it just exposes an underlying issue where we aren't handling locales properly.

My CL was reverted due to other problems (it broke v8 when rolled into v8), but my CL will be relanded as soon as the goma support that v8 needs is finished.

I'm about to go on vacation so I won't be able to investigate this in the near future so reassigning.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9aa2b6a98023b74cee69ab94fe5abbb46936de5

commit f9aa2b6a98023b74cee69ab94fe5abbb46936de5
Author: Peter Mayo <petermayo@chromium.org>
Date: Tue Jul 10 15:18:23 2018

fast/css/opacity-float.html no longer fails

The bug said this was a windows specific failure, and that the code
that exposed it was reverted.

I suggest we re-enable the test.

BUG= crbug.com/843691 

Change-Id: Idb0182e9c38b6449ef5162a6956b9d36a3615d32
Reviewed-on: https://chromium-review.googlesource.com/1129625
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573735}
[modify] https://crrev.com/f9aa2b6a98023b74cee69ab94fe5abbb46936de5/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by petermayo@google.com, Jul 11

Owner: petermayo@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment