New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843684 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 842280



Sign in to add a comment

Distinguish isolated targets with patch from those that don't have it.

Project Member Reported by robert...@chromium.org, May 16 2018

Issue description

This is needed so that isolate build index can tell the difference between those built at a committed revision from those built with a patch, such as CQ jobs or tryjobs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b

commit 7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Jun 01 20:33:49 2018

Add suffix to swarm_hashes property when present.

This is meant for Findit isolated target indexing to distinguish
isolated targets that have patches on top of whatever revision
bot_update says they have checked out (i.e. cq built isolates)

R=stgao,chanli,nodir

Bug:  843684 
Change-Id: I831d8275c806274a8ba442a8956d1e6b750cb6a9
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1062494
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/pinpoint/builder.expected/basic.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_isolate_only.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/swarming/staging.expected/windows.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/webkit_layout_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/README.recipes.md
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/swarming/staging.expected/cros.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/7fa7cb2c5b3ffd363412b1b5613ab2c41c0ea66b/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json

Status: Verified (was: Started)

Sign in to add a comment