New issue
Advanced search Search tips

Issue 843676 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 846370

Blocking:
issue 803289



Sign in to add a comment

Add metrics for context menus android app shortcuts

Project Member Reported by warx@chromium.org, May 16 2018

Issue description

(1) Since we are using asynchronous query, we need to measure query time to check whether the query time is reasonable for UI response.
(2) more metrics for tracking the user actions of this feature


 
Labels: M-69 Tablet-Projects-Warx

Comment 2 by warx@chromium.org, May 24 2018

Blockedon: 846370
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/385e17361005ba7d219e8eaa5c020115845a4ad4

commit 385e17361005ba7d219e8eaa5c020115845a4ad4
Author: Qiang Xu <warx@google.com>
Date: Thu May 24 21:31:24 2018

arc: add arc app shortcuts build menu time metrics

Metrics added: Arc.AppShortcuts.BuildMenuTime in unit of "ms".

Bug:  843676 
Test: chrome://histograms
Change-Id: I89887e965bcd9b6dce943fd54e0c00020ce513e8
Reviewed-on: https://chromium-review.googlesource.com/1069907
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561639}
[modify] https://crrev.com/385e17361005ba7d219e8eaa5c020115845a4ad4/chrome/browser/chromeos/arc/app_shortcuts/arc_app_shortcuts_menu_builder.cc
[modify] https://crrev.com/385e17361005ba7d219e8eaa5c020115845a4ad4/chrome/browser/chromeos/arc/app_shortcuts/arc_app_shortcuts_menu_builder.h
[modify] https://crrev.com/385e17361005ba7d219e8eaa5c020115845a4ad4/tools/metrics/histograms/histograms.xml

Comment 4 by warx@chromium.org, Jun 15 2018

Cc: -newcomer@chromium.org
Owner: newcomer@chromium.org
Metrics for launching app shortcuts is recorded in "Apps.ContextMenuExecuteCommand.FromApp", where 1000-1999 is reserved to log actions on launching android app shortcuts. Probably this bug can be marked as fixed from here, if this is enough.
Labels: M-70
Labels: -M-69
Alex, is this fixed? Or are there still things that need doing? And if so do you think it could happen this week? Otherwise we should probably move to M-71.
Status: Fixed (was: Assigned)
This is done! Thanks

Sign in to add a comment