Remove 90 minute timeout in PreCQ launcher |
|||||
Issue descriptionToday, PreCQ Launcher will consider any build that doesn't "report in" through CIDB in 90 minutes to have been broken by a CL. This assumption is because it is possible to fundamentally breaks Chromite so much that it cannot write the CIDB SQL record to indicate that it has started. The reasons that we historically used CIDB and not BuildBot was that BuildBot did not have sufficient API's to indicate that a job had been scheduled. Now that we are off of BuildBot and on to Swarming completely for PreCQ, we can avoid this problem entirely by using the Swarming Buildbucket API's to read job scheduled status. Therefore, the 90 minute timeout is no longer needed. This is blocking the increase of the number of boards that we include in PreCQ because we anticipate that--at least for the short term during peak hours--we while slightly backlog PreCQ requests while the PreCQ machine resources are saturated.
,
May 17 2018
Issue 644916 has been merged into this issue.
,
May 17 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a206cf9d1b118709147506d2a2e5ffa39e551cd4 commit a206cf9d1b118709147506d2a2e5ffa39e551cd4 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Thu Jun 07 15:35:54 2018 Remove 90 min timeout for Pre-CQ launching. We switched to swarming, so no longer need the timeout. BUG= chromium:843640 TEST=Ran unittest locally. Tryjob. CQ-DEPEND=CL:1088349 Change-Id: I851691643ac7cdd5b59f31b468c5ceeb97017382 Reviewed-on: https://chromium-review.googlesource.com/1064330 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/a206cf9d1b118709147506d2a2e5ffa39e551cd4/cbuildbot/stages/sync_stages.py
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/00e3bda0bd299ac047039d908a4bb7dde45358cd commit 00e3bda0bd299ac047039d908a4bb7dde45358cd Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Jun 07 15:35:54 2018 sync_stages: Detect early crashes of pre-CQ builders with Buildbucket. If a Pre-CQ builder crashes in early stages, it does not insert any CL actions to CIDB. The new logic will detect such crashes by querying Buildbucket and insert necessary CL actions on behalf of the crashed builder. BUG= chromium:843640 TEST=run_tests Change-Id: Idfc3c6dabb5ed5988384e495afc738828084105e Reviewed-on: https://chromium-review.googlesource.com/1088349 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/00e3bda0bd299ac047039d908a4bb7dde45358cd/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/00e3bda0bd299ac047039d908a4bb7dde45358cd/cbuildbot/stages/sync_stages.py
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b5e3742dfaa8b659288c0026fe729f3a75cde70 commit 7b5e3742dfaa8b659288c0026fe729f3a75cde70 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 07 19:44:11 2018 Roll src/third_party/chromite 0de5a91..a206cf9 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0de5a91..a206cf9 git log 0de5a91..a206cf9 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 hidehiko@chromium.org Remove 90 min timeout for Pre-CQ launching. 2018-06-07 nya@chromium.org sync_stages: Detect early crashes of pre-CQ builders with Buildbucket. Created with: gclient setdep -r src/third_party/chromite@a206cf9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:843640 , chromium:843640 TBR=chrome-os-gardeners@chromium.org Change-Id: I8545700c0cb5acc6ddf0a2762670d305be5692af Reviewed-on: https://chromium-review.googlesource.com/1090764 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565380} [modify] https://crrev.com/7b5e3742dfaa8b659288c0026fe729f3a75cde70/DEPS
,
Jun 8 2018
,
Jun 26 2018
Is this done?
,
Jun 28 2018
Yes, right. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jclinton@chromium.org
, May 16 2018