Download location settings IPH crash |
|||
Issue descriptionChrome Version: 68.0.3432.0 The IPH for download location setting crashed. Repro step: 1. Enable Downloads location change flag in chrome://flags. 2. Go to Download home, crashed about 80% of chance.
,
May 17 2018
This probably only happens on Android K, the Popupwindow has different internal layout from later versions of Android.
,
May 17 2018
The device to reproduce this crash is Samsung Galaxy J2 with Android 5.1.1. Can't repro with a nexus 1 with Android 4.4.4.
,
May 17 2018
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/658180175f391c0dc6375113adbe3531e09f1b6f commit 658180175f391c0dc6375113adbe3531e09f1b6f Author: Xing Liu <xingliu@chromium.org> Date: Sat May 19 00:56:14 2018 Download location: Fix IPH crash on download settings button. On Android L, the PopupWindow used by IPH TextBubble needs to be attached to the window manager before updating the position. This CL shows the IPH when the DownloadAcitivity is attached to the window manager. Bug: 843634 Change-Id: I587e5100478a6059d481a355341b23e4b948f611 Reviewed-on: https://chromium-review.googlesource.com/1065112 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#560124} [modify] https://crrev.com/658180175f391c0dc6375113adbe3531e09f1b6f/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
,
May 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xingliu@chromium.org
, May 17 2018