New issue
Advanced search Search tips

Issue 843627 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

cros_fuzz_test_env: cleanup does not work

Project Member Reported by manojgupta@chromium.org, May 16 2018

Issue description

$ ../../../chromite/bin/cros_fuzz_test_env  --board=amd64-generic --cleanupcros_fuzz_test_env: Unhandled exception:
Traceback (most recent call last):
  File "../../../chromite/bin/cros_fuzz_test_env", line 169, in <module>
    DoMain()
  File "../../../chromite/bin/cros_fuzz_test_env", line 165, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/lib/commandline.py", line 911, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/usr/local/google/home/manojgupta/host_migration/chromite/scripts/cros_fuzz_test_env.py", line 67, in main
    RunMountCommands(sysroot_path, options.cleanup)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/scripts/cros_fuzz_test_env.py", line 29, in RunMountCommands
    osutils.UnmountDir(mount_path)
AttributeError: 'module' object has no attribute 'UnmountDir'


In adidtion, the call to UmountDir deletes the directories used for mounting.
So post cleanup, the call to setup doesn't work anymore.

 ../../../chromite/bin/cros_fuzz_test_env  --board=amd64-generic15:36:29: INFO: RunCommand: sudo -- mount -t proc none /usr/local/google/home/manojgupta/host_migration/chroot/build/amd64-generic/proc
mount: /usr/local/google/home/manojgupta/host_migration/chroot/build/amd64-generic/proc: mount point does not exist.
cros_fuzz_test_env: Unhandled exception:
Traceback (most recent call last):
  File "../../../chromite/bin/cros_fuzz_test_env", line 169, in <module>
    DoMain()
  File "../../../chromite/bin/cros_fuzz_test_env", line 165, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/lib/commandline.py", line 911, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/usr/local/google/home/manojgupta/host_migration/chromite/scripts/cros_fuzz_test_env.py", line 67, in main
    RunMountCommands(sysroot_path, options.cleanup)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/scripts/cros_fuzz_test_env.py", line 38, in RunMountCommands
    cros_build_lib.SudoRunCommand(command)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/lib/cros_build_lib.py", line 333, in SudoRunCommand
    return RunCommand(sudo_cmd, **kwargs)
  File "/usr/local/google/home/manojgupta/host_migration/chromite/lib/cros_build_lib.py", line 658, in RunCommand
    raise RunCommandError(msg, cmd_result)
chromite.lib.cros_build_lib.RunCommandError: return code: 32; command: sudo -- mount -t proc none /usr/local/google/home/manojgupta/host_migration/chroot/build/amd64-generic/proc
cmd=['sudo', '--', 'mount', '-t', 'proc', 'none', '/usr/local/google/home/manojgupta/host_migration/chroot/build/amd64-generic/proc']
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0f7ef0866708190773719a5092b5947ae37961ae

commit 0f7ef0866708190773719a5092b5947ae37961ae
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed May 16 23:42:49 2018

cros_fuzz_test_env: Fix cleanup option.

Fix a typo in call to UmountDir and pass cleanup=False
so that mount directories are not deleted.

BUG= chromium:843627 
TEST=No more errors in cleanup/setup when ran consecutively multiple times.

Change-Id: Iea4687665b326ae7f825832f9c9c0075ca345233
Reviewed-on: https://chromium-review.googlesource.com/1062074
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/0f7ef0866708190773719a5092b5947ae37961ae/scripts/cros_fuzz_test_env.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6e9f9e54e907eb474b62cc926eb40744bb01ae5

commit b6e9f9e54e907eb474b62cc926eb40744bb01ae5
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 17 00:53:03 2018

Roll src/third_party/chromite/ 4c1562dfd..966fe6267 (6 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4c1562dfdeef..966fe62677b1

$ git log 4c1562dfd..966fe6267 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 ayatane sysmon: Add ignored metric to prod manifest
2018-05-16 bmgordon build_stages: Handle exceptions in snapshot commands
2018-05-16 manojgupta cros_fuzz_test_env: Fix cleanup option.
2018-04-27 dgarrett remote_try: Rename to request_build.
2018-04-27 dgarrett remote_try: Rearrange a little.
2018-04-26 dgarrett cros_tryjob: Move tryjob specific logic into cros tryjob.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:843441,chromium:843627,chromium:824550,chromium:824550,chromium:824550


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibd98b2152ec46624b2c80e06bb60514e17ca9e2a
Reviewed-on: https://chromium-review.googlesource.com/1063030
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559372}
[modify] https://crrev.com/b6e9f9e54e907eb474b62cc926eb40744bb01ae5/DEPS

Status: Verified (was: Untriaged)

Sign in to add a comment