New issue
Advanced search Search tips

Issue 843624 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

The extension-remove dialog is too wide when attached to a browser action as a popover

Project Member Reported by pbos@chromium.org, May 16 2018

Issue description

Dialog uses modal width instead of popover width when acting as a popover as it unconditionally uses modal-dialog width.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2793a25de466de7fc9d9d390b87860207b3865d8

commit 2793a25de466de7fc9d9d390b87860207b3865d8
Author: Peter Boström <pbos@chromium.org>
Date: Mon May 21 23:06:52 2018

Narrow extension-uninstall dialog as a bubble

This dialog can be rendered both as a modal dialog and a popover, the
size of it needs to reflect both visual styles and use the appropriate
width constant.

Bug:  chromium:843624 
Change-Id: I2c69a1704bb6502d55115078486691930bc9d74e
Reviewed-on: https://chromium-review.googlesource.com/1062910
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560395}
[modify] https://crrev.com/2793a25de466de7fc9d9d390b87860207b3865d8/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

Labels: Needs-Feedback
Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the build without fix 68.0.3430.0 and on the latest Canary 68.0.3437.2 as per the original comment.

Can see the narrow extension uninstall dialog on the latest Canary on Windows and Linux, but on Mac OS it is same as the previous versions.
Attached are the screen shots for reference.

pbos@ Request you to check and confirm the fix on the latest Canary 68.0.3437.2 build.

Thanks..
843624-build-without-fix-windows.png
87.3 KB View Download
843624-M68-CL.png
90.9 KB View Download
843624-Mac.png
105 KB View Download
// Linux screenshot
843624-linux.png
214 KB View Download

Comment 4 by pbos@chromium.org, May 22 2018

Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
I assume the Mac one is using Cocoa which is why the dialog is not anchoring to the extension. This is a separate implementation and Mac is moving over to the common one. Working as intended. Thanks for checking!

Sign in to add a comment