New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843618 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

184.8% regression in system_health.common_desktop at 554638:554652

Project Member Reported by chiniforooshan@chromium.org, May 16 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 16 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=843618

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e48295750b4ecf9cfc3ba2c15c2d9ef02e34a294b1ccdc1153a2f873d7e768ab


Bot(s) for this bug's original alert(s):

win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 18 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15d8db38240000
Cc: tdres...@chromium.org
+tdresser: Is it weird that bisect can't repro this at all?
Cc: pmonette@chromium.org
Based on the traces, this appears to be due to an increase in execution time of:
src_file	"../../chrome/browser/conflicts/module_inspector_win.cc"
src_func	"StartInspectingModule"

+pmonette, any idea why we'd see this taking way more time?

There's nothing related in the regression range.
https://chromium.googlesource.com/chromium/src/+log/62873578dc30938f2e9a042e10448f14394b8e5d%5E..4eec0e9093412b192db79d9eeca90ef873a9db82?pretty=fuller&n=1000
Status: WontFix (was: Untriaged)
Huh sorry I missed this issue. I closed a few other issues that are basically the same thing: increased CPU time in module_inspector_win.cc

This is totally expected because of new background tasks I've added that are quite expensive to run (verification of the signature of a file). They should have no impact on the performance of Chrome because they run with background priority.

Unless something else regressed, I'll be marking this as WontFix.
Cc: benhenry@chromium.org ushesh@chromium.org
+folks for performance tradeoffs.

This will potentially impact battery. Can you provide a bit more context on what this verification is doing?
It's part of the third-party DLL blocking (https://blog.chromium.org/2017/11/reducing-chrome-crashes-caused-by-third.html)

Each loaded module is analyzed once on a background task. This basically mean checking the certificate of the file on disk.
Thanks for the context!
I can actually give more context.

This task is run once per loaded module throughout the execution of Chrome. Given that the number of loaded modules for an average user is under 100, I don't expect this to affect battery life unless Chrome is restarted often.
 Issue 843619  has been merged into this issue.

Sign in to add a comment