Issue metadata
Sign in to add a comment
|
184.8% regression in system_health.common_desktop at 554638:554652 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15d8db38240000
,
May 18 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/15d8db38240000
,
Jul 16
+tdresser: Is it weird that bisect can't repro this at all?
,
Jul 16
Based on the traces, this appears to be due to an increase in execution time of: src_file "../../chrome/browser/conflicts/module_inspector_win.cc" src_func "StartInspectingModule" +pmonette, any idea why we'd see this taking way more time? There's nothing related in the regression range. https://chromium.googlesource.com/chromium/src/+log/62873578dc30938f2e9a042e10448f14394b8e5d%5E..4eec0e9093412b192db79d9eeca90ef873a9db82?pretty=fuller&n=1000
,
Jul 17
Huh sorry I missed this issue. I closed a few other issues that are basically the same thing: increased CPU time in module_inspector_win.cc This is totally expected because of new background tasks I've added that are quite expensive to run (verification of the signature of a file). They should have no impact on the performance of Chrome because they run with background priority. Unless something else regressed, I'll be marking this as WontFix.
,
Jul 18
+folks for performance tradeoffs. This will potentially impact battery. Can you provide a bit more context on what this verification is doing?
,
Jul 18
It's part of the third-party DLL blocking (https://blog.chromium.org/2017/11/reducing-chrome-crashes-caused-by-third.html) Each loaded module is analyzed once on a background task. This basically mean checking the certificate of the file on disk.
,
Jul 18
Thanks for the context!
,
Jul 18
I can actually give more context. This task is run once per loaded module throughout the execution of Chrome. Given that the number of loaded modules for an average user is under 100, I don't expect this to affect battery life unless Chrome is restarted often.
,
Jul 18
Issue 843619 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 16 2018