New issue
Advanced search Search tips

Issue 843599 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

CastDialogViewTest.ShowAndHideDialog is flaky on Mac10.10

Project Member Reported by flackr@chromium.org, May 16 2018

Issue description

11 of the last 200 runs have failed on this bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests?limit=200

It seems to have been flaky since it was landed in https://chromium.googlesource.com/chromium/src/+/62155aa5c35449f913f7dbd3f51f78d5c41c0ce3

I will investigate if it's flaking on other bots as well.
 

Comment 1 by flackr@chromium.org, May 16 2018

Seems to only be flaky on the Mac - possibly only Mac10.10. I created a patch to disable on Mac:
https://chromium-review.googlesource.com/c/chromium/src/+/1062593
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6deeda0644490c4dc3f228d86a207bca607c4290

commit 6deeda0644490c4dc3f228d86a207bca607c4290
Author: Robert Flack <flackr@chromium.org>
Date: Wed May 16 20:41:15 2018

Disable CastDialogViewTest.ShowAndHideDialog on Mac

It seems to be flaky about 5% of runs since it was added on the Mac10.10 bot.

TBR=imcheng@chromium.org

Bug:  843599 
Change-Id: I94b4dde41e2455af3fa3fe3f4e02f6c3a3a14013
Reviewed-on: https://chromium-review.googlesource.com/1062593
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559273}
[modify] https://crrev.com/6deeda0644490c4dc3f228d86a207bca607c4290/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc

Comment 3 by finnur@chromium.org, May 17 2018

Labels: -Sheriff-Chromium
Bug assigned, removing Sheriff label.
Components: Tests>Flaky
Cc: powerb@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eed462400adc7478d33776190104ad595879905

commit 7eed462400adc7478d33776190104ad595879905
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Jan 02 20:42:46 2019

Re-enable disabled tests in chrome/browser/ui/views/media_router/.

These pass on Windows.

This requires (mostly) reverting
https://chromium-review.googlesource.com/c/chromium/src/+/1005103 .
The revert is not perfect since many things changed since that CL
initially landed (e.g. various tests got disabled).

Bug:  658005 , 678472, 817408,  828031 ,  843599 ,  849146 ,  863945 
Change-Id: I23a3010be1faf962e0a2dfbaaa4a57a3e2cc89d3
Reviewed-on: https://chromium-review.googlesource.com/c/1351874
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619483}
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/apps/platform_apps/app_window_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/keyboard_lock_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/test/base/in_process_browser_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment