New issue
Advanced search Search tips

Issue 843596 link

Starred by 2 users
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 883143
Blocking:
issue 865801



Sign in to add a comment

Extract suggestion logic from LocationBarLayout

Project Member Reported by tedc...@chromium.org, May 16 2018 
All of the suggestion triggering and display logic is grouped in with the location bar UI code.

The goal of this effort is to split out the suggestion UI and triggers into a separate component that would allow the location bar layout to focus purely on the UI components of the location bar itself.

Comment 2 by tedc...@chromium.org, Jul 20

Blocking: 865801

Comment 3 by tedc...@chromium.org, Sep 12

Blockedon: 883143
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f530ad435509d7f7e1c8d225d876147b7323a7e

commit 1f530ad435509d7f7e1c8d225d876147b7323a7e
Author: Ted Choc <tedchoc@chromium.org>
Date: Tue Oct 02 22:08:19 2018

Initial split of Autocomplete logic from LocationBarLayout.

This is a bulk (and rather gross) move out of LocationBar into a
Coordinator.  The coordinator is still the full collection of view
and business logic, but this is the first attempt at the split and
further refinement will be behind the coordinator API.

BUG= 843596 

Change-Id: I435943e79d34573f3f229710470a91107d8ff5cc
Reviewed-on: https://chromium-review.googlesource.com/c/1252540
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596000}
[add] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteCoordinator.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandler.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarCoordinator.java
[add] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarEditingTextStateProvider.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/java_sources.gni
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandlerTest.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
[modify] https://crrev.com/1f530ad435509d7f7e1c8d225d876147b7323a7e/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8052d0e117f8e3a972a62c825648c11b210ce425

commit 8052d0e117f8e3a972a62c825648c11b210ce425
Author: Ted Choc <tedchoc@chromium.org>
Date: Mon Oct 15 19:19:10 2018

Move Omnibox suggestion classes to subpackage of omnibox.

NOPRESUBMIT=true
BUG= 843596 

Change-Id: I08316abfd1e7be7427337538c722716a0737048f
Reviewed-on: https://chromium-review.googlesource.com/c/1279184
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599707}
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandler.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/VoiceSuggestionProvider.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AnswerTextBuilder.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AnswersImage.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteController.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestion.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionAnswer.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/java_sources.gni
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandlerTest.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/VoiceSuggestionProviderTest.java
[rename] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionAnswerTest.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/browser/BUILD.gn
[modify] https://crrev.com/8052d0e117f8e3a972a62c825648c11b210ce425/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3dc94394dfbea007fa099f89f19aa3052f62965

commit e3dc94394dfbea007fa099f89f19aa3052f62965
Author: Ted Choc <tedchoc@chromium.org>
Date: Tue Oct 23 18:07:03 2018

Fix the omnibox suggestions container sizing logic.

This makes the omnibox sizing part of the measure flow.
The coordinator layout allows to specify anchor views which
determines the layout ordering ensuring the anchor view is
laid out prior to the suggestion view.  This ensures that on
rotation, the measured width of the anchor view is correct
before measure is called on the list.

BUG= 843596 

Change-Id: I030f09f82476c427c7ab1f966961a567ad72ecba
Reviewed-on: https://chromium-review.googlesource.com/c/1289997
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602022}
[modify] https://crrev.com/e3dc94394dfbea007fa099f89f19aa3052f62965/chrome/android/java/res/layout/main.xml
[modify] https://crrev.com/e3dc94394dfbea007fa099f89f19aa3052f62965/chrome/android/java/res/layout/search_activity.xml
[modify] https://crrev.com/e3dc94394dfbea007fa099f89f19aa3052f62965/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/e3dc94394dfbea007fa099f89f19aa3052f62965/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
[modify] https://crrev.com/e3dc94394dfbea007fa099f89f19aa3052f62965/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java

Comment 7 by tedc...@chromium.org, Oct 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment