New issue
Advanced search Search tips

Issue 843583 link

Starred by 2 users
Status: Fixed
Owner:
chengx@chromium.org
Closed: Dec 5
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ChromeLaunchTest leaves child processes behind when it fails

Project Member Reported by finnur@chromium.org, May 16 2018 
NotificationHelperLaunchesChrome.ChromeLaunchTest is testing activation, which creates child processes. Greg pointed out during review that leaving processes behind can potentially be bad and we should try to ensure that we clean it up even on failure.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4acb88e56dbef1120e121e10710ea20c786e27ee

commit 4acb88e56dbef1120e121e10710ea20c786e27ee
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Dec 04 23:46:29 2018

Make sure the notification_helper process is killed when test fails

Bug:  843583 
Change-Id: Ic9108654a39f6fda3bfc2c18ffbfd82736c87638
Reviewed-on: https://chromium-review.googlesource.com/c/1357528
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613763}
[modify] https://crrev.com/4acb88e56dbef1120e121e10710ea20c786e27ee/chrome/browser/notifications/win/notification_helper_launches_chrome_unittest.cc

Comment 2 by chengx@chromium.org, Dec 5

Status: Fixed (was: Assigned)
►

Sign in to add a comment