New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843578 link

Starred by 4 users
Status: Untriaged
Owner: ----
Cc:
█ jparent@chromium.org
hinoka@chromium.org
█ nednguyen@chromium.org
seanmccullough@chromium.org
chanli@chromium.org
liaoyuke@chromium.org
st...@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-21
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Failure log" link from flakiness dashboard doesn't work for perf tests

Project Member Reported by charliea@chromium.org, May 16 2018 
Steps to reproduce: 

1. Open up the flakiness dashboard for some chromium.perf test (e.g. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=v8.browsing_desktop%2Fbrowse%3Amedia%3Ayoutube&testType=v8.browsing_desktop)

2. Click on a box representing a run of a given story at a given revision.

3. Click the "failure log" link.

EXPECTED: You're taken to the log of the failing test.

ACTUAL: You're shown a 404 error, Page Not Found. (image attached, page URL https://build.chromium.org/deprecated/chromium.perf/builders/Mac%2010.12%20Perf/builds/2055/steps/v8.browsing_desktop/logs/browsing_desktop/browse:media:youtube)

Any idea what might be going on here? Accessing failures through the flakiness dashboard is our preferred method, so this is a big deal for chromium.perf bot health sheriffing.

Comment 1 by charliea@chromium.org, May 16 2018 

If it's at all helpful, it looks like https://cs.chromium.org/chromium/build/masters/master.chromium.perf.fyi/templates/build.html?type=cs&q=%22steps+and+logfiles%22&sq=package:chromium&g=0&l=124 is the location in code where the chromium.perf run log generates the same URL. It's not clear to me how we can replicate that from the flakiness dashboard, though.

Comment 2 by charliea@chromium.org, May 16 2018

NextAction: 2018-05-17

Comment 3 by monor...@bugs.chromium.org, May 17 2018 

The NextAction date has arrived: 2018-05-17

Comment 4 by charliea@chromium.org, May 17 2018

NextAction: 2018-05-18

Comment 5 by monor...@bugs.chromium.org, May 18 2018 

The NextAction date has arrived: 2018-05-18

Comment 6 by charliea@chromium.org, May 18 2018

Cc: jparent@chromium.org seanmccullough@chromium.org
NextAction: 2018-05-21
/bump on this, and CCing Julie and Sean

This is by far the easiest way to look through historical test failures as the bot health sheriff, but it's not working now.

Comment 7 by seanmccullough@chromium.org, May 18 2018

Cc: hinoka@chromium.org
hinoka@ Looks like there might be a redirect happening on milo that sends it to the wrong location? 
$ curl -v http://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf/builds/2068/steps/v8.browsing_desktop/logs/browsing_desktop/browse:media:youtube

*   Trying 74.125.248.71...
* TCP_NODELAY set
* Connected to build.chromium.org (74.125.248.71) port 80 (#0)
> GET /p/chromium.perf/builders/Mac%2010.12%20Perf/builds/2068/steps/v8.browsing_desktop/logs/browsing_desktop/browse:media:youtube HTTP/1.1
> Host: build.chromium.org
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 302 Found
< Location: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf/builds/2068/steps/v8.browsing_desktop/logs/browsing_desktop/browse:media:youtube
< Content-Length: 0
< Content-Type: text/html; charset=UTF-8
<
* Connection #0 to host build.chromium.org left intact

Comment 8 by hinoka@chromium.org, May 18 2018 

Buildbot purges logs pretty aggressively, so it's not super surprising that it 404's if you link to buildbot.  I'd suggest linking to the logdog version of the log instead.

How are the links extracted from the build?

I think for these links, you may need to look at the log "alias" section instead of the main log link, otherwise you'd end up on buildbot.

Comment 9 by monor...@bugs.chromium.org, May 21 2018 

The NextAction date has arrived: 2018-05-21
►

Sign in to add a comment