New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843570 link

Starred by 4 users
Status: Fixed
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
smbar...@chromium.org
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Sommelier doesn't handle window gravity correctly

Project Member Reported by reve...@chromium.org, May 16 2018 
Some X11 clients (e.g. libreoffice) set a window gravity that is not northwest on client windows. Sommelier assumes for resize purposes that window gravity is always northwest. This is causing unexpected positioning of client windows.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2227b44771ae149c4a9ca02cad15afa70fa3d539

commit 2227b44771ae149c4a9ca02cad15afa70fa3d539
Author: David Reveman <reveman@chromium.org>
Date: Wed May 16 23:42:47 2018

vm_tools: sommelier: handle window gravity correctly

First, we remove any weird gravity when we start managing a window
as that seems to be a common practice in other WMs and allows the
application to detect that gravity changed.

This also makes the resize code more robust against problems with
window gravity. Basically, we don't assume that it's northwest as
a misbehaving client can always try to change this back to
something else.

BUG= chromium:843570 
TEST=resize of libreoffice windows work correctly

Change-Id: Ie13b30c1e785151d32cd2d66ec11e1954b46c1fa
Reviewed-on: https://chromium-review.googlesource.com/1061945
Commit-Ready: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/2227b44771ae149c4a9ca02cad15afa70fa3d539/vm_tools/sommelier/sommelier.c

Comment 2 by reve...@chromium.org, May 17 2018

Status: Fixed (was: Started)
►

Sign in to add a comment