Expose NotificationManager.getActiveNotifications() in TrustedWebActivityClient |
|||
Issue descriptionFor internal bookkeeping purposes, the notification system might have to know which notifications are currently showing. For Trusted Web Activities, it needs to find that out via the TrustedWebActivityClient. It should be relatively straightforward to add another method that delegates to NotificationManager.getActiveNotifications() in the TWA.
,
May 17 2018
I would probably return an error of *some* form (so that we don't pretend the list of notifications really is empty), but I don't have strong feelings on what form that would take -- it could be an exception or an error value.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/custom-tabs-client/+/12637375da5ca2bee01ba0118c00f21930025f35 commit 12637375da5ca2bee01ba0118c00f21930025f35 Author: Peter E Conn <peconn@chromium.org> Date: Thu May 17 13:52:54 2018 🔁 Expose NotificationManager#getActiveNotifications. Bug: 843567 Change-Id: Iac548c8d8acfcde68a7ff8f8e4f7a74ec412c75b Reviewed-on: https://chromium-review.googlesource.com/1063970 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> [modify] https://crrev.com/12637375da5ca2bee01ba0118c00f21930025f35/customtabs/src/android/support/customtabs/trusted/ITrustedWebActivityService.aidl [modify] https://crrev.com/12637375da5ca2bee01ba0118c00f21930025f35/customtabs/src/android/support/customtabs/trusted/TrustedWebActivityServiceWrapper.java [modify] https://crrev.com/12637375da5ca2bee01ba0118c00f21930025f35/customtabs/tests/src/android/support/customtabs/trusted/TestTrustedWebActivityService.java [modify] https://crrev.com/12637375da5ca2bee01ba0118c00f21930025f35/customtabs/src/android/support/customtabs/trusted/TrustedWebActivityService.java [modify] https://crrev.com/12637375da5ca2bee01ba0118c00f21930025f35/customtabs/tests/src/android/support/customtabs/trusted/TrustedWebActivityServiceConnectionManagerTest.java
,
May 17 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by peconn@chromium.org
, May 17 2018Owner: peconn@chromium.org