New issue
Advanced search Search tips

Issue 843560 link

Starred by 1 user
Status: Fixed
Owner:
mar...@chromium.org
Closed: May 2018
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Swarming: Update LKGBC for inactive bots

Project Member Reported by mar...@chromium.org, May 16 2018 
Some bots are idle for extended period of times (over a year), so their LKGBC becomes so stale they crash upon host reboot.

Change the code to update LKGBC if it is older than a wekk.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/c3bbfc7d6093def70414673bc7ac7c0436feaa18

commit c3bbfc7d6093def70414673bc7ac7c0436feaa18
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed May 16 19:19:31 2018

[swarming] Update LKGBC in edge case of inactive bots.

I'm writing this CL because I'm tired of manually updating idle bots that
broken by the sheer fact of their LKGBC being over a year old.

Add a formal LKGBC section in Bot.md so it is easier to link to.

Includes unit tests for both the normal LKGBC update code path (which was
missing, oops) and the new one.

Bug:  843560 
Change-Id: I235660a174adc19957b0423e5aadab40c05af455
Reviewed-on: https://chromium-review.googlesource.com/1061815
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/c3bbfc7d6093def70414673bc7ac7c0436feaa18/appengine/swarming/doc/Bot.md
[modify] https://crrev.com/c3bbfc7d6093def70414673bc7ac7c0436feaa18/appengine/swarming/swarming_bot/bot_code/bot_main.py
[modify] https://crrev.com/c3bbfc7d6093def70414673bc7ac7c0436feaa18/appengine/swarming/swarming_bot/bot_code/bot_main_test.py

Comment 2 by mar...@chromium.org, May 17 2018

Status: Fixed (was: Assigned)
Confirmed to work, it's amazing!
►

Sign in to add a comment