Facebook save password suggestion gets truncated above the keyboard |
||||||
Issue descriptioniOS Version: 10.3.3,11.3 Device: iPhone App Version: 67.0.3396.47 beta iOS Version: 10.3.3,11.3 Precondition: 1. Have the Password saved for facebook.com. 2. Change the device orientation to RTL. Steps to reproduce: 1. Launch chrome 2. Goto facebook.com 2. Place the cursor on user name. Observed results: Suggestions displayed above the keyboard are truncated. Expected results: Eight bullets should be shown and No truncation should be seen Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA in M66 Bug reproducible on the current beta channel build : Yes in M67 Link : Comparison of M66 and 67 https://drive.google.com/file/d/17IZ-hK2HcWFnbVm1t5ae9usoEj2RkplO/view?usp=sharing Expected : https://drive.google.com/file/d/1H2ook0FpM1d4MiFpqxuTlcZbO-7U3Tar/view?usp=sharing
,
May 17 2018
,
May 17 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa70444c56ac0511606dd3a9b8f9800fd774d7f commit 7fa70444c56ac0511606dd3a9b8f9800fd774d7f Author: vasilii <vasilii@chromium.org> Date: Tue May 22 12:42:05 2018 Fix alignment of the password suggestions in RTL on iOS. The bug happened because layoutSubviews() was called twice. So that the rects were shifted twice as well. Bug: 843557 ,844407 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2336416264a24ef8904c0b67831dd117c82a76ba Reviewed-on: https://chromium-review.googlesource.com/1064414 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560543} [modify] https://crrev.com/7fa70444c56ac0511606dd3a9b8f9800fd774d7f/ios/chrome/browser/autofill/form_suggestion_view.mm
,
May 22 2018
,
May 29 2018
Tested in 69.0.3444.0 Canary, iPhone 7 iOS 11.4 "...הצג הכל" ("Show All...") is hidden and there user can not swipe left/right in RTL (Hebrew).
https://drive.google.com/file/d/1p1NAURL4BrtY7rox0xzp18As_sj9cZi9/view
https://drive.google.com/file/d/1ORsEc10qDSrxxyXGApc_-kBV6luGq7vf/view
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fa239fd063cee6d628e66bf47d326e760dde792 commit 8fa239fd063cee6d628e66bf47d326e760dde792 Author: vasilii <vasilii@chromium.org> Date: Thu Jun 14 12:30:15 2018 Fix scrolling in the keyboard accessory on iOS in RTL. layoutSubviews is called continuously when scrolling is happening. We shouldn't set a scrolling position there. Bug: 843557 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16891bfbcf4eb2f30c4b7f2ad86275a1cc2f7cb8 Reviewed-on: https://chromium-review.googlesource.com/1078871 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567230} [modify] https://crrev.com/8fa239fd063cee6d628e66bf47d326e760dde792/ios/chrome/browser/autofill/form_suggestion_label.h [modify] https://crrev.com/8fa239fd063cee6d628e66bf47d326e760dde792/ios/chrome/browser/autofill/form_suggestion_label.mm [modify] https://crrev.com/8fa239fd063cee6d628e66bf47d326e760dde792/ios/chrome/browser/autofill/form_suggestion_view.mm
,
Jun 14 2018
,
Jun 19 2018
Verified in 69.0.3465.0 Canary, iPhone 7 iOS12.0 Looks good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vabr@chromium.org
, May 17 2018Status: Available (was: Untriaged)