New issue
Advanced search Search tips

Issue 843551 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Can't launch Terminal

Project Member Reported by tsteiner@google.com, May 16 2018

Issue description

Chrome version: (copy from chrome://version) 68.0.3416.0 (Official Build) dev (64-bit)
OS: Version 68.0.3416.0 (Official Build) dev (64-bit)

Repro steps:
1. Click on Terminal icon 
2. Window opens and closes immediately again
3. On the console, enter 

$ run_container.sh --user=tsteiner --shell --container_name=penguin
/usr/bin/run_container.sh: 128: /usr/bin/run_container.sh: cannot create /run/sshd/penguin/ssh_host_key: Permission denied

Expected: Terminal launches
Actual: Terminal doesn't launch

 

Comment 1 by svenmay@google.com, May 16 2018

Cc: svenmay@google.com
Components: OS>Systems>Containers
Labels: -Pri-2 Pri-0
Owner: smbar...@chromium.org
Status: Started (was: Untriaged)
Fix at https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1062020
Status: Fixed (was: Started)
Fixed on 10685.0.0
 Issue 843552  has been merged into this issue.
 Issue 843654  has been merged into this issue.

Comment 7 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google
Labels: -Pri-0 Pri-1
Status: Started (was: Fixed)
There are some lingering issues here. Looking at those now.

Comment 9 by vapier@chromium.org, May 17 2018

keep in mind  issue 843682  where there was a bug in crosh itself but should be fixed with the latest canary.  not sure if that made it to dev.
There are still some lingering bugs from 10683.0.0, which broke people's container configs. I've got a follow-on CL to fix this: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1064872
Project Member

Comment 11 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3c923660973551bcaece89031b5af9ed84dc39c7

commit 3c923660973551bcaece89031b5af9ed84dc39c7
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri May 18 02:35:14 2018

termina: add minijail to target-termina-os

BUG= chromium:843551 
TEST=minijail is on termina image

Change-Id: I482e2850fa1665234864a0e4a5616ae34c367b8e
Reviewed-on: https://chromium-review.googlesource.com/1063373
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3c923660973551bcaece89031b5af9ed84dc39c7/project-termina/virtual/target-termina-os/target-termina-os-1.5.ebuild
[rename] https://crrev.com/3c923660973551bcaece89031b5af9ed84dc39c7/project-termina/virtual/target-termina-os/target-termina-os-1.5-r17.ebuild

Thanks! The update to 10685.0.0 let me (after a wiping step) eventually install and run terminal, but now it seems like openssh-server is refusing connections for local file sharing over sftp. Is this a known issue?  
The fix top the openssh-server issue apparently is to 'sudo rm /etc/ssh/sshd_not_to_be_run', then 'vmc stop termina', and rerunning Terminal.
Project Member

Comment 14 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/c52f23111c012f8efb2d88edaae991b70d99c5b9

commit c52f23111c012f8efb2d88edaae991b70d99c5b9
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat May 19 03:08:21 2018

termina: lxd scripts: fix bind mount handling

Initial container creation is now performed separately from container start.
This will guarantee that any bind mounts are done before the container is
started. Also refactor bind mount setup for the container so that bind mounts
are only added if the source path exists.

BUG= chromium:843551 
TEST=run_container.sh works on hosts whether or not they set up SSH keys
TEST=migrated containers from 10683.0.0 work

Change-Id: I9e67ac8cf35222d4e22f8a9bc5ba84d646dd2d13
Reviewed-on: https://chromium-review.googlesource.com/1064872
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[rename] https://crrev.com/c52f23111c012f8efb2d88edaae991b70d99c5b9/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1-r20.ebuild
[modify] https://crrev.com/c52f23111c012f8efb2d88edaae991b70d99c5b9/project-termina/chromeos-base/termina-lxd-scripts/files/run_container.sh

Project Member

Comment 15 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cbed97c5bfe708c42bd3601891bf08a422bc3b63

commit cbed97c5bfe708c42bd3601891bf08a422bc3b63
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat May 19 03:08:37 2018

vm_tools: concierge: use minijail for run_container.sh

This guarantees that /run/sshd and /run/tokens files are owned
by chronos.

BUG= chromium:843551 
TEST=/run/tokens and /run/sshd files are owned by chronos
CQ-DEPEND=CL:1063373

Change-Id: I9af7a281fd55e2b96666afafa8723f9e07249878
Reviewed-on: https://chromium-review.googlesource.com/1063374
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/cbed97c5bfe708c42bd3601891bf08a422bc3b63/vm_tools/concierge/service.cc

Status: Fixed (was: Started)
Fixed, will land with the next VM uprev.

Sign in to add a comment