New issue
Advanced search Search tips

Issue 843545 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDL dictionary ImplementedAs v8 include error

Project Member Reported by rayankans@chromium.org, May 16 2018

Issue description

I tried to create a dictionary with an ImplementedAs value.

When building I got the following compile error:

gen/third_party/blink/renderer/bindings/modules/v8/v8_{dict_name}.h:
fatal error: 'third_party/blink/renderer/modules/manifest/{implemented_as_dict_name}.h' file not found

 
Cc: peria@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd798ef6152bdcbeb8f6787feda564db03fb342

commit 8dd798ef6152bdcbeb8f6787feda564db03fb342
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed May 16 14:52:10 2018

Fix IDL ImplemenetedAs dictionary v8 include bug.

Bug:  843545 
Change-Id: I744c4d15cf9a44846342b9ec23d3406937ebb973
Reviewed-on: https://chromium-review.googlesource.com/1061695
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559087}
[modify] https://crrev.com/8dd798ef6152bdcbeb8f6787feda564db03fb342/third_party/blink/renderer/bindings/scripts/compute_interfaces_info_individual.py
[modify] https://crrev.com/8dd798ef6152bdcbeb8f6787feda564db03fb342/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.h

Status: Fixed (was: Started)

Sign in to add a comment