New issue
Advanced search Search tips

Issue 843520 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Squad: always compute style as part of style recalc for dom elements

Project Member Reported by futhark@chromium.org, May 16 2018

Issue description

We should never need to call StyleForLayoutObject() in LayoutTreeBuilderForElement::Style() as it should have been computed during the style recalc pass.

This issue is for tracking this for true DOM elements.  Issue 836126  is tracking this for pseudo elements.


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/000f9c18d1d4420b51ad79357ef630a791d0d10e

commit 000f9c18d1d4420b51ad79357ef630a791d0d10e
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri May 18 18:51:33 2018

[Squad] RecalcStyle for object fallback content.

If the object only contains params and whitespace, we will not create
layout objects for the white-space nodes. Still, we will call
LayoutObjectIsNeeded(Style()) from the LayoutTreeBuilder which will
compute the style on-demand in Style().

Instead, recalc style for the nodes during the style recalc pass, but
only if fallback would have been rendered if it was there.

Bug:  843520 
Change-Id: Ic18014d6acde8ab2ac9d3f4eca083138ffbf2697
Reviewed-on: https://chromium-review.googlesource.com/1065990
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559974}
[modify] https://crrev.com/000f9c18d1d4420b51ad79357ef630a791d0d10e/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/000f9c18d1d4420b51ad79357ef630a791d0d10e/third_party/blink/renderer/core/html/html_object_element.h
[add] https://crrev.com/000f9c18d1d4420b51ad79357ef630a791d0d10e/third_party/blink/renderer/core/html/html_object_element_test.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c0ff8616c2fff66bd303a68349ae7c21d1d1def

commit 1c0ff8616c2fff66bd303a68349ae7c21d1d1def
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri May 18 19:47:46 2018

[Squad] Fix progress shadow LayoutObjectIsNeeded for reattach.

Recalc style for re-attachment for progress shadow elements need to use
GetComputedStyle on the progress element instead of its layout object
since the element will not yet have a layout object.

This made use not recalculate style for progress shadow elements during
style recalc making it necessary to call StyleForLayoutObject from the
LayoutTreeBuilderForElement.

Bug:  843520 
Change-Id: Ia21c1b0f766cfc1cb90fb50f9f52f1f4f64d7562
Reviewed-on: https://chromium-review.googlesource.com/1065673
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559996}
[modify] https://crrev.com/1c0ff8616c2fff66bd303a68349ae7c21d1d1def/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/1c0ff8616c2fff66bd303a68349ae7c21d1d1def/third_party/blink/renderer/core/html/shadow/progress_shadow_element.cc
[add] https://crrev.com/1c0ff8616c2fff66bd303a68349ae7c21d1d1def/third_party/blink/renderer/core/html/shadow/progress_shadow_element_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e4865dfef0b7f4262205faf4311da7ec73205b9

commit 0e4865dfef0b7f4262205faf4311da7ec73205b9
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon May 21 18:35:39 2018

[Squad] Recalc <content> fallback for reattachment.

We would skip style recalc for <content> fallback descendants because
<content> elements are not part of the flat tree, hence they will not
have a ParentComputedStyle() and we would think it's because it's
display:none. Instead traverse into <content> children when <content>
needs reattachment.

Bug:  843520 
Change-Id: I2b7f6b44c600371422e86750308231b60e2f5abd
Reviewed-on: https://chromium-review.googlesource.com/1065682
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560313}
[modify] https://crrev.com/0e4865dfef0b7f4262205faf4311da7ec73205b9/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/0e4865dfef0b7f4262205faf4311da7ec73205b9/third_party/blink/renderer/core/dom/element.cc
[add] https://crrev.com/0e4865dfef0b7f4262205faf4311da7ec73205b9/third_party/blink/renderer/core/html/html_content_element_test.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c589cd8c9bf9fa68ee1b1fa34cc5609f3537763b

commit c589cd8c9bf9fa68ee1b1fa34cc5609f3537763b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon May 21 21:57:58 2018

[Squad] Recalculate style separately for AttachContext tests.

We relied on LayoutTreeBuilderForElement to compute style through
StyleForLayoutObject for these tests. Compute style in style recalc pass
as we would do in production.

Bug:  843520 
Change-Id: Ib03317c479f06f3aecad668a8bdba0924fa5b8f5
Reviewed-on: https://chromium-review.googlesource.com/1065683
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560364}
[modify] https://crrev.com/c589cd8c9bf9fa68ee1b1fa34cc5609f3537763b/third_party/blink/renderer/core/dom/node_test.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e4c8ef4f33e732e8c559567abd156242d022594

commit 1e4c8ef4f33e732e8c559567abd156242d022594
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu May 24 13:42:31 2018

[Squad] Don't rely on ancestry for foreignObject LayoutObjectIsNeeded.

The overloaded LayoutObjectIsNeeded was introduced for a crasher which
no longer happens with the overloaded method removed.

This change makes us correctly recalc style for re-attachment of
foreignObject when <g> parent changes display from none to block.

TEST=svg/foreignObject/foreign-object-defs-crash.svg

Bug:  843520 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I78e073ff41090b4b9d53f2f2be921a70ddc993e2
Reviewed-on: https://chromium-review.googlesource.com/1070137
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561486}
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-5-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-6-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/foreignObject/fO-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/linux/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/foreignObject/fO-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt
[add] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/platform/win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt
[delete] https://crrev.com/09c6d27e5dbba14dc9a05ae872bfe8e2010a5193/third_party/WebKit/LayoutTests/svg/foreignObject/fO-parent-display-none-expected.txt
[delete] https://crrev.com/09c6d27e5dbba14dc9a05ae872bfe8e2010a5193/third_party/WebKit/LayoutTests/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt
[delete] https://crrev.com/09c6d27e5dbba14dc9a05ae872bfe8e2010a5193/third_party/WebKit/LayoutTests/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt
[delete] https://crrev.com/09c6d27e5dbba14dc9a05ae872bfe8e2010a5193/third_party/WebKit/LayoutTests/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/blink/renderer/core/svg/svg_foreign_object_element.cc
[modify] https://crrev.com/1e4c8ef4f33e732e8c559567abd156242d022594/third_party/blink/renderer/core/svg/svg_foreign_object_element.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fe326cd80cd13676bbb45ba47bb5c9754989bfe

commit 6fe326cd80cd13676bbb45ba47bb5c9754989bfe
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon May 28 12:54:04 2018

[Squad] Load input type=image on style recalc.

That way we would not have to re-attach the layout tree inside layout
tree rebuilding when image resources finish loading immediately.

TEST=fast/forms/image/fallback-reattach-crash.html

Bug:  843520 ,  845167 
Change-Id: I37e6121e30b8909dd5df4483f2109d5e1e02945c
Reviewed-on: https://chromium-review.googlesource.com/1072650
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562239}
[modify] https://crrev.com/6fe326cd80cd13676bbb45ba47bb5c9754989bfe/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/6fe326cd80cd13676bbb45ba47bb5c9754989bfe/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/6fe326cd80cd13676bbb45ba47bb5c9754989bfe/third_party/blink/renderer/core/html/forms/image_input_type.cc
[modify] https://crrev.com/6fe326cd80cd13676bbb45ba47bb5c9754989bfe/third_party/blink/renderer/core/html/forms/image_input_type.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329876ebb0709a460e96f540721ec8f8cf68845b

commit 329876ebb0709a460e96f540721ec8f8cf68845b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon May 28 14:22:51 2018

[Squad] Recalc style for re-attach for assigned nodes.

When recalculating style for re-attachment for a slot, traverse into
assigned nodes since the re-attachment root might not be an ancestor of
the assigned slots. Otherwise, the assigned nodes and descendants would
have had their style recomputed and set on their previous LayoutObjects
before being nuked by the Detach which meant they had to be recomputed
again in LayoutTreeBuilderForElement::Style().

NeedsStyleRecalc() needed an extra check to avoid recalculating style
for the assigned nodes twice. If we recalculate style for re-attachment
traversing down from their assigned slot, we would still reach them for
the shadow-including tree order traversal afterwards. The would still
have NeedsStyleRecalc() because we do not clear that flag for elements
being reattached. However, if that is the case, the
NeedsReattachLayoutTree() will be true.

Not clearing NeedsStyleRecalc() looks like its there to avoid an
unnecessary DetachLayoutTree() on initial attachment for a document in
Node::ReattachLayoutTree().

Bug:  843520 
Change-Id: I5fc1e1250bac64e191b13c7472081276fd3bd36b
Reviewed-on: https://chromium-review.googlesource.com/1070979
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562259}
[modify] https://crrev.com/329876ebb0709a460e96f540721ec8f8cf68845b/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/329876ebb0709a460e96f540721ec8f8cf68845b/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/329876ebb0709a460e96f540721ec8f8cf68845b/third_party/blink/renderer/core/html/html_slot_element_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b29d04b62d0f95e373dac8fb263b3148d19d9a

commit f5b29d04b62d0f95e373dac8fb263b3148d19d9a
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue May 29 05:07:59 2018

[Squad] Trigger image loading on style recalc for plugins.

This is done to avoid re-attaching fallback content as part of building
the layout tree. That meant we had to recalculate style twice, the
second time inside LayoutTreeBuilderForElement::Style().

TEST=http/tests/misc/object-image-error.html

Bug:  843520 ,  845167 

Change-Id: I5ad8d0f5d82a6ef0437d6ef5e1e015f5e1575faa
Reviewed-on: https://chromium-review.googlesource.com/1073421
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562341}
[modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_plugin_element.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/810bb17f22970b02ca6f050afaf9a2c8bcb5beb3

commit 810bb17f22970b02ca6f050afaf9a2c8bcb5beb3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed May 30 05:25:44 2018

[Squad] SetLayoutDisposition() not called during style update.

I have not been able to find a situation where we would call
SetLayoutDisposition() during style or layout tree update. Replacing the
synchronous re-attach code with a DCHECK.

Bug:  843520 ,  845167 
Change-Id: Ibf1e8a02d0e905522e4006be078b047b6a856b8a
Reviewed-on: https://chromium-review.googlesource.com/1076027
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562742}
[modify] https://crrev.com/810bb17f22970b02ca6f050afaf9a2c8bcb5beb3/third_party/blink/renderer/core/html/html_image_element.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cc5d1b3afcbf778e5e1655731716f4b7b496131

commit 9cc5d1b3afcbf778e5e1655731716f4b7b496131
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed May 30 10:35:48 2018

[Squad] Use UA styling for form inside table elements.

We did not implement UA style as specified for form elements inside
table elements. This CL removes the hardcoded way of not creating layout
objects and instead add display:none to the UA style sheet as specified.

We introduce a new internal pseudo class :-internal-is-html because the
rule should only apply in html documents. This is also what Gecko does
with its :-moz-is-html. The pseudo class is only allowed in UA sheets.

The relationship with Squad is that we get rid of the dependency on
ancestor layout objects in LayoutObjectIsNeeded.

Bug:  847763 ,  843520 
Change-Id: Ibc83b78493843b1a0503fbb65e509090fe295313
Reviewed-on: https://chromium-review.googlesource.com/1078348
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562789}
[add] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/form-in-tables.html
[add] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/form-in-tables.xhtml
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/html.css
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/rule_feature_set.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/parser/html_construction_site.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/inspector/inspector_trace_events.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06211ba1d45ec48b09f0c6ae4aabd84a5ccbf4f3

commit 06211ba1d45ec48b09f0c6ae4aabd84a5ccbf4f3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu May 31 11:43:50 2018

[Squad] Update UseFallbackContent() before descendant recalc.

UpdateFromElement() called during style recalc may trigger
RenderFallbackContent() which will update the value of
UseFallbackContent() if the loading finished synchronously.

UseFallbackContent() is used to decide if we need to recalc style for
object fallback. Starting resource loading happened in DidRecalcStyle()
which is called after descendants are recalculated, which is too late.

All elements should now get ComputedStyle as part of style recalc.

Add a DCHECK that only pseudo elements may compute style during layout
tree building.

Bug:  843520 ,  836126 
Change-Id: Iba0d8af1f79e5c33b20f6fdba1b9613ae5aadefd
Reviewed-on: https://chromium-review.googlesource.com/1078437
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563195}
[modify] https://crrev.com/06211ba1d45ec48b09f0c6ae4aabd84a5ccbf4f3/third_party/blink/renderer/core/dom/layout_tree_builder.cc
[modify] https://crrev.com/06211ba1d45ec48b09f0c6ae4aabd84a5ccbf4f3/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/06211ba1d45ec48b09f0c6ae4aabd84a5ccbf4f3/third_party/blink/renderer/core/html/html_plugin_element.h

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e3b989006dfe87d977d1a781e1f8da0520c18dc

commit 1e3b989006dfe87d977d1a781e1f8da0520c18dc
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Aug 01 12:18:33 2018

Don't use Bloom filter for layout tree rebuild.

Layout tree rebuild and re-attachment now only matches selectors for
::first-letter. It's not worth populating the Bloom filter with
ancestor attributes just for optimizing ::first-letter matching.

Bug:  843520 ,  836126 
Change-Id: I22c3a4d6518314ded66ef9b214db53c3ff16aac2
Reviewed-on: https://chromium-review.googlesource.com/1158230
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579774}
[modify] https://crrev.com/1e3b989006dfe87d977d1a781e1f8da0520c18dc/third_party/blink/renderer/core/dom/element.cc

Sign in to add a comment