New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

clean up testing/buildbot/*.pyl files

Project Member Reported by thakis@chromium.org, May 16 2018

Issue description

When we made all the json files in testing/buildbot/ generated by python scripts, the focus was to not change behavior. But some of the existing behavior was actually incorrect, and now that all the json files are generated, we can clean up and simplify the pyl files:

- Try to remove all the "unclear why this isn't run" exceptions and try to run all tests on all platforms as much as possible

- Have fewer test suite specifications -- almost all the "no_clang" specs can probably go away / be merged with the regular configs now that clang is on everywhere.
 
Showing comments 55 - 154 of 154 Older
Project Member

Comment 55 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194dc6d626d4569567324e68c89c7a8c42a0283f

commit 194dc6d626d4569567324e68c89c7a8c42a0283f
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 02:59:31 2018

Fold linux_incl_clang_specific_chromium_gtests into chromium_gtests_for_linux_and_chromeos_only.

Has the side effect of adding dbus_unittests to the regular cros bots
(it already runs on the cros asan bots).

Bug: 843511
Change-Id: I446eca0427a26c28958ece4c81e2bc5cdff9ca06
Reviewed-on: https://chromium-review.googlesource.com/1089651
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565159}
[modify] https://crrev.com/194dc6d626d4569567324e68c89c7a8c42a0283f/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/194dc6d626d4569567324e68c89c7a8c42a0283f/testing/buildbot/test_suites.pyl

Project Member

Comment 56 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641b0a238e729bafe973f009e14ae046c30fb595

commit 641b0a238e729bafe973f009e14ae046c30fb595
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 06:07:11 2018

Run viz_gtests on the memory and the clang tot bots.

The motivation is to make the memory and clang to bot test lists
identical to the main waterfall test lists, so that we can use a
single test list for all three waterfalls.

Bug: 843511
Change-Id: Ifc3d1e26788fed1b494f9ab9e0ba25991fdfae3b
Reviewed-on: https://chromium-review.googlesource.com/1089624
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565197}
[modify] https://crrev.com/641b0a238e729bafe973f009e14ae046c30fb595/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/641b0a238e729bafe973f009e14ae046c30fb595/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/641b0a238e729bafe973f009e14ae046c30fb595/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/641b0a238e729bafe973f009e14ae046c30fb595/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/641b0a238e729bafe973f009e14ae046c30fb595/testing/buildbot/test_suites.pyl

Project Member

Comment 57 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3611ee8016405443aa105108be952c072ce99b61

commit 3611ee8016405443aa105108be952c072ce99b61
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 13:34:51 2018

Unbreak win/cross build generate step after #563278.

That change added nacl_loader_unittests to the clang tot bots, but
the win/cross bot sets enable_nacl=false.

TBR=kbr@chromium.org

Bug: 843511
Change-Id: I529df5b574ad904919084fa5534b0911e98c7898
Reviewed-on: https://chromium-review.googlesource.com/1090814
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565251}
[modify] https://crrev.com/3611ee8016405443aa105108be952c072ce99b61/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/3611ee8016405443aa105108be952c072ce99b61/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 850464
Blockedon: 850517
Project Member

Comment 60 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b84ec09fcf860c97d22badf5916587fd9bba599

commit 1b84ec09fcf860c97d22badf5916587fd9bba599
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 14:23:34 2018

win: Let clang tot bots use the same test list as the main waterfall bots.

This ensures that the memory and clang tot bots run the same tests as the
main waterfall bots.

Everything running on the main waterfall must be tested with clang/tot too
to make sure compiler updates don't break anything. This change makes it
impossible for things to get out of sync (on win).

If https://chromium-review.googlesource.com/c/chromium/src/+/1088754 hadn't
been reverted, this would've been behavior-preserving. As-is, it adds
headless_browsertests and headless_unittests to the win clang tot bots.

Bug: 843511
Change-Id: I0c0568b47ca5ee56de7525bfcca8fc5e234acd6d
Reviewed-on: https://chromium-review.googlesource.com/1090818
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565258}
[modify] https://crrev.com/1b84ec09fcf860c97d22badf5916587fd9bba599/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/1b84ec09fcf860c97d22badf5916587fd9bba599/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1b84ec09fcf860c97d22badf5916587fd9bba599/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/1b84ec09fcf860c97d22badf5916587fd9bba599/testing/buildbot/waterfalls.pyl

Project Member

Comment 61 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61f5dff7fa556e34282c20701a7a40d456d4b00

commit e61f5dff7fa556e34282c20701a7a40d456d4b00
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 15:26:59 2018

Remove chromium_win_10_fast_ring_gtests.

The comment says it's supposed to be the same as chromium_win_clang_gtests
and interactive_ui_tests, but
https://chromium-review.googlesource.com/c/chromium/src/+/1076594 added
interactive_ui_tests to the clang list, and
https://chromium-review.googlesource.com/c/1090818/ removed chromium_win_clang_gtests
in favor of just chromium_win_gtests since the test lists have become equal.

This adds a bunch of tests to chromium_win_10_fast_ring_gtests that have been
added to chromium_win_clang_gtests and chromium_win_gtests after
chromium_win_10_fast_ring_gtests was forked. From the comment, it sounds like
adding these tests is what we should've done in the first place.

(I'm asking around if anyone looks at this bot at all since it's red and
it looks like it hasn't been touched in a while. Maybe I'll delete it in
a follow-up.)

Bug: 843511
Change-Id: I1fdb044c666941eb9beb8df0b50438e5a035f063
Reviewed-on: https://chromium-review.googlesource.com/1090819
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565273}
[modify] https://crrev.com/e61f5dff7fa556e34282c20701a7a40d456d4b00/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e61f5dff7fa556e34282c20701a7a40d456d4b00/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e61f5dff7fa556e34282c20701a7a40d456d4b00/testing/buildbot/waterfalls.pyl

Blockedon: 850556
Project Member

Comment 63 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3096fb94180ed630736a58df53757cf40b40cba

commit d3096fb94180ed630736a58df53757cf40b40cba
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 17:50:15 2018

Run nacl_helper_nonsfi_unittests on the main and memory waterfall linux bots.

It runs without issues on the clang tot linux bots, and on the main waterfall
cros bots already.

Bug: 843511
Change-Id: I9b0fa22cbb5adc146d7d6a72e12c177eb92b0179
Reviewed-on: https://chromium-review.googlesource.com/1090821
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565334}
[modify] https://crrev.com/d3096fb94180ed630736a58df53757cf40b40cba/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d3096fb94180ed630736a58df53757cf40b40cba/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d3096fb94180ed630736a58df53757cf40b40cba/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d3096fb94180ed630736a58df53757cf40b40cba/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/d3096fb94180ed630736a58df53757cf40b40cba/testing/buildbot/test_suites.pyl

Project Member

Comment 64 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff269eeb2508a544e5daf4fd7e4ab8586baf84c

commit eff269eeb2508a544e5daf4fd7e4ab8586baf84c
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 18:03:24 2018

Run network service tests and site isolation tests on the linux clang tot bots.

They run on the main waterfall, so they should run on the clang/tot bots as well.

Bug: 843511
Change-Id: I6fe7256c741d224c090fb38074fe98ff07353149
Reviewed-on: https://chromium-review.googlesource.com/1091071
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565340}
[modify] https://crrev.com/eff269eeb2508a544e5daf4fd7e4ab8586baf84c/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/eff269eeb2508a544e5daf4fd7e4ab8586baf84c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/eff269eeb2508a544e5daf4fd7e4ab8586baf84c/testing/buildbot/test_suites.pyl

Project Member

Comment 65 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147a75a5be889447d7f50c580832430f30d07539

commit 147a75a5be889447d7f50c580832430f30d07539
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 18:04:33 2018

Run linux_specific_chromium_gtests on the linux memory bots.

Enables these tests on the linux memory bots:

    filesystem_service_unittests
    leveldb_service_unittests
    traffic_annotation_auditor_unittests

They already run on the regular main waterfall linux bots and
on the clang tot bots.

Bug: 843511
Change-Id: Ie0f1b5ea6433c2f21f87df993ac205f4553ced89
Reviewed-on: https://chromium-review.googlesource.com/1091070
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565342}
[modify] https://crrev.com/147a75a5be889447d7f50c580832430f30d07539/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/147a75a5be889447d7f50c580832430f30d07539/testing/buildbot/test_suites.pyl

Project Member

Comment 66 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477893b82f9d471a1118ffb253be2225477fb0f3

commit 477893b82f9d471a1118ffb253be2225477fb0f3
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 07 18:33:33 2018

Run snapshot_unittests on the clang/tot linux bots.

It already runs on the regular linux main waterfall and memory bots.

TBR=hans

Bug: 843511
Change-Id: I3f5f97694291f4143614fb2b72344dda31cf1556
Reviewed-on: https://chromium-review.googlesource.com/1091141
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565360}
[modify] https://crrev.com/477893b82f9d471a1118ffb253be2225477fb0f3/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/477893b82f9d471a1118ffb253be2225477fb0f3/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/477893b82f9d471a1118ffb253be2225477fb0f3/testing/buildbot/test_suites.pyl

Blockedon: 850945
Project Member

Comment 68 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e140de210b0ad73faeb7753e01a2bd9b579e86ef

commit e140de210b0ad73faeb7753e01a2bd9b579e86ef
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 15:36:17 2018

Run headless tests on linux clang tot bots

Relands parts of https://chromium-review.googlesource.com/c/chromium/src/+/1088754

headless tests can't run on the memory waterfall yet because of  bug 844865 .
This adds them to the linux clang tot bots. (They already run on the mac and win
clang tot bots, and on the main waterfall.)

TBR=kbr

Bug: 843511, 843732 
Change-Id: Iec20d59c425b9d847fa2d3f076f907b69ba0e795
Reviewed-on: https://chromium-review.googlesource.com/1093051
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565640}
[modify] https://crrev.com/e140de210b0ad73faeb7753e01a2bd9b579e86ef/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/e140de210b0ad73faeb7753e01a2bd9b579e86ef/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e140de210b0ad73faeb7753e01a2bd9b579e86ef/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e140de210b0ad73faeb7753e01a2bd9b579e86ef/testing/buildbot/test_suites.pyl

Project Member

Comment 69 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af77af733bd2cd498b2aef95d080037c4929d3a

commit 3af77af733bd2cd498b2aef95d080037c4929d3a
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 17:19:11 2018

linux: Let clang tot bots use the same test list as the main waterfall bots.

This ensures that the memory and clang tot bots run the same tests as the
main waterfall bots.

Everything running on the main waterfall must be tested with clang/tot too
to make sure compiler updates don't break anything. This change makes it
impossible for things to get out of sync (on linux).

No behavior change, the chromium_linux_gtests and chromium_linux_clang_gtests
were identical already.

Also rename chromium_linux_clang_and_gl_gtests to chromium_linux_and_gl_gtests
and add a comment for it.

Bug: 843511
Change-Id: Idf95d837cdae5247d2011c85f2c19961d29bd195
Reviewed-on: https://chromium-review.googlesource.com/1093062
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565666}
[modify] https://crrev.com/3af77af733bd2cd498b2aef95d080037c4929d3a/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/3af77af733bd2cd498b2aef95d080037c4929d3a/testing/buildbot/waterfalls.pyl

Project Member

Comment 70 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc8b9da3470591336042560db119f50f5a4a1c8

commit 7fc8b9da3470591336042560db119f50f5a4a1c8
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 19:22:08 2018

testing/buildbot: enable bot existence checking for fyi, android.fyi, lkgr waterfalls

Looks like these waterfalls now exist in luci-milo.cfg, so this is now possible.

- Remove no-longer-existing bots "Chromium Mac 10.11",
  "Chromium Mac 10.11 Force Mac Toolchain", "Chromium Win 10 GCE Tests"

- "Chromium Win 10 GCE Tests" was the only bot using chromium_win_fyi_gtests,
  so remove that too (since the bot didn't exist, it wasn't used previously
  either), which in return was the only user of chrome_cleaner_gtests, so
  remove that too.

- Fix case sensitivity misspellings: We're not consistent about if bots are
  called ASan (more common) or ASAN (less common, but present).

- While here, also remove some remaining references to PGO from mb_config.pyl.

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1061597

Bug: 843511, 820422 
Change-Id: I70518fdedfab23c807afdcd8bb335a9aeacf09dc
Reviewed-on: https://chromium-review.googlesource.com/1093159
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565711}
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/chromium.lkgr.json
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/tools/mb/mb_config.pyl

Project Member

Comment 71 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f6c3bff9447d63aa0f60846d467ced969ce3b2

commit 35f6c3bff9447d63aa0f60846d467ced969ce3b2
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 19:58:24 2018

Remove unused test configs for CFI bots on the FYI waterfall.

These bots used to be on FYI, but they're on the clang waterfall now
(and also listed for that waterfall in waterfalls.pyl)

Bug: 843511
Change-Id: I5ee01813e2701e1346edb05bbb5d3bae723b9b96
Reviewed-on: https://chromium-review.googlesource.com/1093555
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565722}
[modify] https://crrev.com/35f6c3bff9447d63aa0f60846d467ced969ce3b2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/35f6c3bff9447d63aa0f60846d467ced969ce3b2/testing/buildbot/waterfalls.pyl

Project Member

Comment 72 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/038b85fb53805bc4e8a738d866ecc9e102813338

commit 038b85fb53805bc4e8a738d866ecc9e102813338
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 23:15:32 2018

Run nacl_loader_unittests on the linux asan bot.

It runs and passes on the clang tot asan bot, so it should work on the memory
waterfall asan bot too.

Bug: 843511
Change-Id: Id98c5f1fc6f461414debd270a54baabc3715e871
Reviewed-on: https://chromium-review.googlesource.com/1093774
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565771}
[modify] https://crrev.com/038b85fb53805bc4e8a738d866ecc9e102813338/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/038b85fb53805bc4e8a738d866ecc9e102813338/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 73 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2125f8979046e10bfa7c40827252a69e3d60e6a6

commit 2125f8979046e10bfa7c40827252a69e3d60e6a6
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 23:19:53 2018

Use chromium_linux_and_gl_gtests on fewer bots.

"Out of Process Profiling Linux" used chromium_linux_and_gl_gtests and then
removed of the suites added by _and_gl via test_suite_exceptions again.
Instead, just use regular chromium_linux_gtests for it. No behavior change.

"ToTLinuxThinLTO" used the _and_gl version and removed gl_tests again.
It didn't remove gl_unittests, but that one was failing on it. So just
use chromium_linux_gtests here too.

"ToTLinuxUBSanVptr" and "UBSanVptr Linux" were removing gl_tests (but not
gl_unittests) via the exceptions file despite not (yet?) using the _and_gl
test list, so remove these unused exceptions.

Add a comment explaining why interactive_ui_tests doesn't run on the ubsan
bots (probably it should run there, with just the few failing tests disabled).

Bug: 843511, 849868 
Change-Id: Ifd6397529fce300ef989f3a637f7ec48bd784175
Reviewed-on: https://chromium-review.googlesource.com/1093570
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565773}
[modify] https://crrev.com/2125f8979046e10bfa7c40827252a69e3d60e6a6/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/2125f8979046e10bfa7c40827252a69e3d60e6a6/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/2125f8979046e10bfa7c40827252a69e3d60e6a6/testing/buildbot/waterfalls.pyl

Project Member

Comment 74 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c149502277c1441eec693c3ec160462e150000b

commit 1c149502277c1441eec693c3ec160462e150000b
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 09 04:10:45 2018

Run headless tests on memory waterfall.

Relands the last missing bit of https://chromium-review.googlesource.com/1088754
This got reverted the last time because the msan bot had a too-old version of
Java.  This should now be fixed.

TBR=kbr

Bug: 843511, 850731 , 844865 , 843732 , 843734 
Change-Id: I2359e6e721fa603117dd2a0a2f11f459ee2a2ddf
Reviewed-on: https://chromium-review.googlesource.com/1094036
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565841}
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suites.pyl

Project Member

Comment 75 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2a65de9fccf8c6435f5425846d9f8261bd3a77

commit 3f2a65de9fccf8c6435f5425846d9f8261bd3a77
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 11 14:04:17 2018

Use same swarming settings for viz_browser_tests as browser_tests.

Doubles the amount of shards for the win(dbg) clang tot bots, and removes a
spurious test suppression on the tot thin lto bot. (If the suppression is still
needed, it should have a bug and should be disabled via DISABLED_ in the source.)

Bug: 843511
Change-Id: Ie54de8f21578dadbcbe2a6005c5d6ff49feef111
Reviewed-on: https://chromium-review.googlesource.com/1095317
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565990}
[modify] https://crrev.com/3f2a65de9fccf8c6435f5425846d9f8261bd3a77/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/3f2a65de9fccf8c6435f5425846d9f8261bd3a77/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 852002
Blockedon: 852004
Project Member

Comment 78 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebde4f7b56bdbda11bdeca5fef7adcba7727f9fc

commit ebde4f7b56bdbda11bdeca5fef7adcba7727f9fc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Jun 12 23:13:52 2018

Remove unused test_suite_exceptions entries.

Found by a locally-hacked-up generation script (
https://chromium-review.googlesource.com/c/chromium/src/+/1097616).

This has no effect in practice.

Bug: 843511
Change-Id: I2cd2194216511c4e6c7839f4b0a1174d7b834aee
Reviewed-on: https://chromium-review.googlesource.com/1097621
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566625}
[modify] https://crrev.com/ebde4f7b56bdbda11bdeca5fef7adcba7727f9fc/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 79 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79a11982af986cf57684fd6f638af69954e9147

commit a79a11982af986cf57684fd6f638af69954e9147
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 13 14:13:28 2018

Run snapshot_unittests on all desktop bots.

Adds snapshot_unittests to the main waterfall win bots,
the cros memory bots (already running on the others),
and the clang tot bots (all desktop platforms).

Disables the test on Win10, since it doesn't pass there.

Bug: 843511,850556, 438897 
Change-Id: Ifa577c3fe97bb10544addcd12e69a29a65cff01d
Reviewed-on: https://chromium-review.googlesource.com/1089655
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566825}
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.win.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/ui/snapshot/snapshot_aura_unittest.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4945dd5ba4eb9bf1baddb65d1b5d9b203e0c3417

commit 4945dd5ba4eb9bf1baddb65d1b5d9b203e0c3417
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 13 15:25:03 2018

Use some of the content_browsertests swarming settings for viz_content_browsertests too.

viz_content_browsertests just runs content_browsertests with a certain flag,
so the swarming settings should be the same.

Bug: 843511
Change-Id: I0a3ec8d369fced3744237b7efe7c3e8ceae0ff38
Reviewed-on: https://chromium-review.googlesource.com/1098630
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566838}
[modify] https://crrev.com/4945dd5ba4eb9bf1baddb65d1b5d9b203e0c3417/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/4945dd5ba4eb9bf1baddb65d1b5d9b203e0c3417/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/4945dd5ba4eb9bf1baddb65d1b5d9b203e0c3417/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 852442
Project Member

Comment 82 by bugdroid1@chromium.org, Jun 14 2018

Project Member

Comment 83 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d2fcddb075392bca05aa48c659afbc47c33432

commit 17d2fcddb075392bca05aa48c659afbc47c33432
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 14 18:28:19 2018

Get rid of recent win7/win10 chromium_win_gtests split again.

Undoes the split added in https://chromium-review.googlesource.com/1081627
The motivation for that split was that we don't have capacity to run
the test on both the win7 and win10 default cq bots.
Use test_suite_exceptions.pyl to not run the tests on the win7 cq bot.

This adds the test to the clang tot bots and some more main waterfall
win bots.

Bug: 818832,839419,843511
Change-Id: I550d01b33695bf07dea3b97a4bf6a0d8b3f404f4
Reviewed-on: https://chromium-review.googlesource.com/1099135
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567353}
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/chromium.win.json
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/17d2fcddb075392bca05aa48c659afbc47c33432/testing/buildbot/waterfalls.pyl

Project Member

Comment 84 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/109dd75044f5780926c76cbf80dd809987728d25

commit 109dd75044f5780926c76cbf80dd809987728d25
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 15 13:56:30 2018

mac: Let ToTMac bot run webkit layout tests on macOS 10.12 swarming machines.

When the chromium.clang waterfall was converted to have its json files
autogenerated in https://chromium-review.googlesource.com/c/chromium/src/+/818075
ToTMac was the only bot that ran

  'isolated_scripts': 'chromium_isolated_scripts',

in waterfalls.pyl (to get telemetry tests and crash tests).
chromium_isolated_scripts also includes webkit_layout_tests, but until
https://chromium-review.googlesource.com/c/chromium/src/+/1060293 it was
excluded on ToTMac. Since that CL landed, ToTMac is the only tot bot running
layout tests. (We should probably add chromium_isolated_scripts to the other
bots too.)

It looks like layout tests don't fully pass on macOS 10.13 yet, so pin them to
10.12 swarming slaves, like the Mac10.13 Tests bot does.

Bug: 843511
Change-Id: I92c02169e49dd9cce729e32f200149e6bceb5eb7
Reviewed-on: https://chromium-review.googlesource.com/1102478
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567629}
[modify] https://crrev.com/109dd75044f5780926c76cbf80dd809987728d25/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/109dd75044f5780926c76cbf80dd809987728d25/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 853172
Blockedon: 853716
Project Member

Comment 87 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22702c011d523536e318abbabe0a8066222458d1

commit 22702c011d523536e318abbabe0a8066222458d1
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 18 17:11:58 2018

Run accessibility_unittests on mac asan.

They seem to pass.

Bug: 843511
Change-Id: I7e52d8cc7301d4d3bc87e03242124ce1b22c0000
Reviewed-on: https://chromium-review.googlesource.com/1104797
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568047}
[modify] https://crrev.com/22702c011d523536e318abbabe0a8066222458d1/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/22702c011d523536e318abbabe0a8066222458d1/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 88 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711f95717f9b78b143b9f2eb76d38eab1ebd343a

commit 711f95717f9b78b143b9f2eb76d38eab1ebd343a
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 18 17:36:31 2018

Run extensions_browsertests on the tsan, cros asan memory bots.

They pass and doesn't take long to run, no reason to not run them.

Bug: 843511
Change-Id: I7e54348c8e80224df96adfe17493ca7af0521e72
Reviewed-on: https://chromium-review.googlesource.com/1104737
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568057}
[modify] https://crrev.com/711f95717f9b78b143b9f2eb76d38eab1ebd343a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/711f95717f9b78b143b9f2eb76d38eab1ebd343a/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 853838
Project Member

Comment 90 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b67a403c28b15d662f4c1eb1feb1d269fb6de12

commit 6b67a403c28b15d662f4c1eb1feb1d269fb6de12
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 18 21:45:01 2018

Remove viz_gtests, move these tests into non_android_chromium_gtests.

Simplifies the config, and fixes an oversight were the tests were running
on the regular cros bots, but not on the cros memory bots.

Bug: 843511
Change-Id: I751ead56fca4adec28b991243a03cc516417ca3f
Reviewed-on: https://chromium-review.googlesource.com/1104799
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568175}
[modify] https://crrev.com/6b67a403c28b15d662f4c1eb1feb1d269fb6de12/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/6b67a403c28b15d662f4c1eb1feb1d269fb6de12/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/6b67a403c28b15d662f4c1eb1feb1d269fb6de12/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/6b67a403c28b15d662f4c1eb1feb1d269fb6de12/testing/buildbot/test_suites.pyl

Project Member

Comment 91 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96a75a6940e545961d8dc3f7df4afafc1c442ee3

commit 96a75a6940e545961d8dc3f7df4afafc1c442ee3
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 20 04:53:17 2018

Run interactive_ui_tests on the tsan bot.

TBR=jbudorick

Bug:  455679 ,843511
Change-Id: I716eaad2c98521978d25ee5b0bf00d57534eb19c
Reviewed-on: https://chromium-review.googlesource.com/1104803
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568728}
[modify] https://crrev.com/96a75a6940e545961d8dc3f7df4afafc1c442ee3/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/96a75a6940e545961d8dc3f7df4afafc1c442ee3/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 455679
Project Member

Comment 93 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/073af19d974878c2b620f5e471977d5ffb4983d6

commit 073af19d974878c2b620f5e471977d5ffb4983d6
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 21 19:22:17 2018

Remove chromium_memory_linux_asan_gtests in favor of chromium_linux_and_gl_gtests.

The test lists are almost identical, except that chromium_linux_and_gl_gtests
also includes network_service_gtests, site_isolation_chromium_gtests, and
site_isolation_chromium_linux_gtests.

This has the effect of adding various test binaries (browser_tests etc) in
network_service and (not_)site_isolation mode to the memory bots.
To not overload swarming, suppress these tests on the bots that are in the
default cq.

Effectively adds these tests
- network_service_browser_tests
- not_site_per_process_browser_tests
- network_service_components_browsertests
- site_per_process_components_browsertests
- site_per_process_components_unittests
- network_service_content_browsertests
- site_per_process_content_browsertests
- site_per_process_content_unittests
- network_service_extensions_browsertests
- site_per_process_extensions_browsertests
- network_service_interactive_ui_tests
- not_site_per_process_interactive_ui_tests
- not_site_per_process_sync_integration_tests
- not_site_per_process_unit_tests

to these bots:
- Linux CFI
- Linux MSan Tests

Bug: 843511
Change-Id: I8fdfff7f48301d115c7e5aec7530fe9f9ff250a5
Reviewed-on: https://chromium-review.googlesource.com/1110151
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569351}
[modify] https://crrev.com/073af19d974878c2b620f5e471977d5ffb4983d6/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/073af19d974878c2b620f5e471977d5ffb4983d6/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/073af19d974878c2b620f5e471977d5ffb4983d6/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/073af19d974878c2b620f5e471977d5ffb4983d6/testing/buildbot/waterfalls.pyl

Project Member

Comment 94 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef585dfb4f360df022f391af121bdfb2929cb83

commit 6ef585dfb4f360df022f391af121bdfb2929cb83
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 21 22:57:29 2018

Remove chromium_mac_fyi_gtests suite, run regular chromium_mac_gtests suite on the mac FYI bots.

This makes the fyi bots run viz_gtests instead of viz_fyi_gtests which removes
a few test binaries, but since those weren't run on any other desktop bot,
it probably wasn't intentional that they run on mac anyways.

Bug: 843511
Change-Id: Ieb132304f3e6b3869c1c2238ec509ed5a95174ab
Reviewed-on: https://chromium-review.googlesource.com/1108360
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569400}
[modify] https://crrev.com/6ef585dfb4f360df022f391af121bdfb2929cb83/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/6ef585dfb4f360df022f391af121bdfb2929cb83/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/6ef585dfb4f360df022f391af121bdfb2929cb83/testing/buildbot/waterfalls.pyl

Project Member

Comment 95 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ce69791b27861457b63dd3e835ef2eb3c8916a

commit a0ce69791b27861457b63dd3e835ef2eb3c8916a
Author: jonross <jonross@chromium.org>
Date: Fri Jun 22 01:29:43 2018

Remove surface_sync tests from all non-Android configs

Except on Android, surface sync (--enable-surface-synchronization) is on by
default. So keeping tests of it around are actually redundant.

This removes them from all configs except for 'viz_fyi_android_gtests' where we
want coverage to find bugs until we are ready to ship on Android.

TEST=surface_sync_browser_tests, surface_sync_content_browsertests

Bug: 843511
Change-Id: Icabccb7427c62844b9e56df1628e13f04d4b759a
Reviewed-on: https://chromium-review.googlesource.com/1111098
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569493}
[modify] https://crrev.com/a0ce69791b27861457b63dd3e835ef2eb3c8916a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a0ce69791b27861457b63dd3e835ef2eb3c8916a/testing/buildbot/test_suites.pyl

Blockedon: 855573
Blockedon: 855580
Blockedon: 855583
Blockedon: 855584
Blockedon: 855585
Blockedon: 855588
Blockedon: 855642
Project Member

Comment 103 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65338c09a5e9cbf8eae281d52eefc14182e58a8a

commit 65338c09a5e9cbf8eae281d52eefc14182e58a8a
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 22 19:13:40 2018

Enable more tests on the cros memory bots.

The motivation is to remove chromium_memory_chromiumos_asan_gtests in favor
of linux_chromeos_rel_gtests, but when I tried doing that directly [1], I got
many asan/lsan and msan reports for these tests. Some of them pass however,
so I'd like to lock in the working ones while I work on fixing the broken ones.

1: https://chromium-review.googlesource.com/c/chromium/src/+/1110703

Adds to "Linux ChromiumOS MSan Tests" and "Linux Chromium OS ASan LSan Tests (1)" these tests:
- chromevox_tests
- gl_unittests_ozone (to asan/lsan only)
- ozone_gl_unittests
- ozone_x11_unittests
- select_to_speak_extension_tests
- views_mus_interactive_ui_tests

Bug: 843511
Bug:  855573 , 855580 , 855588 
Bug:  855584 , 855585 , 855583 
Change-Id: I9402cd43d1d0ef95432eba8231ae79c936b4848b
Reviewed-on: https://chromium-review.googlesource.com/1112037
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569725}
[modify] https://crrev.com/65338c09a5e9cbf8eae281d52eefc14182e58a8a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/65338c09a5e9cbf8eae281d52eefc14182e58a8a/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/65338c09a5e9cbf8eae281d52eefc14182e58a8a/testing/buildbot/test_suites.pyl

Project Member

Comment 104 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e

commit 5ecf35f1ab2a0a4e2fda04595383231c251f8a9e
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 25 01:50:22 2018

Enable more tests on the cros memory bots.

Enable views_mus_unittests on both lsan/asan and on msan, it should pass now.

Enable ozone_unittests and wayland_client_perftests on just msan
(they don't pass on lsan/asan yet).

With this, linux_chromeos_rel_specific_gtests_asan_bringup is identical to
linux_chromeos_rel_specific_gtests and can be removed, and because of _that_,
chromium_memory_chromiumos_asan_gtests is identical to linux_chromeos_rel_gtests
and can also be removed.

As a consequence, tests added to the cros rel bots will be added to the
memory bots automatically going forward.

TBR=kbr

Bug: 843511
Bug:  855580 , 855588 , 855584 , 855585 , 855583 
Change-Id: I6a28ebae4c9005ce508f8caef07679a1bb50285c
Reviewed-on: https://chromium-review.googlesource.com/1112957
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569949}
[modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/waterfalls.pyl

Project Member

Comment 105 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6debbd51e662012ec6b0da45e73146d7edd0c5

commit aa6debbd51e662012ec6b0da45e73146d7edd0c5
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 27 14:57:07 2018

Run interactive_ui_tests on ubsan bots.

The one test that used to fail seems to pass now.

Bug:  815190 ,843511
Change-Id: I2e77719aa557b2055209d58dcb3c124bc0ad2576
Reviewed-on: https://chromium-review.googlesource.com/1116899
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570770}
[modify] https://crrev.com/aa6debbd51e662012ec6b0da45e73146d7edd0c5/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/aa6debbd51e662012ec6b0da45e73146d7edd0c5/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 106 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8945fbfb6a1442637570676ecc6481cdc9876061

commit 8945fbfb6a1442637570676ecc6481cdc9876061
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 27 14:58:03 2018

Run browser_tests on ubsan bots.

Not clear why it wasn't running, and network_service_browser_tests,
not_site_per_process_browser_tests, viz_browser_tests already all run and
pass -- and what's better than running browser_tests three times? Running it
four times, so add vanilla browser_tests too.

Bug: 843511
Change-Id: I682375c0c4a5a673a0e5410452d5560cad3ccebd
Reviewed-on: https://chromium-review.googlesource.com/1117019
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570771}
[modify] https://crrev.com/8945fbfb6a1442637570676ecc6481cdc9876061/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/8945fbfb6a1442637570676ecc6481cdc9876061/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 107 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081d3c19543b25154970b51e6512fe242b4f9b57

commit 081d3c19543b25154970b51e6512fe242b4f9b57
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 28 23:36:58 2018

Run wayland_client_perftests on the cros asan bot.

The leak is now fixed.

Bug:  855583 ,843511
Change-Id: Id8367b404108467783ac5e2c8c186b7ba210df4f
Reviewed-on: https://chromium-review.googlesource.com/1117611
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571325}
[modify] https://crrev.com/081d3c19543b25154970b51e6512fe242b4f9b57/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/081d3c19543b25154970b51e6512fe242b4f9b57/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 108 by bugdroid1@chromium.org, Jun 29 2018

Project Member

Comment 109 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee124a002ac971c60330eaac0a5c064dbc1107b9

commit ee124a002ac971c60330eaac0a5c064dbc1107b9
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 29 15:49:28 2018

Run extensions_browsertests on mac asan bot.

It should pass now.

Bug: 843511, 853172 
Change-Id: Ibb9b8add16581a2b63fbef38918d366444fb98e4
Reviewed-on: https://chromium-review.googlesource.com/1120226
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571492}
[modify] https://crrev.com/ee124a002ac971c60330eaac0a5c064dbc1107b9/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/ee124a002ac971c60330eaac0a5c064dbc1107b9/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 110 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2569729d58f4d04cbf60eaf2f5c8240b38b6171

commit c2569729d58f4d04cbf60eaf2f5c8240b38b6171
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 29 15:57:45 2018

Run zucchini_unittests on "Win10 Tests x64"

It's not clear why this should run on all bots except this one.

Bug: 843511
Change-Id: I354c78445c1f64de2b8bf27f18fd60a2081fd726
Reviewed-on: https://chromium-review.googlesource.com/1120229
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571495}
[modify] https://crrev.com/c2569729d58f4d04cbf60eaf2f5c8240b38b6171/testing/buildbot/chromium.win.json
[modify] https://crrev.com/c2569729d58f4d04cbf60eaf2f5c8240b38b6171/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 111 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b739d6b77d18431d7bb54ac14c645c90e1e9507

commit 5b739d6b77d18431d7bb54ac14c645c90e1e9507
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 29 18:42:15 2018

Remove test suppressions for mac-views-rel and "Chromium Mac 10.13".

It's not clear why these suppressions exist. (It's not even clear if these
bots should still exist since their configs are on the main waterfall too
nowadays -- I'm asking around if I can remove them completely, but that's
for a different CL.)

Bug: 843511
Change-Id: I40bedd29065dba896455821ef58a3ffbe50435b4
Reviewed-on: https://chromium-review.googlesource.com/1120231
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571566}
[modify] https://crrev.com/5b739d6b77d18431d7bb54ac14c645c90e1e9507/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/5b739d6b77d18431d7bb54ac14c645c90e1e9507/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 112 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8e6d828e89e396c1fc9e0e2dc78c206adbd2a06

commit a8e6d828e89e396c1fc9e0e2dc78c206adbd2a06
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 29 18:55:18 2018

Remove test exceptions for 'Win 10 Fast Ring' bot.

The currently disabled set of tests on that bot is fairly arbitrary. Since
the bot is currently red anyway and has been for a while (see 2nd bug), let's
run all tests there, and when we get around to greening it up we can then
disable suites that turn out to be unamenable to fixing. It likely won't be
the suites that are currently disabled.

Bug: 843511,851705
Change-Id: Ifabc504fe56ebdbdab32609055cdaf39d8d73d11
Reviewed-on: https://chromium-review.googlesource.com/1120227
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571571}
[modify] https://crrev.com/a8e6d828e89e396c1fc9e0e2dc78c206adbd2a06/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a8e6d828e89e396c1fc9e0e2dc78c206adbd2a06/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 113 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5296cb77eccd89a3591115c694b58205203e43b

commit d5296cb77eccd89a3591115c694b58205203e43b
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 29 18:56:44 2018

Enable content_shell_crash_test on many bots.

On most bots, we don't know why the test is disabled. Worst case, we'll find
out and redisable it on bots where it doesn't yet work for some reason.

On Mac 10.13 and Win 7, we do know why it's disabled, but the Win 7 bug
has been fixed, and the 10.13 bug was spurious and I have put in better
debug logging if it were to fail again, and I haven't seen any failures in
the last 200 builds on the main waterfall.

Bug:  846729 ,813163,843511
Change-Id: Ibd14dea1c5fb72bc4d298b53f55e87be05aa211e
Reviewed-on: https://chromium-review.googlesource.com/1120225
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571572}
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/d5296cb77eccd89a3591115c694b58205203e43b/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 114 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29bc3495db9c78a0a0830e6fea75b135ec10d15e

commit 29bc3495db9c78a0a0830e6fea75b135ec10d15e
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 30 02:39:05 2018

Remove unused exceptions.

Found by a marginally improved version of
https://chromium-review.googlesource.com/c/chromium/src/+/1097616 , see
patch set 4 there.

Bug: 843511
Change-Id: I591567c66f6afa63853e23112fcf432fa61006a0
Reviewed-on: https://chromium-review.googlesource.com/1120752
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571744}
[modify] https://crrev.com/29bc3495db9c78a0a0830e6fea75b135ec10d15e/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 115 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e16ace284668951c6e28d60ffc224a426268eb

commit 81e16ace284668951c6e28d60ffc224a426268eb
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 30 02:58:47 2018

Re-disable content_shell_crash_test on Linux Tests (dbg)(1)(32).

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1120225,
the test doesn't pass on the 32-bit linux dbg bot.

TBR=kbr

Bug: 859264,843511
Change-Id: I99ddef5bc637444ccb0023df528123f14bee0fed
Reviewed-on: https://chromium-review.googlesource.com/1121521
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571746}
[modify] https://crrev.com/81e16ace284668951c6e28d60ffc224a426268eb/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/81e16ace284668951c6e28d60ffc224a426268eb/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 116 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16676313c5a9429b329d995338782df104c6f79e

commit 16676313c5a9429b329d995338782df104c6f79e
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 30 03:04:44 2018

Run cast_unittests, cc_unittests, chromedriver_unittests, components_browsertests, snapshot_unittests on the cros bots.

Also run printing_unittests on the cros dbg bot (it's already running on the rel bot).

These tests already run and pass on the cros memory bots, so it's not clear
why they shouldn't run on the regular cros bots.

Bug: 843511
Change-Id: Ia845a7477fcab01bbb8df257585cbde4463a9e8c
Reviewed-on: https://chromium-review.googlesource.com/1120232
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571747}
[modify] https://crrev.com/16676313c5a9429b329d995338782df104c6f79e/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/16676313c5a9429b329d995338782df104c6f79e/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 118 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc66e1cabf73611a7b5d6aeacb097f7094645f2

commit fcc66e1cabf73611a7b5d6aeacb097f7094645f2
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sun Jul 01 00:15:13 2018

Revert "Remove several test suppressions where it is not clear why they exist."

This reverts commit 774a04848a634b053c5539b214c8878c5407d086.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 571782 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3NGEwNDg0OGE2MzRiMDUzYzU1MzliMjE0Yzg4NzhjNTQwN2QwODYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac%20Builder/88620

Sample Failed Step: compile

Original change's description:
> Remove several test suppressions where it is not clear why they exist.
> 
> If any of these fail on their bots, I'll file dedicated bugs for that
> and re-disable with a link to the bug.
> 
> Bug: 843511,830944,814403
> Change-Id: Ib1beb2fc1ffcade39535b47b25b50340131092e5
> Reviewed-on: https://chromium-review.googlesource.com/1121524
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571782}

Change-Id: I007c8f0090be2e7162f0ef32c22b04e08886067b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843511,830944,814403
Reviewed-on: https://chromium-review.googlesource.com/1121796
Cr-Commit-Position: refs/heads/master@{#571783}
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.win.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 119 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89a3c914eeeaa4bcf16196b92304853757e0584

commit e89a3c914eeeaa4bcf16196b92304853757e0584
Author: Nico Weber <thakis@chromium.org>
Date: Sun Jul 01 01:30:52 2018

Reland "Remove several test suppressions where it is not clear why they exist."

This is a reland of 774a04848a634b053c5539b214c8878c5407d086

Original change's description:
> Remove several test suppressions where it is not clear why they exist.
> 
> If any of these fail on their bots, I'll file dedicated bugs for that
> and re-disable with a link to the bug.
> 
> Bug: 843511,830944,814403
> Change-Id: Ib1beb2fc1ffcade39535b47b25b50340131092e5
> Reviewed-on: https://chromium-review.googlesource.com/1121524
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571782}

Bug: 843511, 830944, 814403
Change-Id: I8ea5586d15446108a5d18b93686f64e0c4140559
Reviewed-on: https://chromium-review.googlesource.com/1121836
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571786}
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 859325
Project Member

Comment 121 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81999ee06419ea4025f836bbbc8a11d241f449b

commit e81999ee06419ea4025f836bbbc8a11d241f449b
Author: Nico Weber <thakis@chromium.org>
Date: Sun Jul 01 23:52:43 2018

Merge linux_chromeos_dbg_gtests and linux_chromeos_rel_gtests.

We don't have different test lists for dbg and rel on any other platform.

Effectively adds a bunch of tests to the cros dbg (not a default cq bot).

Bug: 843511,859320,859307
Change-Id: I8769641d2c53401c2f26c790e5f2edf2a6bf0125
Reviewed-on: https://chromium-review.googlesource.com/1099147
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571800}
[modify] https://crrev.com/e81999ee06419ea4025f836bbbc8a11d241f449b/chrome/browser/ui/webui/webui_webview_browsertest.cc
[modify] https://crrev.com/e81999ee06419ea4025f836bbbc8a11d241f449b/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/e81999ee06419ea4025f836bbbc8a11d241f449b/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e81999ee06419ea4025f836bbbc8a11d241f449b/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e81999ee06419ea4025f836bbbc8a11d241f449b/testing/buildbot/waterfalls.pyl

Blockedon: 859503
Blockedon: 860015
Project Member

Comment 124 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf7a5e1f0f148c4dd59b2d4955389819a927f33

commit 1cf7a5e1f0f148c4dd59b2d4955389819a927f33
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 09 14:22:11 2018

Run more tests on Fuchsia bots.

Adds ipc_tests, media_unittests, sql_unittests to
the CQ fuchsia_x64 bot, where they all seem to pass.

Add comments to the net_unittests suppressions explaining why they're
there.

Also adds these tests and content_unittests to some Fuchsia FYI
bots (which don't have cq bots, so I don't know if they pass --
if not, we can disable them again).

There is no comment explaining why these are disabled, and since
they pass, let's run them.

Bug: 843511, 847915 ,844416
Change-Id: Ife31eeb61a6e505e5e2c0b9a4efeda0af34e4d9f
Reviewed-on: https://chromium-review.googlesource.com/1120753
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573299}
[modify] https://crrev.com/1cf7a5e1f0f148c4dd59b2d4955389819a927f33/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1cf7a5e1f0f148c4dd59b2d4955389819a927f33/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/1cf7a5e1f0f148c4dd59b2d4955389819a927f33/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 861753
Project Member

Comment 126 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0699ffbd329233a62163165736874c7f0fc4e354

commit 0699ffbd329233a62163165736874c7f0fc4e354
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 09 16:57:05 2018

Make USE_KERBEROS use the BUILDFLAG system, and make services/ use it.

http_auth_handler_negotiate.cc is only included if use_kerberos is set,
so its tests should only be included then too.

Since the existing USE_KERBEROS define was internal to net, use the
BUILDFLAG system to make it accessible outside of net.

use_kerberos is true on Android but the test used to not run on Android.
Maybe used should be false on Android, but for now this preserves behavior.

This makes services_unittests link on the Cast bots, enabling
https://chromium-review.googlesource.com/c/chromium/src/+/1128939

No behavior change.

Bug: 843511
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic363bcd7cac928bc323f3872d7beaa827fc9a1cc
Reviewed-on: https://chromium-review.googlesource.com/1129259
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573336}
[modify] https://crrev.com/0699ffbd329233a62163165736874c7f0fc4e354/net/BUILD.gn
[modify] https://crrev.com/0699ffbd329233a62163165736874c7f0fc4e354/net/http/http_auth_handler_factory.cc
[modify] https://crrev.com/0699ffbd329233a62163165736874c7f0fc4e354/net/http/http_auth_handler_factory_unittest.cc
[modify] https://crrev.com/0699ffbd329233a62163165736874c7f0fc4e354/net/http/http_auth_unittest.cc
[modify] https://crrev.com/0699ffbd329233a62163165736874c7f0fc4e354/services/network/network_service_unittest.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c6cbc18217bca9db34204c7ee71a14953e3897

commit c5c6cbc18217bca9db34204c7ee71a14953e3897
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 09 18:35:54 2018

Remove some test exceptions for the cast bots.

To make components_unittests link with is_chromecast=true:
- include pdf code only if enable_plugins is set (it's false both
  on android and on cast/linux, and components/pdf/renderer relies
  on plugin code)
- include linux_key_storage tests only when the code under test is
  included as well (desktop_linux && !chromecast)

Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1129259
to get services_unittests to link under cast.

Bug: 843511
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I186facb2ccc3edf11667168ccd2d7dd28863e3ae
Reviewed-on: https://chromium-review.googlesource.com/1128939
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573376}
[modify] https://crrev.com/c5c6cbc18217bca9db34204c7ee71a14953e3897/components/BUILD.gn
[modify] https://crrev.com/c5c6cbc18217bca9db34204c7ee71a14953e3897/components/os_crypt/BUILD.gn
[modify] https://crrev.com/c5c6cbc18217bca9db34204c7ee71a14953e3897/services/network/network_service_unittest.cc
[modify] https://crrev.com/c5c6cbc18217bca9db34204c7ee71a14953e3897/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c5c6cbc18217bca9db34204c7ee71a14953e3897/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 861843
Project Member

Comment 129 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25a6952a551b87abff2aa35f889876fd89257e7

commit f25a6952a551b87abff2aa35f889876fd89257e7
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 09 22:08:21 2018

Run events_unittests on mac and cast bots.

Mac doesn't have touch UI, and the test doesn't really make too much
sense on cast, but the code under test is built there and the test
is small and fast, so might as well run it. Maybe one day the test
should move to chromium_gtests_for_devices_with_graphical_output instead.

Bug: 843511
Change-Id: I792e8ed5bb419346b23a3e7432a7681e797b244d
Reviewed-on: https://chromium-review.googlesource.com/1129719
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573472}
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f25a6952a551b87abff2aa35f889876fd89257e7/testing/buildbot/test_suites.pyl

Project Member

Comment 130 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/940938e087dd3a423eb242b1c9403cad2c6443b8

commit 940938e087dd3a423eb242b1c9403cad2c6443b8
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 09 22:18:37 2018

Run ui_touch_selection_unittests on mac and cast bots.

Mac doesn't have touch UI, and the test doesn't really make too much
sense on cast, but the code under test is built there and the test
is small and fast, so might as well run it. Maybe one day the test
should move to chromium_gtests_for_devices_with_graphical_output instead.

Bug: 843511
Change-Id: I1792ee0d57a9f039dba71bb6b28d33e272ab5236
Reviewed-on: https://chromium-review.googlesource.com/1129580
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573484}
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/940938e087dd3a423eb242b1c9403cad2c6443b8/testing/buildbot/test_suites.pyl

Project Member

Comment 131 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38e8cee299e5a6430840b52bb1693a78eceadbb

commit f38e8cee299e5a6430840b52bb1693a78eceadbb
Author: Nico Weber <thakis@chromium.org>
Date: Tue Jul 10 00:13:11 2018

Run latency_unittests on mac and cast bots.

I don't know what ui/latency does, but the test is small and builds
and runs fine, so just run it.

Also remove now-empty and currently-unused non_mac_chromium_gtests.

Bug: 843511
Change-Id: I71abcab45133bb235f268f34e4df6097758867d4
Reviewed-on: https://chromium-review.googlesource.com/1129680
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573544}
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f38e8cee299e5a6430840b52bb1693a78eceadbb/testing/buildbot/test_suites.pyl

Blockedon: 862581
Project Member

Comment 134 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465e6fd64fc7ca93c23a8f2339157071c624acb4

commit 465e6fd64fc7ca93c23a8f2339157071c624acb4
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jul 11 18:05:34 2018

Run cast_unittests on ToTAndroidCFI and ToTLinuxThinLTO.

(It already runs on the non-ToT bots.)

Also add a comment explaining why chrome_public_test_apk doesn't yet
run on the Android CFI bots.

Bug: 843511
Change-Id: I354cb867c15f3e8b3d36968cf4ca36cf389c25a5
Reviewed-on: https://chromium-review.googlesource.com/1132406
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574245}
[modify] https://crrev.com/465e6fd64fc7ca93c23a8f2339157071c624acb4/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/465e6fd64fc7ca93c23a8f2339157071c624acb4/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 136 by bugdroid1@chromium.org, Jul 12

Blockedon: 863167
Project Member

Comment 138 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fe3e2bdddbfe8fa52b14ca6936cea96b5b55050

commit 0fe3e2bdddbfe8fa52b14ca6936cea96b5b55050
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 18:33:27 2018

Remove args key_removal for android.fyi bots.

These sections have been around since the json files started being autogenerated.
Not all _apk targets have key_removal sections, and the ones that do have
different bots listed there.

Omitting args probably isn't important, so don't do it.

Bug: 843511
Change-Id: I42c2e0bb03d28d850bb447c62e21df62ed33eafd
Reviewed-on: https://chromium-review.googlesource.com/1136516
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574989}
[modify] https://crrev.com/0fe3e2bdddbfe8fa52b14ca6936cea96b5b55050/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/0fe3e2bdddbfe8fa52b14ca6936cea96b5b55050/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 139 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0b3f58609945fc80e54e891af27cf220749c2f9

commit b0b3f58609945fc80e54e891af27cf220749c2f9
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 18:45:15 2018

Test json generation script: Remove support for remove_gtest_from.

It no longer does anything that remove_from can't do.  No behavior change.

Bug: 843511
Change-Id: I74d3e52d7a9d00271baad9203d72ba7efc777a64
Reviewed-on: https://chromium-review.googlesource.com/1136646
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574995}
[modify] https://crrev.com/b0b3f58609945fc80e54e891af27cf220749c2f9/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/b0b3f58609945fc80e54e891af27cf220749c2f9/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 140 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7176cbed6e30bb75cb0f28e53b07aed63ccf48

commit 2a7176cbed6e30bb75cb0f28e53b07aed63ccf48
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 19:16:55 2018

Run blink_platform_unittests on android-kitkat-arm-rel, android-marshmallow-arm64-rel.

It's a fairly simple test, it already runs on most Android bots, and it's not
clear why it doesn't run on those too. Worst case, we'll find out and re-disable.

Bug: 843511
Change-Id: Id1fc932cb3b1599285524e1701602077bbc3d65a
Reviewed-on: https://chromium-review.googlesource.com/1136643
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575010}
[modify] https://crrev.com/2a7176cbed6e30bb75cb0f28e53b07aed63ccf48/testing/buildbot/chromium.android.json
[modify] https://crrev.com/2a7176cbed6e30bb75cb0f28e53b07aed63ccf48/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 141 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/063d1eb01b0700ab4d2910f90272a313838e987b

commit 063d1eb01b0700ab4d2910f90272a313838e987b
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 19:17:18 2018

Stop passing --test-launcher-print-test-stdio=always to sandbox_linux_unittests on 4 bots.

If we always want the output, we should add the flag in testing/buildbot/gn_isolate_map.pyl
or waterfalls.pyl for all bots, and not set this for a small arbitrary subset.

Bug: 843511
Change-Id: I8a1e1f32ec22da2b02bc05ac56ecee659b4448ee
Reviewed-on: https://chromium-review.googlesource.com/1136517
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575012}
[modify] https://crrev.com/063d1eb01b0700ab4d2910f90272a313838e987b/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/063d1eb01b0700ab4d2910f90272a313838e987b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/063d1eb01b0700ab4d2910f90272a313838e987b/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 142 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79dc5f685c8c95a59c9758ae397d257f87c99c75

commit 79dc5f685c8c95a59c9758ae397d257f87c99c75
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 19:38:49 2018

Test json generation script: Remove two more now-unneeded features.

- Remove support for 'key_removals', which is unused after
  https://chromium-review.googlesource.com/c/1136516/
-- As a knock-on effect, update_and_cleanup_test() can now no longer
   throw, so remove several try:/except: blocks to keep the coverage
   script happy.
- Remove support for having "$bot_name $waterfall_name" in
  'modifications' since that's no longer needed and there was a TODO
  about removing it already.

Bug: 843511
Change-Id: I2d9d89e60ad404f78c97f448db017091b4d18b57
Reviewed-on: https://chromium-review.googlesource.com/1136893
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575022}
[modify] https://crrev.com/79dc5f685c8c95a59c9758ae397d257f87c99c75/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/79dc5f685c8c95a59c9758ae397d257f87c99c75/testing/buildbot/generate_buildbot_json_unittest.py

Project Member

Comment 143 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e053d81f7d7c52271ce661698174535bfbbc258

commit 8e053d81f7d7c52271ce661698174535bfbbc258
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 13 22:21:43 2018

Run a few more tests where it's not clear why they don't run.

- Run components_browsertests on 32-bit linux dbg main waterfall bot,
  and on the win7 and win10 dbg main waterfall bots. If the tests
  end up failing there, we can re-disable them with a link to a bug
  explaining what exactly fails.

- Run mash_unittests on the fyi Mojo ChromiumOS bot
  (suite takes seconds to run).

Bug: 843511
Change-Id: I6b529723300ade97712e5e360dfddff8d8d64c40
Reviewed-on: https://chromium-review.googlesource.com/1136464
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575091}
[modify] https://crrev.com/8e053d81f7d7c52271ce661698174535bfbbc258/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8e053d81f7d7c52271ce661698174535bfbbc258/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/8e053d81f7d7c52271ce661698174535bfbbc258/testing/buildbot/chromium.win.json
[modify] https://crrev.com/8e053d81f7d7c52271ce661698174535bfbbc258/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 863886
Project Member

Comment 145 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f192ef82940146e3b07f510b2a61e70bc04b7bd

commit 6f192ef82940146e3b07f510b2a61e70bc04b7bd
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 16 17:11:38 2018

Run traffic_annotation_auditor_unittests on more bots

- Add mac to TrafficAnnotationExporter's all_supported_platforms_
  to fix a DCHECK when running the tests on mac
- Move the test binary to non_android_chromium_gtests to run it
  on all desktop bots
- Remove exceptions to not run the test on swarming on one bot (it
  already runs fine on swarming on other bots) and to not run it on
  two main waterfall dbg bots
- linux_specific_chromium_gtests is now empty, so remove it

Bug: 843511
Change-Id: Ic350a65039ce4111c868b64f416458b35b6bcfbb
Reviewed-on: https://chromium-review.googlesource.com/1138253
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575317}
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/chromium.win.json
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/6f192ef82940146e3b07f510b2a61e70bc04b7bd/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc

Project Member

Comment 146 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d4d0331a15e11f7d6ca819ca28521f24ca4647f

commit 0d4d0331a15e11f7d6ca819ca28521f24ca4647f
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 16 17:51:50 2018

Move unit_tests from chromium_gtests to chromium_gtests_for_devices_with_graphical_output.

chromium_gtests_for_devices_with_graphical_output means "not cast".
The cast build doesn't include anything at the //chrome level, and
unit_tests lives at the //chrome level.

Currently we have unit_tests in chromium_gtests which runs on all bots,
and then an exception to remove it again on the cast bots.

Instead, put it in chromium_gtests_for_devices_with_graphical_output so that
it only runs on non-cast bots in the first place.

(It also ends up removing unit_tests from linux-blink-heap-incremental-marking
and linux-blink-heap-verification on the fyi waterfall, since these bots run
chromium_gtests instead of chromium_linux_gtests -- that looks like a bot
config bug, but it's only FYI bots anyways.)

This removes the last "unclear why" comment from test_suite*.pyl!

Bug: 843511, 817779 , 812533 
Change-Id: I76e0a2b30e0ca87c02c73cb46d8135d9ab7030d8
Reviewed-on: https://chromium-review.googlesource.com/1138333
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575339}
[modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/test_suites.pyl

Project Member

Comment 147 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a58c21c4db5ac21a326b9cfed4c55704b94bf33

commit 4a58c21c4db5ac21a326b9cfed4c55704b94bf33
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 16 18:35:25 2018

Enable three more tests.

- gin_unittests on "Linux - Future (dbg)"
- unit_tests on "Win10 Tests x64 (dbg)"
- telemetry_unittests on "Win10 Tests x64 (dbg)"

Bug: 843511
Change-Id: Iabd54c3330a25b14d0bf4773e4862bfa5d10aabb
Reviewed-on: https://chromium-review.googlesource.com/1138254
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575359}
[modify] https://crrev.com/4a58c21c4db5ac21a326b9cfed4c55704b94bf33/testing/buildbot/chromium.win.json
[modify] https://crrev.com/4a58c21c4db5ac21a326b9cfed4c55704b94bf33/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/4a58c21c4db5ac21a326b9cfed4c55704b94bf33/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 148 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f3039f96b32a43a2046b23a8d56dae04dff800

commit 02f3039f96b32a43a2046b23a8d56dae04dff800
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 16 18:39:43 2018

Run content_browsertests on swarming on the cast bots.

content_browsertests takes almost 7 minutes to run and is currently on the
critical path of the bot since it's not swarmed, so this should reduce
the cycle time of cast_shell_linux by almost 7 minutes.

Bug: 843511, 861843 
Change-Id: I95dc87ca2b844b2bf0363b4a8b1915aeaed30938
Reviewed-on: https://chromium-review.googlesource.com/1129042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575360}
[modify] https://crrev.com/02f3039f96b32a43a2046b23a8d56dae04dff800/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/02f3039f96b32a43a2046b23a8d56dae04dff800/testing/buildbot/test_suite_exceptions.pyl

Things are in a pretty good shape now, at least a much better one than before this bug.

Before we started, test_suites.pyl 2358 lines: https://chromium.googlesource.com/chromium/src/+/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/test_suites.pyl#2358

And there were different test suite lists for linux, asan, msan, mac, win, linux_clang, win_clang, mac_clang, android, android_clang, chromeos_dbg, chromeos_rel, win_fyi, mac_fyi, android_fyi, linux_fyi, and one composite test suite for example looked like this:

  'chromium_linux_gtests': [
    'aura_gtests',
    'aura_non_clang_gtests',
    'chromium_gtests',
    'chromium_gtests_for_devices_with_graphical_output',
    'chromium_gtests_for_linux_and_chromeos_only',
    'chromium_gtests_for_non_clang_and_fyi_mac_win_devices_with_graphical_output',
    'chromium_gtests_for_non_clang_win_devices_with_graphical_output',
    'linux_and_mac_non_clang_specific_chromium_gtests',
    'linux_flavor_specific_chromium_gtests',
    'linux_incl_clang_specific_chromium_gtests',
    'linux_specific_chromium_gtests',
    'network_service_gtests',
    'non_android_chromium_gtests',
    'non_android_and_cast_chromium_gtests',
    'non_android_and_cast_and_chromeos_and_clang_android_mac_win_chromium_gtests',
    'non_android_and_cast_and_chromeos_chromium_gtests',
    'non_android_and_cast_and_chromeos_and_clang_and_mac_fyi_chromium_gtests',
    'non_android_and_clang_linux_mac_chromium_gtests',
    'non_android_and_clang_linux_mac_win_chromium_gtests',
    'non_android_and_clang_linux_win_chromium_gtests',
    'non_android_and_clang_mac_win_chromium_gtests',
    'non_android_and_clang_win_chromium_gtests',
    'non_clang_and_mac_fyi_chromium_gtests',
    'non_clang_mac_win_chromium_gtests',
    'non_clang_win_chromium_gtests',
    'non_mac_non_clang_win_chromium_gtests',
    'site_isolation_chromium_gtests',
    'site_isolation_chromium_linux_gtests',
    'viz_gtests',
    'vr_platform_specific_non_clang_win_chromium_gtests',
  ]


Now the file is 2679 lines (https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/test_suites.pyl#2679) -- see below, 888 lines moved in from elsewhere, so it's a 300 line or so net reduction, and there are test suite lists for linux, mac, win, android, chromeos. (asan/linux and msan use the linux test list, mac/asan the mac test list, the clang and non-clang test lists are identical, chromeos release and debug got merged), and the fyi bots currently mostly use the regular test lists. One composite suite for example looks like so:

  'chromium_linux_gtests': [
    'aura_gtests',
    'chromium_gtests',
    'chromium_gtests_for_devices_with_graphical_output',
    'chromium_gtests_for_linux_and_chromeos_only',
    'linux_flavor_specific_chromium_gtests',
    'network_service_gtests',
    'non_android_chromium_gtests',
    'non_android_and_cast_and_chromeos_chromium_gtests',
    'site_isolation_chromium_gtests',
    'site_isolation_chromium_linux_gtests',
    'vr_platform_specific_chromium_gtests',
  ],

Many many of the non-composite lists got merged together. This makes it much more likely that if someone adds a new test, it will automatically run on all bots, including memory and clang tot bots. (People adding a test on just e.g. the main waterfall linux bot but not on asan and msan used to be an issue). This added many tests to many bots, increasing test coverage across platforms.


test_suite_exceptions.pyl used to be over 4000 lines (https://chromium.googlesource.com/chromium/src/+/92d63896e496e23dcbedacd873fc37b8be8a5df6/testing/buildbot/test_suite_exceptions.pyl#4083) and many of the exceptions were annotated "it's unclear why this is here" and most other exceptions didn't have any comments for why that exception existed. Now it's 1741 lines: https://chromium.googlesource.com/chromium/src/+/508cc6b13b28f73f80fbfd019b83786cfac23970/testing/buildbot/test_suite_exceptions.pyl#1741 And most exceptions have a comment explaining why it's there, and a link to a tracking bug (see e.g. headless tests not running on tsan and asan due to the tests being racy and leaky. The headless team is now aware of this and will fix and enable -- and there are several more examples, see blocking and 'blocked on' bugs linked to from this bug. Notable: interactive_ui_tests now runs under tsan, meaning browser_tests might be feasible soon -- issue 368525. And sync_integration_tests likely only needs a protobuf roll to pass under tsan,  issue 852002 ).

Due to the many removals and regularizations, we could even remove a few options from the generate_buildbot_json.py script that are no longer needed.


In practice, this means:
- Way more test binaries run on way more bots (I want to write a small script to quantify this)
-- shoutout to hans who added many test binaries to the android bots in particular on  issue 842698 
- Adding new test binaries correctly is now much easier
- test_suite_exceptions.pyl is hopefully much easier to navigate
- test_suites.pyl is somewhat easier to navigate, but together with the addition of all the gpu stuff it's still a bit more complicated than it used to be. The "regular" waterfall configs are much simpler though.

Many of the remaining exceptions are due to  issue 828031  which will hopefully be fixed eventually.

Issue 852416 is another idea that could reduce size of this file more.

There are a few more small possible cleanups. telemetry_perf_unittests has a few remove_from entries I'm not sure are needed. There are several "experiment_percentage: 100" lines that have been there for a long time; we should probably make our mind up about them.

The last bigger open issue is the handling of tests that need GPU access on Linux. gl_tests and gl_unittests currently only run on android and linux memory (on the normal waterfall; I don't understand the story on the GPU waterfalls). MSan needs instrumentation of everything, so they're disabled on the msan bot because the gl driver isn't instrumented (same for gl_unittests_ozone on the cros msan bot). The lsan bot explicitly runs the tests on bots with GPUs. The CFI bots instead have an exception for gl_unittests and don't run them, but they run on GPUs for gl_tests. In the same vein, services_unittests has a single test needing a gpu and because of that the whole suite is disabled under msan (issue 831676). https://chromium-review.googlesource.com/c/chromium/src/+/1093062/1/testing/buildbot/test_suites.pyl#2405 has some more words on this, and issue 851092 and  issue 849868  and  issue 830659  and issue 815183 and  issue 814099  are all related to this.

I'm not sure if I want to do any of the remaining things

(kbr's https://chromium-review.googlesource.com/c/chromium/src/+/1067132 merged the gpu script into the global one -- +2767  -3192 lines total, but it moved 165 lines into testing/buildbot/test_suite_exceptions.pyl and 888 into test_suites.pyl.)
Project Member

Comment 150 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b23164fb92716ee24c91f0f5e0497e90110cb5d

commit 9b23164fb92716ee24c91f0f5e0497e90110cb5d
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jul 19 20:15:11 2018

Remove android-specific hard_timeout swarming settings from tests.

Like https://chromium-review.googlesource.com/c/chromium/src/+/1134531,
but for test_suites.pyl instead of test_suite_expectations.pyl

If we want this, we should set it consistently for all platforms,
not just android.

Bug: 843511
Change-Id: I8f433dacb5d6cff3f4210d5bd1f5f3c6c91a18c9
Reviewed-on: https://chromium-review.googlesource.com/1143694
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576600}
[modify] https://crrev.com/9b23164fb92716ee24c91f0f5e0497e90110cb5d/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/9b23164fb92716ee24c91f0f5e0497e90110cb5d/testing/buildbot/chromium.android.json
[modify] https://crrev.com/9b23164fb92716ee24c91f0f5e0497e90110cb5d/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/9b23164fb92716ee24c91f0f5e0497e90110cb5d/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/9b23164fb92716ee24c91f0f5e0497e90110cb5d/testing/buildbot/test_suites.pyl

Project Member

Comment 152 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441

commit f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 13:32:59 2018

Disable the two blink_heap_unittests that fail under tsan and run suite on tsan bot.

Disables HeapTest.CrossThreadWeakPersistent and HeapTest.ThreadedStrongification
under TSan.

Bug: 843511,915200,831674, 913704 
Change-Id: I6ab71b83fa937f739a57452a97bd43ef6375bf2c
Reviewed-on: https://chromium-review.googlesource.com/c/1377517
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616652}
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/third_party/blink/renderer/platform/heap/heap_test.cc

Project Member

Comment 153 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbc2838d0dc12de17f79bb2a760ad859fc41a76

commit 8fbc2838d0dc12de17f79bb2a760ad859fc41a76
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 16:00:57 2018

Disable the three sync_integration_tests that fail under tsan and run suite on tsan bot.

Looks like all the protobuf issues went away, maybe due to #612796.

Only some tests still fail:
- TwoClientCustomPassphraseSyncTest.ClientsCanSyncDataWhenScryptEncryptionEnabledInOne
- EnableDisableSingleClientTest.DoesNotRedownloadAfterKeepDataWithStandaloneTransport
- SingleClientDirectorySyncTest.StopThenDisableDeletesDirectory

Disable them under tsan and run the suite on the tsan bot.

Bug:  852002 ,915219,843511, 913704 
Change-Id: I862a93a4669c2dbd57ded99c9704528201f687b9
Reviewed-on: https://chromium-review.googlesource.com/c/1377327
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616693}
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/two_client_custom_passphrase_sync_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/test_suite_exceptions.pyl

Cc: kbr@chromium.org dpranke@chromium.org jbudorick@chromium.org hzl@chromium.org thakis@chromium.org
 Issue 795306  has been merged into this issue.
Showing comments 55 - 154 of 154 Older

Sign in to add a comment