New issue
Advanced search Search tips

Issue 843491 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Bus in disk_cache::BackendImpl::CreateEntryImpl

Project Member Reported by ClusterFuzz, May 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6477481910206464

Fuzzer: inferno_webbot
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Bus
Crash Address: 0x7f6abbdda65c
Crash State:
  disk_cache::BackendImpl::CreateEntryImpl
  disk_cache::BackendImpl::SyncCreateEntry
  disk_cache::BackendIO::ExecuteBackendOperation
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=531200:531201

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6477481910206464

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 16 2018

Components: Internals>Network>Cache
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 16 2018

Labels: Test-Predator-Auto-Owner
Owner: pasko@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/9e8e835a39287fceb827495ce7edd144df89030c (prerender: increase timeout for Asan).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Hmm, I wonder if there have been some changes to something the share cache does.
See also bug 840916

share -> shader
Project Member

Comment 5 by ClusterFuzz, May 24 2018

ClusterFuzz has detected this issue as fixed in range 561364:561365.

Detailed report: https://clusterfuzz.com/testcase?key=6477481910206464

Fuzzer: inferno_webbot
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Bus
Crash Address: 0x7f6abbdda65c
Crash State:
  disk_cache::BackendImpl::CreateEntryImpl
  disk_cache::BackendImpl::SyncCreateEntry
  disk_cache::BackendIO::ExecuteBackendOperation
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=531200:531201
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=561364:561365

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6477481910206464

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, May 24 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6477481910206464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by ClusterFuzz, May 24 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6477481910206464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 8 by pasko@chromium.org, May 24 2018

Assuming Predator is right at pinpointing the culprit change, then:

Increasing kTimeToLiveMinutes in c/b/prerender leads to more EntryImpl::Flush() returning false. To me this sounds like whatever happened to pnacl/shader cache recently is not relevant to this crash.

Chrome probably should not crash with "Failed to save user data", but if we remove the LOG(ERROR), the consequences for blockfile state may be even worse. Seems likely that the cache will get corrupt on the next browser start, or we'd hit a heap corruption as in issue 840916.

It is unlikely that we'd fix this internal blockfile cache problem, hence suggesting to switch shader/pnacl cache to simplecache. On the other hand, we do not intend to increase the time-to-live again, so this can wait.

morlovich: WDYT?

Sign in to add a comment