New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843453 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 832733
issue 816652



Sign in to add a comment

deploy GetBuild v2 API

Project Member Reported by no...@chromium.org, May 16 2018

Issue description

context: bug 832733
this bug is scoped to full implementation of GetBuild RPC
 

Comment 1 by no...@chromium.org, May 16 2018

Labels: buildbucket-v2

Comment 2 by no...@chromium.org, May 23 2018

Blocking: 816652
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/081f546f9fc0a26a82435a634943d59df5a8c08d

commit 081f546f9fc0a26a82435a634943d59df5a8c08d
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 17:23:09 2018

[protoutil] refactor expect_star

This is a pre-refactoring of a larger refactoring (making API more OO).
Replace _ParseContext.expect_star with a simpler "repeated".

Bug:  843453 
Change-Id: Ife3b06c010b18bafec5579b580e9ba28c0722207
Reviewed-on: https://chromium-review.googlesource.com/1071870
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/081f546f9fc0a26a82435a634943d59df5a8c08d/appengine/components/components/protoutil/field_masks.py

Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/78d62c8e29ceebd26f83018aa7d5715fa071cbaa

commit 78d62c8e29ceebd26f83018aa7d5715fa071cbaa
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 17:23:29 2018

[protoutil] Fix test method names

Make all test method names start with "test_".

TBR=vadimsh@chromium.org

Bug:  843453 
Change-Id: Ice4bb8a09c36aa4df1205a6e7119ae9cddd2f94d
Reviewed-on: https://chromium-review.googlesource.com/1072028
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/78d62c8e29ceebd26f83018aa7d5715fa071cbaa/appengine/components/components/protoutil/field_masks_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d631cc6343098a5ca6461554f40f94994e96459b

commit d631cc6343098a5ca6461554f40f94994e96459b
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 22:15:21 2018

[luci-notify] Fetch all build fields.

The field mask in RPCs must include all fields that the caller intends to
interpret. Fetch not only steps, but all Build fields.

Bug:  843453 
Change-Id: I4b3c1e816c34aaa97217b4945747517f577a8182
Reviewed-on: https://chromium-review.googlesource.com/1072628
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d631cc6343098a5ca6461554f40f94994e96459b/luci_notify/notify/pubsub.go

Comment 6 by no...@chromium.org, May 25 2018

Status: Fixed (was: Started)
this is deployed

note, however, that "Real-time info in buildbucket v2 API" is a separate  bug 843714 . This API does provide steps, but only after build completes

Sign in to add a comment