New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843451 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

App Launcher not immediately dismissed when selecting Arc and Crostini apps

Project Member Reported by timloh@chromium.org, May 16 2018

Issue description

The logic to immediately dismiss the app launcher when launching Arc and Crostini apps no longer works (i.e. the DismissView() calls in CrostiniAppItem::Activate(), ArcAppResult::Open(), ..).

I manually confirmed that this was a result of the change https://chromium-review.googlesource.com/c/chromium/src/+/1056447. hejq@, can you please take a look?
 

Comment 1 by hejq@chromium.org, May 16 2018

Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
I'll take it. I may have broken some code paths.
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30cde66f48c556315f1763f4fc75d6a0bccd64b3

commit 30cde66f48c556315f1763f4fc75d6a0bccd64b3
Author: Jiaquan He <hejq@google.com>
Date: Wed May 16 16:33:12 2018

app_list: fix app opening bug.

Regression of crrev.com/c/1056447.

Bug: 733662
Bug:  843451 
Change-Id: Ia123a20a0c6fff9ddb20697e10e8423b3f04b949
Reviewed-on: https://chromium-review.googlesource.com/1061835
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#559133}
[modify] https://crrev.com/30cde66f48c556315f1763f4fc75d6a0bccd64b3/chrome/browser/ui/app_list/app_list_client_impl.cc

Comment 3 by hejq@chromium.org, May 30 2018

Status: Fixed (was: Started)

Sign in to add a comment