New issue
Advanced search Search tips

Issue 843446 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add UMA for Drive and Team Drives fetch

Project Member Reported by sashab@chromium.org, May 16 2018

Issue description

Add UMA to record the time it takes to do various fetches for Drive for the file manager. The time it takes to sync with Drive is an important metric for us.

Split by fetch type - full fetch, delta fetch, fast fetch. Also record team drives to see if they add significant sync time overhead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86819e7d7099aa720287ff1abf46a83628e65f3

commit d86819e7d7099aa720287ff1abf46a83628e65f3
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Jun 15 02:20:18 2018

Add UMA metrics for TeamDrive full, delta and directory fetch.

UMAs already existed for full and directory fetch, so just added
a new histogram for TeamDrives.

Added UMA for delta fetch for both the default corpus and a TeamDrive.

Added expiry dates for the three UMAs.

I couldn't find an example of how to test that the correct UMAs are
being written in a C++ test, hence there's no tests.

Bug:  843446 
Change-Id: Ifd000cabc02f1b0e4cd7cf599fe83d9bfa74b8f5
Reviewed-on: https://chromium-review.googlesource.com/1092959
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567519}
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/change_list_processor_unittest.cc
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/chromeos/change_list_processor.cc
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/chromeos/change_list_processor.h
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/chromeos/directory_loader.cc
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/file_system_core_util.cc
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/components/drive/file_system_core_util.h
[modify] https://crrev.com/d86819e7d7099aa720287ff1abf46a83628e65f3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment