New issue
Advanced search Search tips

Issue 843443 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Use Fuchsia FIDL netstack services for NetworkChangeNotification

Project Member Reported by kmarshall@chromium.org, May 16 2018

Issue description

Create a NetworkChangeNotification impl for Fuchsia, now that FIDL services are available.
 
Components: Internals>PlatformIntegration
Cc: sergeyu@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e89fd73b6c6aaf6983fd4a88d520988ff928a61

commit 3e89fd73b6c6aaf6983fd4a88d520988ff928a61
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Jun 05 21:29:10 2018

Fuchsia: Implement NetworkChangeNotifierFuchsia with FIDL APIs.

This code adds Fuchsia platform implementation code for broadcasting
events on major network interface change events (IP
address changes, connectivity change, interface up/down changes, etc.)

Modified network_interfaces_fuchsia.cc to support adapters w/multiple
IPv6 addresses.

Added unit tests.


Bug:  843443 
Change-Id: Id7edc944ceef439d9c360e5d31966807f306489c
Reviewed-on: https://chromium-review.googlesource.com/1066074
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564669}
[modify] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/BUILD.gn
[add] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/base/network_change_notifier_fuchsia.cc
[add] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/base/network_change_notifier_fuchsia.h
[add] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/base/network_change_notifier_fuchsia_unittest.cc
[modify] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/base/network_interfaces_fuchsia.cc
[add] https://crrev.com/3e89fd73b6c6aaf6983fd4a88d520988ff928a61/net/base/network_interfaces_fuchsia.h

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
I still see the following message when running content_shell:
[265631:1148476765:0625/175710.778553:ERROR:network_change_notifier.cc(547)] Not implemented reached in static net::NetworkChangeNotifier *net::NetworkChangeNotifier::Create()

Looks like NetworkChangeNotifier::Create() needs to be updated to create NetworkChangeNotifierFuchsia
Status: Verified (was: Started)
Labels: -M-69 M-71
Status: Assigned (was: Verified)
Whoops, shouldn't have closed the bug - reopening and assigning to self.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82cf3f24165103c9ea063fc3d3a802587cb17d0e

commit 82cf3f24165103c9ea063fc3d3a802587cb17d0e
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Oct 02 23:00:26 2018

[fuchsia] Add NetworkChangeNotifier singleton creation logic.

The NetworkChangeNotifier is ready to use, now let's actually use it.
:)

TEST=Exercised change event detection on Ethernet w/Acer Switch 12.

Bug:  843443 
Change-Id: I23c4ebbcb536dba55ee6b5b86ecdef775f90bd2f
Reviewed-on: https://chromium-review.googlesource.com/c/1257548
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596026}
[modify] https://crrev.com/82cf3f24165103c9ea063fc3d3a802587cb17d0e/net/base/network_change_notifier.cc

Status: Fixed (was: Assigned)

Sign in to add a comment