New issue
Advanced search Search tips

Issue 843440 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Test]: Network requests timings are broken in DevTools

Project Member Reported by krajshree@chromium.org, May 16 2018

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/560e1ab54b7397d97533fd08a047ca7f54071bcf

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=835502

Thank you.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8004bde35ba57035a7de0e85ed80d34573bc365d

commit 8004bde35ba57035a7de0e85ed80d34573bc365d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu May 17 14:37:31 2018

Fix inter-process completion timestamp conversion

We basically use request completion time recorded in the render
process to calculate responseEnd defined in Resource Timing API. This
is problematic because the renderer main thread can be blocked for a
long time, and that is confusing users of devtools and Resource
Timing API.

This CL changes how to calculate responseEnd. With this CL, it will be
calculated based on the completion time recorded in the browser
process.

Bug:  824155 ,  835502 ,  843440 
Change-Id: I990da586a86c420d21a8115d13e840f7c29d462e
Reviewed-on: https://chromium-review.googlesource.com/1053849
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559530}
[modify] https://crrev.com/8004bde35ba57035a7de0e85ed80d34573bc365d/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/8004bde35ba57035a7de0e85ed80d34573bc365d/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/8004bde35ba57035a7de0e85ed80d34573bc365d/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/8004bde35ba57035a7de0e85ed80d34573bc365d/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/8004bde35ba57035a7de0e85ed80d34573bc365d/content/renderer/loader/test_request_peer.h

Status: Fixed (was: Assigned)

Sign in to add a comment