New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843426 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

UI text rendered incorrectly when corner bracket characters placed near emoji

Reported by khym.cha...@gmail.com, May 16 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Go to an HTML page where the left corner bracket unicode character (「) is immediately before or after the butterfly unicode character (🦋) with no intervening spaces.

What is the expected behavior?
The title in the pages tab renders properly.

What went wrong?
The butterfly renders as a square.

Did this work before? N/A 

Chrome version: 66.0.3359.139  Channel: n/a
OS Version: Fedora 27
Flash Version: 

A test case HTML file is attached.
 
test.html
92 bytes View Download
Labels: Needs-Triage-M66
Labels: M-68 Triaged-ET FoundIn-68 Target-68 OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version 66.0.3359.139 and on latest chrome stable 66.0.3359.181 using Ubuntu 17.10 and Windows 10 and on latest chrome# 68.0.3432.0. As the issue is seen from M-60(60.0.3112.0) considering this issue as Non-Regression and marking it as untriage.
Note: This issue is not seen on Mac.

Thanks!
Components: -UI UI>Browser>TabStrip
Cc: msw@chromium.org
Components: -UI>Browser>TabStrip Internals>Core
Sounds like some kind of issue in how we do font rendering.

Mike, do you know what the right component/owner is for this?
 Issue 865742  has been merged into this issue.
Summary: UI text rendered incorrectly when corner bracket characters placed near emoji (was: Tab title rendered incorrectly if left corner bracket right next to butterfly)
See additional cases on duped-in bug.
Cc: groby@chromium.org ccameron@chromium.org tapted@chromium.org
Components: -Internals>Core UI>Browser>TabStrip UI>GFX Internals>Views
Sorry, I don't believe anyone has been consistently working on RenderText.
tapted fixed  Issue 851241 , but I feel like Trent has a lot on his plate.
ccameron is working on Issue 862773, but that's more specific to Mac.
There are lots of open and one-off assigned RenderText bugs out there.
It would be nice if someone was concertedly working on views/gfx text code.
Labels: -Type-Bug -Pri-2 M-69 OS-Mac Pri-1 Type-Bug-Regression
Owner: tapted@chromium.org
Status: Started (was: Untriaged)
This will regress on Mac in m69. And in a worse way :/. On Mac, the butterfly is blank rather than getting a "tofu" square.

I'm timeboxing an ~hour to investigate.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac7c259316c75aad05150d0a5948787efd9e1803

commit ac7c259316c75aad05150d0a5948787efd9e1803
Author: Trent Apted <tapted@chromium.org>
Date: Mon Jul 23 23:55:16 2018

RenderTextHarfBuzz: treat 「」 as brackets.

Brackets have the "common script" unicode property and need special handling
when breaking runs (see http://www.unicode.org/reports/tr24/#Common ).

Currently, emoji breaks runs correctly around other bracket and quote mark
types, but not around 「」, which is commonly used in CJK languages.

Bug:  843426 ,  396776 
Change-Id: Ia5ff5165d5c260aa1876488e2f51d566f2164cd6
Reviewed-on: https://chromium-review.googlesource.com/1146401
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577345}
[modify] https://crrev.com/ac7c259316c75aad05150d0a5948787efd9e1803/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/ac7c259316c75aad05150d0a5948787efd9e1803/ui/gfx/render_text_unittest.cc

Labels: Merge-Request-69
Requesting a merge for r577345. This fixes the most commonly used quote mark for Japanese, and per #c8 this is worse on Mac since we don't get "tofu". Tested 70.0.3501.2 and the fix is working as intended.

But I've done a bit more research, and I think we need a more generic fix. Filed  Issue 867196 .
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 26

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2638fac865d4f1debec5064f78e87b9a793c9653

commit 2638fac865d4f1debec5064f78e87b9a793c9653
Author: Trent Apted <tapted@chromium.org>
Date: Thu Jul 26 00:34:42 2018

[merge-m69] RenderTextHarfBuzz: treat 「」 as brackets.

Brackets have the "common script" unicode property and need special handling
when breaking runs (see http://www.unicode.org/reports/tr24/#Common ).

Currently, emoji breaks runs correctly around other bracket and quote mark
types, but not around 「」, which is commonly used in CJK languages.

TBR=tapted@chromium.org

(cherry picked from commit ac7c259316c75aad05150d0a5948787efd9e1803)

Bug:  843426 ,  396776 
Change-Id: Ia5ff5165d5c260aa1876488e2f51d566f2164cd6
Reviewed-on: https://chromium-review.googlesource.com/1146401
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577345}
Reviewed-on: https://chromium-review.googlesource.com/1150017
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#97}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2638fac865d4f1debec5064f78e87b9a793c9653/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/2638fac865d4f1debec5064f78e87b9a793c9653/ui/gfx/render_text_unittest.cc

Status: Fixed (was: Started)
Fixed, but more follow-up in  Issue 867196 

Sign in to add a comment