New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843420 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: May 2018
Cc:
█ gsennton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Code style: unnecessary interface modifier

Project Member Reported by ntfschr@chromium.org, May 16 2018 
Methods on a public interface are implicitly public. Specifying the methods as "public" is redundant (and a lint warning).

This affects:

 * WebResourceErrorBoundaryInterface
 * WebResourceRequestBoundaryInterface
 * SafeBrowsingResponseBoundaryInterface
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393cfcaff4c98af880deff6fbd69cd78b203f5dd

commit 393cfcaff4c98af880deff6fbd69cd78b203f5dd
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed May 16 23:18:12 2018

AW: remove redundant public modifier from interfaces

No change to logic.

This removes the 'public' visibility modifier from methods on public
interfaces, as these methods are implicitly public (and this is a lint
warning on the Android side).

Bug:  843420 
Test: N/A
Change-Id: I17ea506f8cb7965c80e2489d985d1a3f2476fb50
Reviewed-on: https://chromium-review.googlesource.com/1062965
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559326}
[modify] https://crrev.com/393cfcaff4c98af880deff6fbd69cd78b203f5dd/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/SafeBrowsingResponseBoundaryInterface.java
[modify] https://crrev.com/393cfcaff4c98af880deff6fbd69cd78b203f5dd/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebResourceErrorBoundaryInterface.java
[modify] https://crrev.com/393cfcaff4c98af880deff6fbd69cd78b203f5dd/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebResourceRequestBoundaryInterface.java

Comment 2 by ntfschr@chromium.org, May 16 2018

Status: Verified (was: Assigned)
I'll verify the corresponding android-side cherry pick resolves the lint issues.
►

Sign in to add a comment