New issue
Advanced search Search tips

Issue 843392 link

Starred by 2 users
Status: Fixed
Owner:
derat@chromium.org
Closed: Aug 28
Cc:
satorux@chromium.org
jamescook@chromium.org
steve...@chromium.org
hashimoto@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 629707



Sign in to add a comment

Move CrosDBusService::ServiceProviderInterface implementations out of //chromeos/dbus/services

Project Member Reported by derat@chromium.org, May 15 2018 
Chrome's //chromeos/dbus/services directory contains various D-Bus services. Historically, we put everything here because it was all exported via org.chromium.LibCrosService, but each of these has its own service now.

These classes (and their permission files) should be moved into either //chrome/browser/chromeos/dbus or //ash/dbus depending on whether they need the browser or not.

These should be under //chrome:

ChromeFeaturesServiceProvider
DriveFileStreamServiceProvider
ProxyResolutionServiceProvider
VirtualFileRequestServiceProvider
VmApplicationsServiceProvider

LivenessServiceProvider should be under //ash (I think; see  issue 644322 ).

Comment 1 by derat@chromium.org, Aug 18

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015280d9b698897d5c0edf1badeda7652d707caa

commit 015280d9b698897d5c0edf1badeda7652d707caa
Author: Daniel Erat <derat@chromium.org>
Date: Tue Aug 21 02:13:00 2018

chromeos: Move services out of //chromeos/dbus/services.

Move CrosDBusService::ServiceProviderInterface
implementations and the corresponding D-Bus config files out
of //chrome/dbus/services and into either //ash/dbus or
//chrome/browser/chromeos/dbus (depending on where they're
actually instantiated).

Also move LivenessServiceProvider ownership from //chrome to
//ash since it doesn't have any dependencies on //chrome.

Bug:  843392 
Change-Id: Iba80bd36d6db007260f2fe32b21709ef288f74c9
Reviewed-on: https://chromium-review.googlesource.com/1180608
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584594}
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/BUILD.gn
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/ash_dbus_services.cc
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/ash_dbus_services.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/liveness_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/liveness_service_provider.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/org.chromium.DisplayService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/ash/dbus/org.chromium.LivenessService.conf
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/chrome_features_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/chrome_features_service_provider.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/chrome_proxy_resolution_service_provider_delegate.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/component_updater_service_provider.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/drive_file_stream_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/drive_file_stream_service_provider.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/finch_features_service_provider_delegate.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/kiosk_info_service_provider.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.ChromeFeaturesService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.DriveFileStreamService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.KioskAppService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.NetworkProxyService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.VirtualFileRequestService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/org.chromium.VmApplicationsService.conf
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/virtual_file_request_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/virtual_file_request_service_provider.h
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/vm_applications_service_provider.cc
[rename] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/vm_applications_service_provider.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chrome/browser/chromeos/dbus/vm_applications_service_provider_delegate.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chromeos/BUILD.gn
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chromeos/components/drivefs/BUILD.gn
[delete] https://crrev.com/a3bb147e222231c16574a0908c119de9702603ab/chromeos/components/drivefs/drive_file_stream_service_provider_delegate.cc
[delete] https://crrev.com/a3bb147e222231c16574a0908c119de9702603ab/chromeos/components/drivefs/drive_file_stream_service_provider_delegate.h
[modify] https://crrev.com/015280d9b698897d5c0edf1badeda7652d707caa/chromeos/dbus/services/README.md
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cb5c6a372f0ef17539c8eb9e2235320e50b285c

commit 6cb5c6a372f0ef17539c8eb9e2235320e50b285c
Author: Daniel Erat <derat@chromium.org>
Date: Tue Aug 21 14:51:55 2018

chromeos: Add READMEs for ash/dbus and c/b/chromeos/dbus.

Add README.md files in //ash/dbus and
//chrome/browser/chromeos/dbus.

Bug:  843392 
Change-Id: I31181b72aabf60f7c09feda7e8081078215ad472
Reviewed-on: https://chromium-review.googlesource.com/1182951
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584738}
[add] https://crrev.com/6cb5c6a372f0ef17539c8eb9e2235320e50b285c/ash/dbus/README.md
[add] https://crrev.com/6cb5c6a372f0ef17539c8eb9e2235320e50b285c/chrome/browser/chromeos/dbus/README.md
[modify] https://crrev.com/6cb5c6a372f0ef17539c8eb9e2235320e50b285c/chromeos/dbus/services/README.md
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3924f9bed588e1c1413caa98621d805a6de4e47d

commit 3924f9bed588e1c1413caa98621d805a6de4e47d
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 22 00:23:27 2018

chromeos: Remove VmApplicationsServiceProvider::Delegate.

Now that VmApplicationsServiceProvider lives in
//chrome/browser/chromeos/dbus, it no longer needs a
Delegate interface.

Bug:  843392 
Change-Id: I1c9a0cf0a251d12bf3a0c33a58b0d6e177859618
Reviewed-on: https://chromium-review.googlesource.com/1184142
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584931}
[modify] https://crrev.com/3924f9bed588e1c1413caa98621d805a6de4e47d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3924f9bed588e1c1413caa98621d805a6de4e47d/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/3924f9bed588e1c1413caa98621d805a6de4e47d/chrome/browser/chromeos/dbus/vm_applications_service_provider.cc
[modify] https://crrev.com/3924f9bed588e1c1413caa98621d805a6de4e47d/chrome/browser/chromeos/dbus/vm_applications_service_provider.h
[delete] https://crrev.com/be6556aa4558be2e92b4ab1eb603fe3b0d8b3783/chrome/browser/chromeos/dbus/vm_applications_service_provider_delegate.cc
[delete] https://crrev.com/be6556aa4558be2e92b4ab1eb603fe3b0d8b3783/chrome/browser/chromeos/dbus/vm_applications_service_provider_delegate.h
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1594c270a0c01534ad33c262e3d356ffc63b38

commit db1594c270a0c01534ad33c262e3d356ffc63b38
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 22 00:37:08 2018

chromeos: Remove ChromeFeaturesServiceProvider::Delegate.

Now that ChromeFeaturesServiceProvider lives in
//chrome/browser/chromeos/dbus, it no longer needs a
Delegate interface.

Bug:  843392 
Change-Id: Ia4b4a737e8cde0b517f6975994238dc8f03fec1a
Reviewed-on: https://chromium-review.googlesource.com/1184168
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584936}
[modify] https://crrev.com/db1594c270a0c01534ad33c262e3d356ffc63b38/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/db1594c270a0c01534ad33c262e3d356ffc63b38/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/db1594c270a0c01534ad33c262e3d356ffc63b38/chrome/browser/chromeos/dbus/chrome_features_service_provider.cc
[modify] https://crrev.com/db1594c270a0c01534ad33c262e3d356ffc63b38/chrome/browser/chromeos/dbus/chrome_features_service_provider.h
[delete] https://crrev.com/e17cb99474da0d0369b53e4e383ca65acc8ee633/chrome/browser/chromeos/dbus/finch_features_service_provider_delegate.cc
[delete] https://crrev.com/e17cb99474da0d0369b53e4e383ca65acc8ee633/chrome/browser/chromeos/dbus/finch_features_service_provider_delegate.h
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27fd642c6f514b5cd90366b38c7b27396c140655

commit 27fd642c6f514b5cd90366b38c7b27396c140655
Author: Daniel Erat <derat@chromium.org>
Date: Thu Aug 23 14:42:58 2018

chromeos: Remove VirtualFileRequestServiceProvider::Delegate

Now that VirtualFileRequestServiceProvider lives in
//chrome/browser/chromeos/dbus, it no longer needs a
Delegate interface.

Bug:  843392 
Change-Id: Iaafc3d7d79c6c39cca0e8de2febe31bad07efd6e
Reviewed-on: https://chromium-review.googlesource.com/1184159
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585485}
[modify] https://crrev.com/27fd642c6f514b5cd90366b38c7b27396c140655/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/27fd642c6f514b5cd90366b38c7b27396c140655/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[delete] https://crrev.com/8dd16ecbd1c7498ac8cfac0706bc57e231133acf/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.cc
[delete] https://crrev.com/8dd16ecbd1c7498ac8cfac0706bc57e231133acf/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.h
[modify] https://crrev.com/27fd642c6f514b5cd90366b38c7b27396c140655/chrome/browser/chromeos/dbus/virtual_file_request_service_provider.cc
[modify] https://crrev.com/27fd642c6f514b5cd90366b38c7b27396c140655/chrome/browser/chromeos/dbus/virtual_file_request_service_provider.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3043b5ce657b9675d9de9391b29749ad5209f4e2

commit 3043b5ce657b9675d9de9391b29749ad5209f4e2
Author: Daniel Erat <derat@chromium.org>
Date: Fri Aug 24 05:08:40 2018

chromeos: Remove ProxyResolutionServiceProvider::Delegate.

Remove the Delegate interface from
ProxyResolutionServiceProvider. This code lives in
//chrome/browser/chromeos/dbus now, so it's able to access
profiles directly.

Bug:  843392 
Change-Id: I1fe04762b260fdd4f4cc792f8921c085f1ded7b8
Reviewed-on: https://chromium-review.googlesource.com/1187727
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585686}
[modify] https://crrev.com/3043b5ce657b9675d9de9391b29749ad5209f4e2/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3043b5ce657b9675d9de9391b29749ad5209f4e2/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[delete] https://crrev.com/cdba1b9fb58b1d2039827891e746e2fd8ee8f2d4/chrome/browser/chromeos/dbus/chrome_proxy_resolution_service_provider_delegate.cc
[delete] https://crrev.com/cdba1b9fb58b1d2039827891e746e2fd8ee8f2d4/chrome/browser/chromeos/dbus/chrome_proxy_resolution_service_provider_delegate.h
[modify] https://crrev.com/3043b5ce657b9675d9de9391b29749ad5209f4e2/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc
[modify] https://crrev.com/3043b5ce657b9675d9de9391b29749ad5209f4e2/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h
[modify] https://crrev.com/3043b5ce657b9675d9de9391b29749ad5209f4e2/chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/b7203cec5533f4bd49f5384c1154a8ec4bf61bae

commit b7203cec5533f4bd49f5384c1154a8ec4bf61bae
Author: Daniel Erat <derat@chromium.org>
Date: Tue Aug 28 10:57:00 2018

docs: Remove now-moved services from dbus_in_chrome.md.

Update the "Chrome OS D-Bus Usage in Chrome" doc to not say
that there are D-Bus service implementations in
//chromeos/dbus/services. These services have been moved to
//ash/dbus and //chrome/browser/chromeos/dbus.

BUG= chromium:843392 
TEST=none

Change-Id: I50a3d907c83205b912fd218a851c517e3c26d6e6
Reviewed-on: https://chromium-review.googlesource.com/1188025
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>

[modify] https://crrev.com/b7203cec5533f4bd49f5384c1154a8ec4bf61bae/dbus_in_chrome.md

Comment 9 by derat@chromium.org, Aug 28

Labels: -OS-Linux OS-Chrome
Status: Fixed (was: Started)
►

Sign in to add a comment