New issue
Advanced search Search tips

Issue 843384 link

Starred by 3 users
Status: Fixed
Owner:
juncai@chromium.org
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need unittests for client auth when running in the Network Service

Project Member Reported by rsleevi@chromium.org, May 15 2018 
Noticed when looking at the coverage for services/network/url_loader, we don't have any tests that exercise the client auth path.

Example report: https://chromium-coverage.appspot.com/reports/558266/linux/chromium/src/services/network/url_loader.cc.html

Tests would include:
- Cancelling a connection (not proceeding)
- Continuing with no certificate (sending a null certificate)
- Continuing with a certificate

Testing this at the browsertest layer doesn't work, because the OS-provided client cert store is already glued up, and that's not usable for unittests. This would likely need to be within the URLLoader tests themselves, unless/until a way of imposing additional construction parameters is done.

Comment 1 by rsleevi@chromium.org, May 15 2018 

I suppose continuing with a certificate is really

- Continuing with a certificate and the signature works
- Continuing with the certificate and there's a signature error (simulating smart card ejection)

Comment 2 by xunji...@chromium.org, May 16 2018

Cc: juncai@chromium.org
+juncai, you recently are working on client auth, would you be willing to take this?

Comment 3 by juncai@chromium.org, May 16 2018

Cc: -juncai@chromium.org
Owner: juncai@chromium.org
Status: Assigned (was: Untriaged)
Sure, thanks!

Comment 4 by dxie@chromium.org, May 22 2018 

this will not block canary.

Comment 5 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue

Comment 6 by juncai@chromium.org, Sep 7

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28dc4f10853e82ae4ab52909a346cc51d9b495ba

commit 28dc4f10853e82ae4ab52909a346cc51d9b495ba
Author: Jun Cai <juncai@chromium.org>
Date: Wed Sep 19 16:59:53 2018

Network Service: Add client auth unittests for URLLoader

Bug:  843384 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib5d7677cbba9a715fbe295c530dea58135a79250
Reviewed-on: https://chromium-review.googlesource.com/1222291
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592443}
[modify] https://crrev.com/28dc4f10853e82ae4ab52909a346cc51d9b495ba/services/network/url_loader_unittest.cc

Comment 8 by juncai@chromium.org, Sep 19

Status: Fixed (was: Started)
►

Sign in to add a comment