[Omnibox] poor layout of zero suggest |
|||
Issue description1. open a page to http://garydanko.com/ (or similar) 2. click the window content (to deselect omnibox) 3. select omnibox 4. repeat steps 2 and three if problem is not immediately obvious Problem: The (zero suggest) results do not layout properly.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac33702fb737e579cdbe15ededb3e0cb5841dd5a commit ac33702fb737e579cdbe15ededb3e0cb5841dd5a Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed May 16 02:53:14 2018 [Omnibox] fix layout of zero suggest This CL fixes an issue where the suggest results are not properly lain out for zero suggest. Bug: 843377 Change-Id: If743314703ef21f7734a4073459f436d080b111f Reviewed-on: https://chromium-review.googlesource.com/1060556 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#558942} [modify] https://crrev.com/ac33702fb737e579cdbe15ededb3e0cb5841dd5a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
,
May 16 2018
,
May 17 2018
Tried checking the issue on chrome version 68.0.3433.0 using windows 10 and Ubuntu 14.04 with the below mentioned steps. 1. Launched chrome 2. Navigated to http://garydanko.com/ 3. Clicked on page to shift the focus from omnibox 4. Clicked on omnibox 5. Repeated steps 3 and 4 We didn't observe any suggestions while performing above steps. Attaching the screen cast of the same. Note: Checked the issue by enabling and disabling the flag #enable-zero-suggest-redirect-to-chrome and signed into browser(with sync ON) as per comment#1. @Dave Schuyler: Could you please have a look at the screen cast and let us know if anything missed from our end and please help us in verifying the fix. Thanks!
,
May 17 2018
,
May 17 2018
#4 There's another bug on Windows that is currently blocking your repro on Windows. You're doing the right steps. I believe you'll see it on Linux. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dschuyler@chromium.org
, May 15 2018