WebglConformance_conformance2_glsl3_short_circuiting_in_loop_condition fails on experimental driver |
|||||
Issue descriptionI am disabling WebglConformance_conformance2_glsl3_short_circuiting_in_loop_condition becuase it is failing on our experimental Intel driver bot "Win10 FYI Exp Release (Intel HD 630)". We should re-enable the test after updating to a fixed driver.
,
May 15 2018
,
May 15 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ab0c6255a2d7bba4055d84dba2a15286de2d0d8 commit 5ab0c6255a2d7bba4055d84dba2a15286de2d0d8 Author: James Darpinian <jdarpinian@chromium.org> Date: Wed May 16 01:11:48 2018 Disable failing tests on experimental Intel driver Bug: 843369 , 841789 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id6c695fc7aa3e4ae3019d3b82568dd1453385ebb Reviewed-on: https://chromium-review.googlesource.com/1060521 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558909} [modify] https://crrev.com/5ab0c6255a2d7bba4055d84dba2a15286de2d0d8/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/5ab0c6255a2d7bba4055d84dba2a15286de2d0d8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/5ab0c6255a2d7bba4055d84dba2a15286de2d0d8/testing/buildbot/chromium.gpu.fyi.json
,
May 16 2018
James, Jiajia will investigate this WebGL cts failure on Win10 Intel.
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/4b06c1e9a717565d720fbb837670f4111c04b2e7 commit 4b06c1e9a717565d720fbb837670f4111c04b2e7 Author: Qin Jiajia <jiajia.qin@intel.com> Date: Fri Jun 08 08:38:36 2018 Add a test to expose boolean uniform bug on Intel windows This test is ported from webgl conformance test WebglConformance_conformance2_glsl3_short_circuiting_in_loop_condition. Since HLSL and ESSL have different rules to process short-circuit evaluation, this patch will use the final flattened shader so that the translated HLSL is almost same with the current ES shader. BUG= 843369 TEST=angle_end2end_tests Change-Id: Ibc742f8ac4592a83c4c7dad37a64a5563eb58bd5 Reviewed-on: https://chromium-review.googlesource.com/1090328 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/4b06c1e9a717565d720fbb837670f4111c04b2e7/src/tests/gl_tests/UniformTest.cpp
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c7f374d48ce76fa0512f6668ce1fc503a9aad0 commit b9c7f374d48ce76fa0512f6668ce1fc503a9aad0 Author: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 10:46:33 2018 Roll src/third_party/angle 81970bc..4b06c1e (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/81970bc..4b06c1e git log 81970bc..4b06c1e --date=short --no-merges --format='%ad %ae %s' 2018-06-08 jiajia.qin@intel.com Add a test to expose boolean uniform bug on Intel windows Created with: gclient setdep -r src/third_party/angle@4b06c1e The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:843369 TBR=geofflang@chromium.org Change-Id: Idd424c050f3de1bd4b8bc9ae1c5330c210b67bba Reviewed-on: https://chromium-review.googlesource.com/1092590 Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565606} [modify] https://crrev.com/b9c7f374d48ce76fa0512f6668ce1fc503a9aad0/DEPS
,
Sep 3
This bug is fixed in Intel recent public driver 24.20.100.6286. Thanks.
,
Sep 5
Thanks Jiajia. Removing this suppression in this CL: https://chromium-review.googlesource.com/1207652
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a784487fa9de31752d24bff0871c3cbf451097de commit a784487fa9de31752d24bff0871c3cbf451097de Author: Kenneth Russell <kbr@chromium.org> Date: Wed Sep 05 20:21:27 2018 Re-enable previously failing tests on Win10 Intel Exp bot. After the update to the 24.20.100.6286 driver, these tests should be passing. Re-enable: webgl_conformance_d3d9_tests webgl_conformance_d3d9_passthrough_tests conformance2/glsl3/short-circuiting-in-loop-condition.html Tbr: zmo@chromium.org Bug: 841789 , 843369 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1ec732be8a283c2fdb68bf316943ee2d7d0b65b1 Reviewed-on: https://chromium-review.googlesource.com/1207652 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588987} [modify] https://crrev.com/a784487fa9de31752d24bff0871c3cbf451097de/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/a784487fa9de31752d24bff0871c3cbf451097de/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/a784487fa9de31752d24bff0871c3cbf451097de/testing/buildbot/test_suite_exceptions.pyl
,
Sep 6
Thanks Jiajia for ensuring this test was fixed in the new driver. It's passing here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Exp%20Release%20%28Intel%20HD%20630%29/1233 and specifically in this shard of webgl2_conformance_tests: https://chromium-swarm.appspot.com/task?id=3fc51fc417f21510&refresh=10&show_raw=1 Closing as Verified. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdarpinian@chromium.org
, May 15 2018Labels: GPU-Intel