New issue
Advanced search Search tips

Issue 843366 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Fix WebXR input with UAv2

Project Member Reported by dcheng@chromium.org, May 15 2018

Issue description

It looks like the user gesture token status is ignored, and it doesn't do much. Can it be removed? The only consumer is WebXR.

(The comment is not helpful, since it just says "dummy leftover for compile test")
 

Comment 1 by mustaq@chromium.org, May 16 2018

Cc: bajones@chromium.org
Labels: UserActivation
Status: Started (was: Assigned)
Thanks for the catch.  I also missed that it won't work with User Activation v2.

Comment 2 by mustaq@chromium.org, May 16 2018

Summary: Fix WebXR input with UAv2 (was: Clean up LocalFrame::CreateUserGesture)
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47cf7037cbde6c278e987cde18da3ec8b7a86996

commit 47cf7037cbde6c278e987cde18da3ec8b7a86996
Author: Mustaq Ahmed <mustaq@google.com>
Date: Wed May 16 18:24:03 2018

Fix user activation v2 trigger for a WebXR input.

Bug:  843366 
Change-Id: Ifa1d702a1357e4f508f708b5cf9783d0db90ad06
Reviewed-on: https://chromium-review.googlesource.com/1062009
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559190}
[modify] https://crrev.com/47cf7037cbde6c278e987cde18da3ec8b7a86996/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/47cf7037cbde6c278e987cde18da3ec8b7a86996/third_party/blink/renderer/modules/xr/xr_session.cc

Comment 4 by mustaq@chromium.org, May 16 2018

Status: Fixed (was: Started)
Components: Blink>WebXR

Sign in to add a comment