New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843359 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Omnibox] remove extra layout call

Project Member Reported by dschuyler@chromium.org, May 15 2018

Issue description

The chrome omnibox performs a redundant layout that may affect the refresh time of the dropdown. Remove this extra layout call.
 
Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, May 15 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mpear...@chromium.org

Comment 5 by gov...@chromium.org, May 15 2018

Before we approve merge to M67, please answer followings:
* Is this M67 regression? Is it critical?
* Is this feature behind finch and can be easily disabled if something goes wrong?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67?
* Any other important details to justify the merge.

Please note M67 is already in Beta, so merge bar is very high. Thank you.
We (omnibox team) investigated further and agreed that this merge is not especially important. The merge request can be ignored.

Comment 7 by gov...@chromium.org, May 17 2018

Labels: -Merge-Review-67 Merge-Rejected-67
Thank you  jdonnelly@ and omnibox team.

Rejecting merge to M67 based on comment #6.

Sign in to add a comment