"sizes" step fails on Google Chrome Mac builder |
||||||
Issue descriptionhttps://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/ started failing from https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/33204. Example failure log from https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F33204%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout: /usr/bin/python /b/rr/tmpOp5YwX/rw/checkout/scripts/slave/runisolatedtest.py --test_name sizes --builder_name "Google Chrome Mac" --checkout_dir /b/c/b/Google_Chrome_Mac /b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py -- /usr/bin/python /b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py --target Release --platform mac /usr/bin/python2.7 /b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py --target Release --platform mac Traceback (most recent call last): File "/b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py", line 561, in <module> sys.exit(main()) File "/b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py", line 551, in main rc = real_main(options, args, results_collector) File "/b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py", line 131, in main_mac 'framework_size' : get_size(chromium_framework_executable) File "/b/c/b/Google_Chrome_Mac/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py", line 50, in get_size return os.stat(filename)[stat.ST_SIZE] OSError: [Errno 2] No such file or directory: '/b/c/b/Google_Chrome_Mac/src/out/Release/Google Chrome Framework.framework/Google Chrome Framework'
,
May 15 2018
Red waterfall bots are bad - I think a Pri1 might be appropriate.
,
May 15 2018
I'm not on Chrome any more.
,
May 15 2018
That's weird, I wouldn't expect anything to have changed. Looking more closely.
,
May 15 2018
(attempting to repro locally now).
,
May 15 2018
speculatively reverting the buildtools roll in the meantime to see if it helps, too.
,
May 16 2018
I did repro the problem locally, but I have no idea what caused it yet, bisecting to see further.
,
May 16 2018
The latest build on the builder (containing my revert) went green, which certainly seems to indicate that the problem was the buildtools roll. My best guess is that (a) this is indeed the GN changes in the roll, and (b) it's specifically https://crrev.com/c/1041506, which might've caused some dependency in the build to get dropped, and so "out/Release/Google Chrome Framework.framework/Google Chrome Framework" doesn't get created. I don't know if that's the case, and if so, why not, yet. Continuing to try and repro / dig in further. +tikuta
,
May 16 2018
I think there's some subtle difference in the way the dependencies are propagating between the bundles in the sort of way this change might've affected. But, I don't understand either the mac framework templates or tikuta's change quite well enough to see exactly what the difference is. I think there's a delta in the ninja dependency graph here but I can't tell what. As a result, I can't tell if this is a case of a missing dependency that we were implicitly depending on before, or if tikuta's change is fundamentally unsound. The revert fixed the build brokenness, and I'm 95% certain it's tikuta's change, so I'm going to close this for now. @tikuta - I'm punting this to you to pursue further.
,
May 16 2018
Also, I'm going to revert tikuta's change so that we can safely roll GN otherwise.
,
May 16 2018
I see. I'll take a look what happens. Let me try again if I could fix root cause. Thank you for reverting. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lukasza@chromium.org
, May 15 2018Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)