New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843350 link

Starred by 2 users
Status: Started
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Cc:
alemate@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 856337


Sign in to add a comment

Remove usages of paper-item, paper-icon-item and paper-listbox

Project Member Reported by dpa...@chromium.org, May 15 2018 
This item is similar to paper-item, where it does not really have a reason to exist. It just provides some styling, that can be otherwise applied to normal elements (div or span etc).

We should update usages, and remove it from third_party/polymer. Currently used in the following files (also see [1]):

chrome/browser/resources/chromeos/login/controller-pairing-screen.html
chrome/browser/resources/chromeos/emulator/device_emulator_pages.html
chrome/browser/resources/chromeos/login/host-pairing-screen.html

[1] https://cs.chromium.org/search/?q=paper-icon-item.html+-file:third_party+-file:infra+-file:out/Debug&type=cs

Comment 1 by dpa...@chromium.org, Jun 25 2018

Cc: alemate@chromium.org

Comment 2 by alemate@chromium.org, Jun 25 2018

Blockedon: 856337

Comment 3 by scottchen@chromium.org, Jul 2

Owner: scottchen@chromium.org
Status: Started (was: Available)

Comment 4 by scottchen@chromium.org, Jul 2

Status: Assigned (was: Started)

Comment 5 by scottchen@chromium.org, Jul 18

Summary: Remove usages of paper-icon-item and paper-listbox (was: Remove usages of paper-icon-item)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa81516839775f49de6e626c08c37d29133d00d3

commit aa81516839775f49de6e626c08c37d29133d00d3
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jul 19 23:19:53 2018

Device Emulator: remove usages of paper-icon-item and paper-listbox

This CL is part of the effort to remove rarely-used paper elements
from the code base completely.

Bug: 843350
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibd693c71e2e62e6056b565a8c4f9e0895edc3c6a
Reviewed-on: https://chromium-review.googlesource.com/1142576
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576684}
[modify] https://crrev.com/aa81516839775f49de6e626c08c37d29133d00d3/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html
[modify] https://crrev.com/aa81516839775f49de6e626c08c37d29133d00d3/chrome/browser/resources/chromeos/emulator/device_emulator_pages.js
[modify] https://crrev.com/aa81516839775f49de6e626c08c37d29133d00d3/chrome/browser/resources/chromeos/emulator/input_device_settings.html

Comment 7 by scottchen@chromium.org, Jul 20

Status: Started (was: Assigned)
Summary: Remove usages of paper-item, paper-icon-item and paper-listbox (was: Remove usages of paper-icon-item and paper-listbox)
shortcut to check if done - the following searches should return no results:

https://cs.chromium.org/search/?q=%22%3Cpaper-icon-item%22+-file:third_party/+-file:infra&sq=package:chromium&type=cs
https://cs.chromium.org/search/?q=%22%3Cpaper-item%22+-file:third_party/+-file:infra&sq=package:chromium&type=cs
https://cs.chromium.org/search/?q=%22%3Cpaper-listbox%22+-file:third_party/+-file:infra&sq=package:chromium&type=cs
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acbb7a911c885b1f56ae825bfd9075cde742dfc

commit 2acbb7a911c885b1f56ae825bfd9075cde742dfc
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Aug 07 02:25:47 2018

Media Router: remove paper-item and paper-listbox

Replaces paper-item and paper-listbox in media-router/ with iron-selector
and a plain div. Visually matches original code.

Bug: 843350
Change-Id: Ib9a91cd9c804e43e3d99b273332b0192db206c7c
Reviewed-on: https://chromium-review.googlesource.com/1145945
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581099}
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/browser/resources/media_router/media_router.css
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/test/data/webui/media_router/media_router_container_search_tests.js
[modify] https://crrev.com/2acbb7a911c885b1f56ae825bfd9075cde742dfc/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c51314e42d995e17c29ba9224f9294782da1e67

commit 9c51314e42d995e17c29ba9224f9294782da1e67
Author: dpapad <dpapad@chromium.org>
Date: Tue Oct 30 23:28:47 2018

WebUI Polymer: Remove unused polymer elements from the repository.

Removing paper-input, paper-textarea, iron-autogrow-textarea, paper-listbox.

paper-input was only used by paper-slider, if an "editable" boolean is set to
true, which is not the case for any usage of paper-slider. Removed that dependency
in the local paper-slider copy. Also remaining usages of paper-slider will be
replaced with cr-slider sometime soon anyway.

Also remove local patch for paper-input and paper-textarea from chromium.patch.

Bug: 899982,843350
Change-Id: If2e7815259034748db890ac736c32f064ff3c968
Reviewed-on: https://chromium-review.googlesource.com/c/1306346
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604054}
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/chromium.patch
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/bower.json
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-input/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/paper-listbox-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/paper-listbox.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-slider/BUILD.gn
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/ui/webui/resources/polymer_resources.grdp
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66403a8d6a5debc9f4352436253106eb1140ad7

commit a66403a8d6a5debc9f4352436253106eb1140ad7
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 31 03:46:41 2018

WebUI Polymer: Remove paper-item from the final binary.

Also remove paper-item-body element, which was never used.

Bug: 843350
Change-Id: I01f940f47856a6e739b9844ba194c85a19901fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1307073
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604140}
[modify] https://crrev.com/a66403a8d6a5debc9f4352436253106eb1140ad7/third_party/polymer/v1_0/components-chromium/paper-item/BUILD.gn
[delete] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/third_party/polymer/v1_0/components-chromium/paper-item/all-imports.html
[delete] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-body-extracted.js
[delete] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-body.html
[delete] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-extracted.js
[delete] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/third_party/polymer/v1_0/components-chromium/paper-item/paper-item.html
[modify] https://crrev.com/a66403a8d6a5debc9f4352436253106eb1140ad7/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/a66403a8d6a5debc9f4352436253106eb1140ad7/ui/webui/resources/polymer_resources.grdp
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5790614e8678a444265a0f944ca23d0165827f38

commit 5790614e8678a444265a0f944ca23d0165827f38
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 15 01:06:52 2018

WebUI cleanup: Remove unused Polymer elements from Desktop builds.

The following elements are only used in ChromeOS, so they don't have
to be included in non-ChromeOS builds

 - iron-input
 - paper-input-container
 - paper-icon-item

Bug:843350,899982

Change-Id: I376e811a6b53fca71ea5a14df479c6f958632547
Reviewed-on: https://chromium-review.googlesource.com/c/1336189
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608206}
[modify] https://crrev.com/5790614e8678a444265a0f944ca23d0165827f38/ui/webui/resources/polymer_resources.grdp

Comment 13 by dpa...@chromium.org, Dec 17 

FYI, last usages of paper-icon-item have been removed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1114240. We can now delete paper-item completely.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e61e5cf916bede2f08eabc7eb4c962247616e39

commit 4e61e5cf916bede2f08eabc7eb4c962247616e39
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Dec 17 23:29:40 2018

WebUI: make polymer's reproduce.sh clean up excluded files.

Files that were in rsync_exclude.txt were just ignored and left in the
codebase. This CL makes the reproduce script clean up the excluded files.

Bug: 843350, 902959
Change-Id: I99d2147cb0f73d51dd9fe4443b5ce677e4d37d37
Reviewed-on: https://chromium-review.googlesource.com/c/1380938
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617284}
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/hero-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/opaque-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/reverse-ripple-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/ripple-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-down-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-up-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-bottom-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-left-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-right-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-top-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-left-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-right-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-up-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/transform-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation.html
[delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animations.html
[modify] https://crrev.com/4e61e5cf916bede2f08eabc7eb4c962247616e39/third_party/polymer/v1_0/reproduce.sh
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c906bb6e36e5d3df1be80171dad1aaac28bac50

commit 6c906bb6e36e5d3df1be80171dad1aaac28bac50
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Dec 18 20:24:10 2018

WebUI: remove paper-item from third_party.

Bug: 843350
Change-Id: Icf3f53aa1fb8c1e81e205098d4427c4769566314
Reviewed-on: https://chromium-review.googlesource.com/c/1380899
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617606}
[modify] https://crrev.com/6c906bb6e36e5d3df1be80171dad1aaac28bac50/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/BUILD.gn
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/bower.json
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/paper-icon-item-extracted.js
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/paper-icon-item.html
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior-extracted.js
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior.html
[delete] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html
[modify] https://crrev.com/6c906bb6e36e5d3df1be80171dad1aaac28bac50/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/6c906bb6e36e5d3df1be80171dad1aaac28bac50/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/6c906bb6e36e5d3df1be80171dad1aaac28bac50/ui/webui/resources/polymer_resources.grdp
►

Sign in to add a comment