WebUI: Checkbox tick mark is not centered. |
|||
Issue descriptionCompare the two checkboxes on the attached screenshot. The top one is not as centered as the bottom one. The top one matches the previous element's (paper-checkbox) positioning. Now that we have our own element (cr-checkbox), we don't need to preserve the slightly misaligned checkmark.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab72aee08f2c5814b3e5502f68b60d9cb859a517 commit ab72aee08f2c5814b3e5502f68b60d9cb859a517 Author: Scott Chen <scottchen@chromium.org> Date: Wed May 16 19:41:51 2018 WebUI[MD-refresh]: center cr-checkbox's checkmark Bug: 843334 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e087221f922f9abf2327bd10defb19b671dfb29 Reviewed-on: https://chromium-review.googlesource.com/1059867 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559235} [modify] https://crrev.com/ab72aee08f2c5814b3e5502f68b60d9cb859a517/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
,
May 16 2018
,
May 17 2018
,
May 17 2018
Verified the fix on Windows 10, Mac 10.13.3 and Ubuntu 14.04 using Chrome version #68.0.3433.0 as per the comment #0. Able to reproduce the issue on chrome version 68.0.3432.0 (build without fix) Attaching screenshot for reference. Observed that "Check boxes are correctly aligned." Hence, the fix is working as expected, adding Verified labels Thanks...! |
|||
►
Sign in to add a comment |
|||
Comment 1 by scottchen@chromium.org
, May 16 2018