New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843331 link

Starred by 2 users
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Aug 23
Cc:
█ fsam...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Metabug: Bring up viz_interactive_ui_tests

Project Member Reported by jonr...@chromium.org, May 15 2018 
We'd like to get interactive_ui_tests running in Viz mode:
  --enable-features=VizDisplayCompositor

This is the metabug to track getting this suite up and running. All issues associated with this should me marked as blocking this.

I'll initially bring this up on our FYI bots first to find out what errors exist.
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e7d0c01c5349d0e140a767bb4973c1f46b6c5b

commit b0e7d0c01c5349d0e140a767bb4973c1f46b6c5b
Author: jonross <jonross@chromium.org>
Date: Tue May 15 22:23:10 2018

Add viz_interactive_ui_tests to FYI bots

There are currently a set of FYI bots running Viz varients of test suites:
  --enable-features=VizDisplayCompositor

This change ads a viz variant of interactive_ui_tests to these FYI bots. So that
we can begin getting coverage of this suite.

TEST=viz_interactive_ui_tests

Bug:  843331 
Change-Id: Id56e2f8f0f1748823d5c17d938ff0582c066301c
Reviewed-on: https://chromium-review.googlesource.com/1060423
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558860}
[modify] https://crrev.com/b0e7d0c01c5349d0e140a767bb4973c1f46b6c5b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/b0e7d0c01c5349d0e140a767bb4973c1f46b6c5b/testing/buildbot/test_suites.pyl

Comment 2 by xing...@intel.com, Jun 13 2018 

I run ./out/Debug/interactive_ui_tests  --enable-features=VizDisplayCompositor on my ununtu 16.04, got below failures:


Too many failing tests (89), skipping retries.
21 tests failed:
    All/PasswordManagerBrowserTestWithConditionalPopupViews.PromptForFetchWithNewPasswordsWithoutOnSubmit/0 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode (../../chrome/browser/ui/browser_command_controller_interactive_browsertest.cc:20)
    BrowserFocusTest.TabsRememberFocus (../../chrome/browser/ui/browser_focus_uitest.cc:272)
    CrossSiteSubframe/DragAndDropBrowserTest.CrossSiteDrag/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    CrossSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    CrossSiteSubframe/DragAndDropBrowserTest.DragImageFromDisappearingFrame/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    CrossSiteSubframe/DragAndDropBrowserTest.DropTextFromOutside/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    FindInPageTest.SelectionRestoreOnTabSwitch (../../chrome/browser/ui/views/find_bar_views_interactive_uitest.cc:293)
    OmniboxViewTest.SelectAllStaysAfterUpdate (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1950)
    OmniboxViewTest.UndoRedo (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1593)
    OmniboxViewViewsTest.DeactivateTouchEditingOnExecuteCommand (../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:462)
    OmniboxViewViewsTest.SelectAllOnTap (../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:272)
    SameSiteSubframe/DragAndDropBrowserTest.CrossSiteDrag/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    SameSiteSubframe/DragAndDropBrowserTest.DragImageFromDisappearingFrame/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    SameSiteSubframe/DragAndDropBrowserTest.DropTextFromOutside/0 (../../chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:731)
    SelectedKeywordViewTest.TestSelectedKeywordViewIsExtensionShortname (../../chrome/browser/ui/views/location_bar/selected_keyword_view_interactive_uitest.cc:41)
    SitePerProcessInteractiveBrowserTest.DocumentHasFocus (../../chrome/browser/site_per_process_interactive_browsertest.cc:126)
    SitePerProcessInteractiveBrowserTest.SequentialFocusNavigation (../../chrome/browser/site_per_process_interactive_browsertest.cc:256)
    SitePerProcessInteractiveBrowserTest.TabAndMouseFocusNavigation (../../chrome/browser/site_per_process_interactive_browsertest.cc:335)
    WidgetTestInteractive.RestoreAfterMinimize (../../ui/views/widget/widget_interactive_uitest.cc:1404)
51 tests timed out:
    All/AutofillCreditCardInteractiveTest.FillLocalCreditCard/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2200)
    All/AutofillCreditCardInteractiveTest.FillLocalCreditCard/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2200)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_AddsNewFieldTypeGroups/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_AddsNewFieldTypeGroups/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_AfterDelay/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_AfterDelay/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_DoubleSelectUpdated/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_DoubleSelectUpdated/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_FormWithoutName/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_FormWithoutName/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_NotForCreditCard/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_NotForCreditCard/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SecondChange/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SecondChange/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated_FormWithoutName/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated_FormWithoutName/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated_SyntheticForm/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SelectUpdated_SyntheticForm/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SyntheticForm/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.DynamicChangingFormFill_SyntheticForm/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.TwoDynamicChangingFormsFill/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillDynamicFormInteractiveTest.TwoDynamicChangingFormsFill/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2614)
    All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2449)
    All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2449)
    All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2449)
    All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:2449)
    All/AutofillInteractiveTest.CrossSitePaymentForms/0 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:730)
    All/AutofillInteractiveTest.CrossSitePaymentForms/1 (../../chrome/browser/autofill/autofill_interactive_uitest.cc:730)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.ManualFallbackForSaving_HideAfterTimeout/1 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.ManualFallbackForSaving_HideIcon/0 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.ManualFallbackForSaving_HideIcon/1 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.PromptForXHRWithNewPasswordsWithoutOnSubmit/1 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.PromptForXHRWithoutOnSubmit/0 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    All/PasswordManagerBrowserTestWithConditionalPopupViews.UsernameChanged/0 (../../chrome/browser/password_manager/password_manager_interactive_uitest.cc:70)
    BrowserFocusTest.NoFocusForBackgroundNTP (../../chrome/browser/ui/browser_focus_uitest.cc:763)
    NotificationsApiTest.TestShouldDisplayNormal (../../chrome/browser/extensions/api/notifications/notifications_apitest.cc:428)
    PopupBlockerBrowserTest.AllowPopupThroughContentSettingIFrame (../../chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:402)
    PopupBlockerBrowserTest.WindowFeaturesBarProps (../../chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:516)
    SitePerProcessInteractiveBrowserTest.FullscreenElementInSubframe (../../chrome/browser/site_per_process_interactive_browsertest.cc:646)
    SitePerProcessInteractiveBrowserTest.SubframeAnchorOpenedInBackgroundTab (../../chrome/browser/site_per_process_interactive_browsertest.cc:1397)
    SitePerProcessInteractiveBrowserTest.SubframeKeyboardEventRouting (../../chrome/browser/site_per_process_interactive_browsertest.cc:192)
    SitePerProcessInteractivePDFTest.ContextMenuPositionForEmbeddedPDFInCrossOriginFrame (../../chrome/browser/site_per_process_interactive_browsertest.cc:1094)
    SitePerProcessTextInputManagerTest.ClosingTabWillNotCrash (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:646)
    SitePerProcessTextInputManagerTest.ResetStateAfterBrowserNavigation (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:625)
    SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:1133)
    ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction (../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:220)
    WebAuthFocusTest.Focus (../../chrome/browser/webauth_interactive_uitest.cc:86)
17 tests crashed:
    SitePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaEscapeKey (../../chrome/browser/site_per_process_interactive_browsertest.cc:838)
    SitePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaJS (../../chrome/browser/site_per_process_interactive_browsertest.cc:843)
    SitePerProcessInteractiveBrowserTest.FullscreenElementInMultipleSubframes (../../chrome/browser/site_per_process_interactive_browsertest.cc:877)
    SitePerProcessInteractiveBrowserTest.RenderWidgetHostDeletedWhileMouseLocked (../../chrome/browser/site_per_process_interactive_browsertest.cc:1003)
    SitePerProcessInteractiveBrowserTest.ShowAndHideDatePopupInOOPIFMultipleTimes (../../chrome/browser/site_per_process_interactive_browsertest.cc:1307)
    SitePerProcessTextInputManagerTest.ClearFocusedElementOnPage (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:984)
    SitePerProcessTextInputManagerTest.ImeCommitTextForAllFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:803)
    SitePerProcessTextInputManagerTest.ResetStateAfterChildNavigation (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:597)
    SitePerProcessTextInputManagerTest.ResetStateAfterFrameDetached (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:552)
    SitePerProcessTextInputManagerTest.ResetTextInputStateOnActiveWidgetChange (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:666)
    SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:479)
    SitePerProcessTextInputManagerTest.TrackCompositionRangeForAllFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:716)
    SitePerProcessTextInputManagerTest.TrackPageFocusEditableElement (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:943)
    SitePerProcessTextInputManagerTest.TrackSelectionBoundsForAllFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:853)
    SitePerProcessTextInputManagerTest.TrackStateWhenSwitchingFocusedFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:446)
    SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:753)
    SitePerProcessTextInputManagerTest.TrackingFocusedElementForAllFrames (../../chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:895)

Comment 3 by jonr...@chromium.org, Jun 13 2018 

Some failures are being addressed in: https://chromium-review.googlesource.com/c/chromium/src/+/1096914

This should cover: 
  CrossSiteSubframe/DragAndDropBrowserTest.DragStartInFrame/0
  CrossSiteSubframe/DragAndDropBrowserTest.DropTextFromOutside/0
  SitePerProcessInteractiveBrowserTest.TabAndMouseFocusNavigation

The trybots for Linux don't list most of the failures that you are seeing. 

Running locally I'm seeing a few other failures not on the trybots:
 WebAuthFocusTest.Focus
 WidgetInputMethodInteractiveTest.*
 WidgetTestInteractive.*
 WindowActivityWatcherTest.DontFloodUkm
 X11TopmostWindowFinderTest.*
 MenuItemViewTestInsertWithSubmenu0.InsertItemWithSubmenu0 
 MenuItemViewTestInsertWithSubmenu1.InsertItemWithSubmenu1 
 SameSiteSubframe/DragAndDropBrowserTest.CrossSiteDrag/0 
 StartupBrowserCreatorTest.LastUsedProfileActivated 
 ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard

I'll need to check if these are just local flakes.

I've synced to today's ToT, so I wonder if you were just synced to a build which contained general errors. If you can continue to reproduce these, could yo get stack traces of the failures and file bugs for those tests?

Comment 4 by jonr...@chromium.org, Aug 23

Status: Fixed (was: Assigned)
These tests have been stable on our FYI bots for a while.
The main CQ lacks capacity for such a large suite.
We are entering field trials, so Viz will be on by default on the CQ. Thus gaining us the extra coverage we desire.
►

Sign in to add a comment