New issue
Advanced search Search tips

Issue 843330 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Previous locations:
gerrit:9020


Sign in to add a comment

"Choose tryjobs" button is not showing up reliably

Project Member Reported by dpranke@chromium.org, May 15 2018

Issue description

Affected Version: ??

1I have not been able to reproduce this reliably, but in the attached screenshot I'd expect there to be a "choose tryjobs" link on the right side of the page, and there isn't one.


 
Screen Shot 2018-05-15 at 2.20.00 PM.png
22.8 KB View Download

Comment 1 by logan@google.com, May 15 2018

Project: chromium
Moved issue gerrit:9020 to now be  issue chromium:843330 .

Comment 2 by logan@google.com, May 15 2018

Components: Infra>Codereview>Gerrit
interestingly, though I was reloading the page, I kept getting that. I also was not seeing the results of some more recent tryjobs that I had triggered.

I just re-loaded Gerrit in a new page, and now I get an updated list and the icon. I wonder if this was a caching bug in Chrome, or something else.

Comment 4 by no...@chromium.org, May 23 2018

Cc: no...@chromium.org
Labels: Pri-2 Type-Bug
I've seen that too. I think this didn't happen before my recent changes.

Comment 5 by no...@chromium.org, May 23 2018

Labels: -Pri-2 Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/dcc3855b45c70d40f52a04599c4a2743a59ae5a1

commit dcc3855b45c70d40f52a04599c4a2743a59ae5a1
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 01:52:28 2018

[buildbucket-gerrit] Simplify sharedAuthState

Remove unnecessary "oauth_" prefix. The context is sharedAuthState, so it is already
about auth.

Replace oauth_configured, oauth_email and oauth_client_id with a single "config"
which is the oauth config containing email and client_id.

Bug:  843330 
Change-Id: I6b477e4e94c89d8b5841f483dfb9bcf5b88e5977
Reviewed-on: https://chromium-review.googlesource.com/1067767
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/dcc3855b45c70d40f52a04599c4a2743a59ae5a1/src/main/resources/static/cr-buildbucket-client.js
[modify] https://crrev.com/dcc3855b45c70d40f52a04599c4a2743a59ae5a1/test/cr-buildbucket-client_test.html

Starting to clean out the large backlog of untriaged Gerrit bugs and responsibly triage... is this bug fixed now @dprake @nodir?

If not... I'm assuming if nothing has been done since May that this isn't actually a p1?
Status: Fixed (was: New)
i *believe* this was a bug on polygerrit side that was fixed since

Sign in to add a comment