[VR Browsing] Datalist popups 1. can't be dismissed without selecting item, 2. are missing right side borders. |
|||
Issue descriptionChrome Version: 68.0.3427.0 OS: Android N Device: S8+ What steps will reproduce the problem? (1) Enter Chrome VR. (2) Go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_datalist (3) On right side of page, click on datalist box to bring up datalist popup. (4) Click outside of the datalist. Click the app button on the controller. What is the expected result? The datalist should be dismissable without selecting an item. (I think?) And there should be a border around the entire list. What happens instead? The datalist remains open until a selection is made. The right side border is also missing.
,
Jun 12 2018
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c8f1412602bf2fb75365939a9a0f4f08e7c4411 commit 5c8f1412602bf2fb75365939a9a0f4f08e7c4411 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Jul 03 19:47:46 2018 VR: close dialog on outside click DismissHandler is set in VrShellImpl to make it possible to close the dialog when native sends the request. Bug: 843325 Change-Id: I2e83840a77fa47cab0275a1710591bae23627b96 Reviewed-on: https://chromium-review.googlesource.com/1125085 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#572324} [modify] https://crrev.com/5c8f1412602bf2fb75365939a9a0f4f08e7c4411/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialogManager.java [modify] https://crrev.com/5c8f1412602bf2fb75365939a9a0f4f08e7c4411/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrPopupWindow.java [modify] https://crrev.com/5c8f1412602bf2fb75365939a9a0f4f08e7c4411/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jul 3
The problem with dismissing the dialog is fixed. I'll file another bug for the right side problem. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tiborg@chromium.org
, Jun 12 2018Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)